LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] IB/ipoib: fix ipoib_start_xmit()'s return type
@ 2018-04-24 13:15 Luc Van Oostenryck
  2018-04-24 13:32 ` Yuval Shaia
  2018-04-25 15:35 ` Leon Romanovsky
  0 siblings, 2 replies; 4+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:15 UTC (permalink / raw)
  To: linux-kernel
  Cc: Luc Van Oostenryck, Doug Ledford, Jason Gunthorpe,
	Leon Romanovsky, Alex Vesker, Yuval Shaia, Erez Shitrit,
	Dasaratharaman Chandramouli, Feras Daoud, linux-rdma

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.

Fix this by returning 'netdev_tx_t' in this driver too.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index 161ba8c76..cf291f90b 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -1094,7 +1094,7 @@ static void unicast_arp_send(struct sk_buff *skb, struct net_device *dev,
 	spin_unlock_irqrestore(&priv->lock, flags);
 }
 
-static int ipoib_start_xmit(struct sk_buff *skb, struct net_device *dev)
+static netdev_tx_t ipoib_start_xmit(struct sk_buff *skb, struct net_device *dev)
 {
 	struct ipoib_dev_priv *priv = ipoib_priv(dev);
 	struct rdma_netdev *rn = netdev_priv(dev);
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] IB/ipoib: fix ipoib_start_xmit()'s return type
  2018-04-24 13:15 [PATCH] IB/ipoib: fix ipoib_start_xmit()'s return type Luc Van Oostenryck
@ 2018-04-24 13:32 ` Yuval Shaia
  2018-04-25 15:35 ` Leon Romanovsky
  1 sibling, 0 replies; 4+ messages in thread
From: Yuval Shaia @ 2018-04-24 13:32 UTC (permalink / raw)
  To: Luc Van Oostenryck
  Cc: linux-kernel, Doug Ledford, Jason Gunthorpe, Leon Romanovsky,
	Alex Vesker, Erez Shitrit, Dasaratharaman Chandramouli,
	Feras Daoud, linux-rdma

On Tue, Apr 24, 2018 at 03:15:47PM +0200, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
> 
> Fix this by returning 'netdev_tx_t' in this driver too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>

> ---
>  drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index 161ba8c76..cf291f90b 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -1094,7 +1094,7 @@ static void unicast_arp_send(struct sk_buff *skb, struct net_device *dev,
>  	spin_unlock_irqrestore(&priv->lock, flags);
>  }
>  
> -static int ipoib_start_xmit(struct sk_buff *skb, struct net_device *dev)
> +static netdev_tx_t ipoib_start_xmit(struct sk_buff *skb, struct net_device *dev)
>  {
>  	struct ipoib_dev_priv *priv = ipoib_priv(dev);
>  	struct rdma_netdev *rn = netdev_priv(dev);
> -- 
> 2.17.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] IB/ipoib: fix ipoib_start_xmit()'s return type
  2018-04-24 13:15 [PATCH] IB/ipoib: fix ipoib_start_xmit()'s return type Luc Van Oostenryck
  2018-04-24 13:32 ` Yuval Shaia
@ 2018-04-25 15:35 ` Leon Romanovsky
  2018-04-27 18:08   ` Doug Ledford
  1 sibling, 1 reply; 4+ messages in thread
From: Leon Romanovsky @ 2018-04-25 15:35 UTC (permalink / raw)
  To: Luc Van Oostenryck
  Cc: linux-kernel, Doug Ledford, Jason Gunthorpe, Alex Vesker,
	Yuval Shaia, Erez Shitrit, Dasaratharaman Chandramouli,
	Feras Daoud, linux-rdma

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

On Tue, Apr 24, 2018 at 03:15:47PM +0200, Luc Van Oostenryck wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
>  drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] IB/ipoib: fix ipoib_start_xmit()'s return type
  2018-04-25 15:35 ` Leon Romanovsky
@ 2018-04-27 18:08   ` Doug Ledford
  0 siblings, 0 replies; 4+ messages in thread
From: Doug Ledford @ 2018-04-27 18:08 UTC (permalink / raw)
  To: Leon Romanovsky, Luc Van Oostenryck
  Cc: linux-kernel, Jason Gunthorpe, Alex Vesker, Yuval Shaia,
	Erez Shitrit, Dasaratharaman Chandramouli, Feras Daoud,
	linux-rdma

[-- Attachment #1: Type: text/plain, Size: 819 bytes --]

On Wed, 2018-04-25 at 18:35 +0300, Leon Romanovsky wrote:
> On Tue, Apr 24, 2018 at 03:15:47PM +0200, Luc Van Oostenryck wrote:
> > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> > which is a typedef for an enum type, but the implementation in this
> > driver returns an 'int'.
> > 
> > Fix this by returning 'netdev_tx_t' in this driver too.
> > 
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > ---
> >  drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> 
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Thanks, applied to for-rc.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-04-27 18:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:15 [PATCH] IB/ipoib: fix ipoib_start_xmit()'s return type Luc Van Oostenryck
2018-04-24 13:32 ` Yuval Shaia
2018-04-25 15:35 ` Leon Romanovsky
2018-04-27 18:08   ` Doug Ledford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).