LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] IB/rxe: add RXE_START_MASK for rxe_opcode IB_OPCODE_RC_SEND_ONLY_INV
@ 2018-04-26  3:52 Jianchao Wang
  2018-04-26  4:02 ` Yanjun Zhu
  0 siblings, 1 reply; 3+ messages in thread
From: Jianchao Wang @ 2018-04-26  3:52 UTC (permalink / raw)
  To: monis, dledford, jgg; +Cc: linux-rdma, linux-kernel

w/o RXE_START_MASK, the last_psn of IB_OPCODE_RC_SEND_ONLY_INV
will not be updated in update_wqe_psn, and the corresponding
wqe will not be acked in rxe_completer due to its last_psn is
zero. Finally, the other wqe will also not be able to be acked,
because the wqe of IB_OPCODE_RC_SEND_ONLY_INV with last_psn 0
is still there. This causes large amount of io timeout when
nvmeof is over rxe.

Add RXE_START_MASK for IB_OPCODE_RC_SEND_ONLY_INV to fix this.

Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
---
 drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
index 61927c1..4cf1106 100644
--- a/drivers/infiniband/sw/rxe/rxe_opcode.c
+++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
@@ -390,7 +390,7 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
 		.name	= "IB_OPCODE_RC_SEND_ONLY_INV",
 		.mask	= RXE_IETH_MASK | RXE_PAYLOAD_MASK | RXE_REQ_MASK
 				| RXE_COMP_MASK | RXE_RWR_MASK | RXE_SEND_MASK
-				| RXE_END_MASK,
+				| RXE_END_MASK  | RXE_START_MASK,
 		.length = RXE_BTH_BYTES + RXE_IETH_BYTES,
 		.offset = {
 			[RXE_BTH]	= 0,
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] IB/rxe: add RXE_START_MASK for rxe_opcode IB_OPCODE_RC_SEND_ONLY_INV
  2018-04-26  3:52 [PATCH] IB/rxe: add RXE_START_MASK for rxe_opcode IB_OPCODE_RC_SEND_ONLY_INV Jianchao Wang
@ 2018-04-26  4:02 ` Yanjun Zhu
  2018-04-27 18:23   ` Doug Ledford
  0 siblings, 1 reply; 3+ messages in thread
From: Yanjun Zhu @ 2018-04-26  4:02 UTC (permalink / raw)
  To: Jianchao Wang, monis, dledford, jgg; +Cc: linux-rdma, linux-kernel



On 2018/4/26 11:52, Jianchao Wang wrote:
> w/o RXE_START_MASK, the last_psn of IB_OPCODE_RC_SEND_ONLY_INV
> will not be updated in update_wqe_psn, and the corresponding
> wqe will not be acked in rxe_completer due to its last_psn is
> zero. Finally, the other wqe will also not be able to be acked,
> because the wqe of IB_OPCODE_RC_SEND_ONLY_INV with last_psn 0
> is still there. This causes large amount of io timeout when
> nvmeof is over rxe.
>
> Add RXE_START_MASK for IB_OPCODE_RC_SEND_ONLY_INV to fix this.
>
> Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>

Reviewed-by: Zhu Yanjun <yanjun.zhu@oracle.com>

> ---
>   drivers/infiniband/sw/rxe/rxe_opcode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
> index 61927c1..4cf1106 100644
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -390,7 +390,7 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>   		.name	= "IB_OPCODE_RC_SEND_ONLY_INV",
>   		.mask	= RXE_IETH_MASK | RXE_PAYLOAD_MASK | RXE_REQ_MASK
>   				| RXE_COMP_MASK | RXE_RWR_MASK | RXE_SEND_MASK
> -				| RXE_END_MASK,
> +				| RXE_END_MASK  | RXE_START_MASK,
>   		.length = RXE_BTH_BYTES + RXE_IETH_BYTES,
>   		.offset = {
>   			[RXE_BTH]	= 0,

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] IB/rxe: add RXE_START_MASK for rxe_opcode IB_OPCODE_RC_SEND_ONLY_INV
  2018-04-26  4:02 ` Yanjun Zhu
@ 2018-04-27 18:23   ` Doug Ledford
  0 siblings, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2018-04-27 18:23 UTC (permalink / raw)
  To: Yanjun Zhu, Jianchao Wang, monis, jgg; +Cc: linux-rdma, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On Thu, 2018-04-26 at 12:02 +0800, Yanjun Zhu wrote:
> On 2018/4/26 11:52, Jianchao Wang wrote:
> > w/o RXE_START_MASK, the last_psn of IB_OPCODE_RC_SEND_ONLY_INV
> > will not be updated in update_wqe_psn, and the corresponding
> > wqe will not be acked in rxe_completer due to its last_psn is
> > zero. Finally, the other wqe will also not be able to be acked,
> > because the wqe of IB_OPCODE_RC_SEND_ONLY_INV with last_psn 0
> > is still there. This causes large amount of io timeout when
> > nvmeof is over rxe.
> > 
> > Add RXE_START_MASK for IB_OPCODE_RC_SEND_ONLY_INV to fix this.
> > 
> > Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
> 
> Reviewed-by: Zhu Yanjun <yanjun.zhu@oracle.com>

Thanks, applied to for-rc.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-27 18:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26  3:52 [PATCH] IB/rxe: add RXE_START_MASK for rxe_opcode IB_OPCODE_RC_SEND_ONLY_INV Jianchao Wang
2018-04-26  4:02 ` Yanjun Zhu
2018-04-27 18:23   ` Doug Ledford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).