LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH V2 01/10] ASoC: amd: dma config parameters changes
@ 2018-05-01 20:49 Vijendar Mukunda
  2018-05-01 20:49 ` [PATCH V2 02/10] ASoC: amd: added byte count register offset variables to rtd Vijendar Mukunda
                   ` (10 more replies)
  0 siblings, 11 replies; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-01 20:49 UTC (permalink / raw)
  Cc: Vijendar Mukunda, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Alex Deucher, Jason Clinton, Akshu Agrawal,
	Guenter Roeck, Kuninori Morimoto, Philippe Ombredanne,
	Kate Stewart, Greg Kroah-Hartman,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

Added dma configuration parameters to rtd structure.
Moved dma configuration parameters initialization to
hw_params callback.
Removed hard coding in prepare and trigger callbacks.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
v1->v2 : Fixed capture stream wrong channel assignment
	 added comments in dma trigger api
 sound/soc/amd/acp-pcm-dma.c | 103 ++++++++++++++++++--------------------------
 sound/soc/amd/acp.h         |   5 +++
 2 files changed, 48 insertions(+), 60 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index 9c026c4..e9736fe 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -321,19 +321,12 @@ static void config_acp_dma(void __iomem *acp_mmio,
 			   u32 asic_type)
 {
 	u32 pte_offset, sram_bank;
-	u16 ch1, ch2, destination, dma_dscr_idx;
 
 	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK) {
 		pte_offset = ACP_PLAYBACK_PTE_OFFSET;
-		ch1 = SYSRAM_TO_ACP_CH_NUM;
-		ch2 = ACP_TO_I2S_DMA_CH_NUM;
 		sram_bank = ACP_SHARED_RAM_BANK_1_ADDRESS;
-		destination = TO_ACP_I2S_1;
-
 	} else {
 		pte_offset = ACP_CAPTURE_PTE_OFFSET;
-		ch1 = SYSRAM_TO_ACP_CH_NUM;
-		ch2 = ACP_TO_I2S_DMA_CH_NUM;
 		switch (asic_type) {
 		case CHIP_STONEY:
 			sram_bank = ACP_SHARED_RAM_BANK_3_ADDRESS;
@@ -341,30 +334,19 @@ static void config_acp_dma(void __iomem *acp_mmio,
 		default:
 			sram_bank = ACP_SHARED_RAM_BANK_5_ADDRESS;
 		}
-		destination = FROM_ACP_I2S_1;
 	}
-
 	acp_pte_config(acp_mmio, rtd->pg, rtd->num_of_pages,
 		       pte_offset);
-	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK)
-		dma_dscr_idx = PLAYBACK_START_DMA_DESCR_CH12;
-	else
-		dma_dscr_idx = CAPTURE_START_DMA_DESCR_CH14;
-
 	/* Configure System memory <-> ACP SRAM DMA descriptors */
 	set_acp_sysmem_dma_descriptors(acp_mmio, rtd->size,
-				       rtd->direction, pte_offset, ch1,
-				       sram_bank, dma_dscr_idx, asic_type);
-
-	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK)
-		dma_dscr_idx = PLAYBACK_START_DMA_DESCR_CH13;
-	else
-		dma_dscr_idx = CAPTURE_START_DMA_DESCR_CH15;
+				       rtd->direction, pte_offset,
+				       rtd->ch1, sram_bank,
+				       rtd->dma_dscr_idx_1, asic_type);
 	/* Configure ACP SRAM <-> I2S DMA descriptors */
 	set_acp_to_i2s_dma_descriptors(acp_mmio, rtd->size,
 				       rtd->direction, sram_bank,
-				       destination, ch2, dma_dscr_idx,
-				       asic_type);
+				       rtd->destination, rtd->ch2,
+				       rtd->dma_dscr_idx_2, asic_type);
 }
 
 /* Start a given DMA channel transfer */
@@ -804,6 +786,21 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 		acp_reg_write(val, adata->acp_mmio,
 			      mmACP_I2S_16BIT_RESOLUTION_EN);
 	}
+
+	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+		rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
+		rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
+		rtd->destination = TO_ACP_I2S_1;
+		rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
+		rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
+	} else {
+		rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
+		rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
+		rtd->destination = FROM_ACP_I2S_1;
+		rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14;
+		rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15;
+	}
+
 	size = params_buffer_bytes(params);
 	status = snd_pcm_lib_malloc_pages(substream, size);
 	if (status < 0)
@@ -898,21 +895,15 @@ static int acp_dma_prepare(struct snd_pcm_substream *substream)
 
 	if (!rtd)
 		return -EINVAL;
-	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		config_acp_dma_channel(rtd->acp_mmio, SYSRAM_TO_ACP_CH_NUM,
-				       PLAYBACK_START_DMA_DESCR_CH12,
-				       NUM_DSCRS_PER_CHANNEL, 0);
-		config_acp_dma_channel(rtd->acp_mmio, ACP_TO_I2S_DMA_CH_NUM,
-				       PLAYBACK_START_DMA_DESCR_CH13,
-				       NUM_DSCRS_PER_CHANNEL, 0);
-	} else {
-		config_acp_dma_channel(rtd->acp_mmio, ACP_TO_SYSRAM_CH_NUM,
-				       CAPTURE_START_DMA_DESCR_CH14,
-				       NUM_DSCRS_PER_CHANNEL, 0);
-		config_acp_dma_channel(rtd->acp_mmio, I2S_TO_ACP_DMA_CH_NUM,
-				       CAPTURE_START_DMA_DESCR_CH15,
-				       NUM_DSCRS_PER_CHANNEL, 0);
-	}
+
+	config_acp_dma_channel(rtd->acp_mmio,
+			       rtd->ch1,
+			       rtd->dma_dscr_idx_1,
+			       NUM_DSCRS_PER_CHANNEL, 0);
+	config_acp_dma_channel(rtd->acp_mmio,
+			       rtd->ch2,
+			       rtd->dma_dscr_idx_2,
+			       NUM_DSCRS_PER_CHANNEL, 0);
 	return 0;
 }
 
@@ -939,10 +930,9 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 			if (rtd->i2ssp_renderbytescount == 0)
 				rtd->i2ssp_renderbytescount = bytescount;
-			acp_dma_start(rtd->acp_mmio,
-				      SYSRAM_TO_ACP_CH_NUM, false);
+			acp_dma_start(rtd->acp_mmio, rtd->ch1, false);
 			while (acp_reg_read(rtd->acp_mmio, mmACP_DMA_CH_STS) &
-						BIT(SYSRAM_TO_ACP_CH_NUM)) {
+				BIT(rtd->ch1)) {
 				if (!loops--) {
 					dev_err(component->dev,
 						"acp dma start timeout\n");
@@ -950,38 +940,31 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 				}
 				cpu_relax();
 			}
-
-			acp_dma_start(rtd->acp_mmio,
-				      ACP_TO_I2S_DMA_CH_NUM, true);
-
 		} else {
 			if (rtd->i2ssp_capturebytescount == 0)
 				rtd->i2ssp_capturebytescount = bytescount;
-			acp_dma_start(rtd->acp_mmio,
-				      I2S_TO_ACP_DMA_CH_NUM, true);
 		}
+		acp_dma_start(rtd->acp_mmio, rtd->ch2, true);
 		ret = 0;
 		break;
 	case SNDRV_PCM_TRIGGER_STOP:
 	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
 	case SNDRV_PCM_TRIGGER_SUSPEND:
-		/*
-		 * Need to stop only circular DMA channels :
-		 * ACP_TO_I2S_DMA_CH_NUM / I2S_TO_ACP_DMA_CH_NUM. Non-circular
-		 * channels will stopped automatically after its transfer
-		 * completes : SYSRAM_TO_ACP_CH_NUM / ACP_TO_SYSRAM_CH_NUM
+		/* For playback, non circular dma should be stopped first
+		 * i.e Sysram to acp dma transfer channel(rtd->ch1) should be
+		 * stopped before stopping cirular dma which is acp sram to i2s
+		 * fifo dma transfer channel(rtd->ch2). Where as in Capture
+		 * scenario, i2s fifo to acp sram dma channel(rtd->ch2) stopped
+		 * first before stopping acp sram to sysram which is circular
+		 * dma(rtd->ch1).
 		 */
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-			ret = acp_dma_stop(rtd->acp_mmio,
-					   SYSRAM_TO_ACP_CH_NUM);
-			ret = acp_dma_stop(rtd->acp_mmio,
-					   ACP_TO_I2S_DMA_CH_NUM);
+			acp_dma_stop(rtd->acp_mmio, rtd->ch1);
+			ret =  acp_dma_stop(rtd->acp_mmio, rtd->ch2);
 			rtd->i2ssp_renderbytescount = 0;
 		} else {
-			ret = acp_dma_stop(rtd->acp_mmio,
-					   I2S_TO_ACP_DMA_CH_NUM);
-			ret = acp_dma_stop(rtd->acp_mmio,
-					   ACP_TO_SYSRAM_CH_NUM);
+			acp_dma_stop(rtd->acp_mmio, rtd->ch2);
+			ret = acp_dma_stop(rtd->acp_mmio, rtd->ch1);
 			rtd->i2ssp_capturebytescount = 0;
 		}
 		break;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 0e6089b..5e25428 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -85,6 +85,11 @@ struct audio_substream_data {
 	unsigned int order;
 	u16 num_of_pages;
 	u16 direction;
+	u16 ch1;
+	u16 ch2;
+	u16 destination;
+	u16 dma_dscr_idx_1;
+	u16 dma_dscr_idx_2;
 	uint64_t size;
 	u64 i2ssp_renderbytescount;
 	u64 i2ssp_capturebytescount;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH V2 02/10] ASoC: amd: added byte count register offset variables to rtd
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
@ 2018-05-01 20:49 ` Vijendar Mukunda
  2018-05-11  3:20   ` Applied "ASoC: amd: added byte count register offset variables to rtd" to the asoc tree Mark Brown
  2018-05-01 20:49 ` [PATCH V2 03/10] ASoC: amd: removed separate byte count variables for playback and capture Vijendar Mukunda
                   ` (9 subsequent siblings)
  10 siblings, 1 reply; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-01 20:49 UTC (permalink / raw)
  Cc: Vijendar Mukunda, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Alex Deucher, Jason Clinton, Akshu Agrawal,
	Guenter Roeck, Kuninori Morimoto, Kate Stewart,
	Greg Kroah-Hartman,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

Added byte count register offset variables to audio_substream_data
structure. Modified dma pointer callback.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
---
v1->v2: Fixed Indentation issues
 sound/soc/amd/acp-pcm-dma.c | 36 +++++++++++++++---------------------
 sound/soc/amd/acp.h         |  2 ++
 2 files changed, 17 insertions(+), 21 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index e9736fe..6e338fe 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -793,12 +793,18 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 		rtd->destination = TO_ACP_I2S_1;
 		rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
 		rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
+		rtd->byte_cnt_high_reg_offset =
+				mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
+		rtd->byte_cnt_low_reg_offset = mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
 	} else {
 		rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
 		rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
 		rtd->destination = FROM_ACP_I2S_1;
 		rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14;
 		rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15;
+		rtd->byte_cnt_high_reg_offset =
+				mmACP_I2S_RECEIVED_BYTE_CNT_HIGH;
+		rtd->byte_cnt_low_reg_offset = mmACP_I2S_RECEIVED_BYTE_CNT_LOW;
 	}
 
 	size = params_buffer_bytes(params);
@@ -834,26 +840,15 @@ static int acp_dma_hw_free(struct snd_pcm_substream *substream)
 	return snd_pcm_lib_free_pages(substream);
 }
 
-static u64 acp_get_byte_count(void __iomem *acp_mmio, int stream)
+static u64 acp_get_byte_count(struct audio_substream_data *rtd)
 {
-	union acp_dma_count playback_dma_count;
-	union acp_dma_count capture_dma_count;
-	u64 bytescount = 0;
+	union acp_dma_count byte_count;
 
-	if (stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		playback_dma_count.bcount.high = acp_reg_read(acp_mmio,
-					mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH);
-		playback_dma_count.bcount.low  = acp_reg_read(acp_mmio,
-					mmACP_I2S_TRANSMIT_BYTE_CNT_LOW);
-		bytescount = playback_dma_count.bytescount;
-	} else {
-		capture_dma_count.bcount.high = acp_reg_read(acp_mmio,
-					mmACP_I2S_RECEIVED_BYTE_CNT_HIGH);
-		capture_dma_count.bcount.low  = acp_reg_read(acp_mmio,
-					mmACP_I2S_RECEIVED_BYTE_CNT_LOW);
-		bytescount = capture_dma_count.bytescount;
-	}
-	return bytescount;
+	byte_count.bcount.high = acp_reg_read(rtd->acp_mmio,
+					      rtd->byte_cnt_high_reg_offset);
+	byte_count.bcount.low  = acp_reg_read(rtd->acp_mmio,
+					      rtd->byte_cnt_low_reg_offset);
+	return byte_count.bytescount;
 }
 
 static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream)
@@ -869,7 +864,7 @@ static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream)
 		return -EINVAL;
 
 	buffersize = frames_to_bytes(runtime, runtime->buffer_size);
-	bytescount = acp_get_byte_count(rtd->acp_mmio, substream->stream);
+	bytescount = acp_get_byte_count(rtd);
 
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 		if (bytescount > rtd->i2ssp_renderbytescount)
@@ -925,8 +920,7 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 	case SNDRV_PCM_TRIGGER_START:
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
 	case SNDRV_PCM_TRIGGER_RESUME:
-		bytescount = acp_get_byte_count(rtd->acp_mmio,
-						substream->stream);
+		bytescount = acp_get_byte_count(rtd);
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 			if (rtd->i2ssp_renderbytescount == 0)
 				rtd->i2ssp_renderbytescount = bytescount;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 5e25428..3b076c6 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -90,6 +90,8 @@ struct audio_substream_data {
 	u16 destination;
 	u16 dma_dscr_idx_1;
 	u16 dma_dscr_idx_2;
+	u32 byte_cnt_high_reg_offset;
+	u32 byte_cnt_low_reg_offset;
 	uint64_t size;
 	u64 i2ssp_renderbytescount;
 	u64 i2ssp_capturebytescount;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH V2 03/10] ASoC: amd: removed separate byte count variables for playback and capture
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
  2018-05-01 20:49 ` [PATCH V2 02/10] ASoC: amd: added byte count register offset variables to rtd Vijendar Mukunda
@ 2018-05-01 20:49 ` Vijendar Mukunda
  2018-05-11  3:19   ` Applied "ASoC: amd: removed separate byte count variables for playback and capture" to the asoc tree Mark Brown
  2018-05-01 20:49 ` [PATCH V2 04/10] ASoC: amd: pte offset related dma driver changes Vijendar Mukunda
                   ` (8 subsequent siblings)
  10 siblings, 1 reply; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-01 20:49 UTC (permalink / raw)
  Cc: Vijendar Mukunda, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Alex Deucher, Jason Clinton, Akshu Agrawal,
	Guenter Roeck, Kuninori Morimoto, Thomas Gleixner,
	Philippe Ombredanne, Greg Kroah-Hartman,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

Removed separate byte count variables for playback and capture.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
---
v1->v2: Fixed review comment in acp_dma_pointer callback
 sound/soc/amd/acp-pcm-dma.c | 19 +++++--------------
 sound/soc/amd/acp.h         |  3 +--
 2 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index 6e338fe..862c1cf 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -866,13 +866,8 @@ static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream)
 	buffersize = frames_to_bytes(runtime, runtime->buffer_size);
 	bytescount = acp_get_byte_count(rtd);
 
-	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		if (bytescount > rtd->i2ssp_renderbytescount)
-			bytescount = bytescount - rtd->i2ssp_renderbytescount;
-	} else {
-		if (bytescount > rtd->i2ssp_capturebytescount)
-			bytescount = bytescount - rtd->i2ssp_capturebytescount;
-	}
+	if (bytescount > rtd->bytescount)
+		bytescount -= rtd->bytescount;
 	pos = do_div(bytescount, buffersize);
 	return bytes_to_frames(runtime, pos);
 }
@@ -921,9 +916,9 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
 	case SNDRV_PCM_TRIGGER_RESUME:
 		bytescount = acp_get_byte_count(rtd);
+		if (rtd->bytescount == 0)
+			rtd->bytescount = bytescount;
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-			if (rtd->i2ssp_renderbytescount == 0)
-				rtd->i2ssp_renderbytescount = bytescount;
 			acp_dma_start(rtd->acp_mmio, rtd->ch1, false);
 			while (acp_reg_read(rtd->acp_mmio, mmACP_DMA_CH_STS) &
 				BIT(rtd->ch1)) {
@@ -934,9 +929,6 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 				}
 				cpu_relax();
 			}
-		} else {
-			if (rtd->i2ssp_capturebytescount == 0)
-				rtd->i2ssp_capturebytescount = bytescount;
 		}
 		acp_dma_start(rtd->acp_mmio, rtd->ch2, true);
 		ret = 0;
@@ -955,12 +947,11 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 			acp_dma_stop(rtd->acp_mmio, rtd->ch1);
 			ret =  acp_dma_stop(rtd->acp_mmio, rtd->ch2);
-			rtd->i2ssp_renderbytescount = 0;
 		} else {
 			acp_dma_stop(rtd->acp_mmio, rtd->ch2);
 			ret = acp_dma_stop(rtd->acp_mmio, rtd->ch1);
-			rtd->i2ssp_capturebytescount = 0;
 		}
+		rtd->bytescount = 0;
 		break;
 	default:
 		ret = -EINVAL;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 3b076c6..82470bc 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -93,8 +93,7 @@ struct audio_substream_data {
 	u32 byte_cnt_high_reg_offset;
 	u32 byte_cnt_low_reg_offset;
 	uint64_t size;
-	u64 i2ssp_renderbytescount;
-	u64 i2ssp_capturebytescount;
+	u64 bytescount;
 	void __iomem *acp_mmio;
 };
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH V2 04/10] ASoC: amd: pte offset related dma driver changes
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
  2018-05-01 20:49 ` [PATCH V2 02/10] ASoC: amd: added byte count register offset variables to rtd Vijendar Mukunda
  2018-05-01 20:49 ` [PATCH V2 03/10] ASoC: amd: removed separate byte count variables for playback and capture Vijendar Mukunda
@ 2018-05-01 20:49 ` Vijendar Mukunda
  2018-05-21 15:48   ` Applied "ASoC: amd: pte offset related dma driver changes" to the asoc tree Mark Brown
  2018-05-01 20:49 ` [PATCH 05/10] ASoC: amd: sram bank update changes Vijendar Mukunda
                   ` (7 subsequent siblings)
  10 siblings, 1 reply; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-01 20:49 UTC (permalink / raw)
  Cc: Vijendar Mukunda, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Alex Deucher, Akshu Agrawal, Jason Clinton,
	Guenter Roeck, Kuninori Morimoto, Philippe Ombredanne,
	Greg Kroah-Hartman,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

Added pte offset variable in audio_substream_data structure.
Added Stoney related PTE offset macros in acp header file.
Modified hw_params callback to assign the pte offset value
based on asic_type.
PTE Offset macros used to calculate no of PTE entries
need to be programmed when memory allocated for audio buffer.
Depending upon allocated audio buffer size, PTE offset values
will change.
Compared to CZ, Stoney has SRAM memory limitation i.e 48k
It is required to define separate PTE Offset macros for
Stoney.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
v1->v2: Modified commit message
 sound/soc/amd/acp-pcm-dma.c | 26 +++++++++++++++++++-------
 sound/soc/amd/acp.h         |  5 +++++
 2 files changed, 24 insertions(+), 7 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index 862c1cf..39597fb 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -320,13 +320,11 @@ static void config_acp_dma(void __iomem *acp_mmio,
 			   struct audio_substream_data *rtd,
 			   u32 asic_type)
 {
-	u32 pte_offset, sram_bank;
+	u32 sram_bank;
 
-	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK) {
-		pte_offset = ACP_PLAYBACK_PTE_OFFSET;
+	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK)
 		sram_bank = ACP_SHARED_RAM_BANK_1_ADDRESS;
-	} else {
-		pte_offset = ACP_CAPTURE_PTE_OFFSET;
+	else {
 		switch (asic_type) {
 		case CHIP_STONEY:
 			sram_bank = ACP_SHARED_RAM_BANK_3_ADDRESS;
@@ -336,10 +334,10 @@ static void config_acp_dma(void __iomem *acp_mmio,
 		}
 	}
 	acp_pte_config(acp_mmio, rtd->pg, rtd->num_of_pages,
-		       pte_offset);
+		       rtd->pte_offset);
 	/* Configure System memory <-> ACP SRAM DMA descriptors */
 	set_acp_sysmem_dma_descriptors(acp_mmio, rtd->size,
-				       rtd->direction, pte_offset,
+				       rtd->direction, rtd->pte_offset,
 				       rtd->ch1, sram_bank,
 				       rtd->dma_dscr_idx_1, asic_type);
 	/* Configure ACP SRAM <-> I2S DMA descriptors */
@@ -788,6 +786,13 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 	}
 
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+		switch (adata->asic_type) {
+		case CHIP_STONEY:
+			rtd->pte_offset = ACP_ST_PLAYBACK_PTE_OFFSET;
+			break;
+		default:
+			rtd->pte_offset = ACP_PLAYBACK_PTE_OFFSET;
+		}
 		rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
 		rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
 		rtd->destination = TO_ACP_I2S_1;
@@ -797,6 +802,13 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 				mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
 		rtd->byte_cnt_low_reg_offset = mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
 	} else {
+		switch (adata->asic_type) {
+		case CHIP_STONEY:
+			rtd->pte_offset = ACP_ST_CAPTURE_PTE_OFFSET;
+			break;
+		default:
+			rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET;
+		}
 		rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
 		rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
 		rtd->destination = FROM_ACP_I2S_1;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 82470bc..2f48d1d 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -10,6 +10,10 @@
 #define ACP_PLAYBACK_PTE_OFFSET			10
 #define ACP_CAPTURE_PTE_OFFSET			0
 
+/* Playback and Capture Offset for Stoney */
+#define ACP_ST_PLAYBACK_PTE_OFFSET	0x04
+#define ACP_ST_CAPTURE_PTE_OFFSET	0x00
+
 #define ACP_GARLIC_CNTL_DEFAULT			0x00000FB4
 #define ACP_ONION_CNTL_DEFAULT			0x00000FB4
 
@@ -90,6 +94,7 @@ struct audio_substream_data {
 	u16 destination;
 	u16 dma_dscr_idx_1;
 	u16 dma_dscr_idx_2;
+	u32 pte_offset;
 	u32 byte_cnt_high_reg_offset;
 	u32 byte_cnt_low_reg_offset;
 	uint64_t size;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 05/10] ASoC: amd: sram bank update changes
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
                   ` (2 preceding siblings ...)
  2018-05-01 20:49 ` [PATCH V2 04/10] ASoC: amd: pte offset related dma driver changes Vijendar Mukunda
@ 2018-05-01 20:49 ` Vijendar Mukunda
  2018-05-21 15:48   ` Applied "ASoC: amd: sram bank update changes" to the asoc tree Mark Brown
  2018-05-01 20:50 ` [PATCH 06/10] ASoC: amd: memory release for rtd structure Vijendar Mukunda
                   ` (6 subsequent siblings)
  10 siblings, 1 reply; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-01 20:49 UTC (permalink / raw)
  Cc: Vijendar Mukunda, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Alex Deucher, Jason Clinton, Akshu Agrawal,
	Guenter Roeck, Kuninori Morimoto, Philippe Ombredanne,
	Greg Kroah-Hartman,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

Added sram bank variable to audio_substream_data structure.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
 sound/soc/amd/acp-pcm-dma.c | 20 +++++---------------
 sound/soc/amd/acp.h         | 20 ++++++++++++++------
 2 files changed, 19 insertions(+), 21 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index 39597fb..8236116 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -320,29 +320,16 @@ static void config_acp_dma(void __iomem *acp_mmio,
 			   struct audio_substream_data *rtd,
 			   u32 asic_type)
 {
-	u32 sram_bank;
-
-	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK)
-		sram_bank = ACP_SHARED_RAM_BANK_1_ADDRESS;
-	else {
-		switch (asic_type) {
-		case CHIP_STONEY:
-			sram_bank = ACP_SHARED_RAM_BANK_3_ADDRESS;
-			break;
-		default:
-			sram_bank = ACP_SHARED_RAM_BANK_5_ADDRESS;
-		}
-	}
 	acp_pte_config(acp_mmio, rtd->pg, rtd->num_of_pages,
 		       rtd->pte_offset);
 	/* Configure System memory <-> ACP SRAM DMA descriptors */
 	set_acp_sysmem_dma_descriptors(acp_mmio, rtd->size,
 				       rtd->direction, rtd->pte_offset,
-				       rtd->ch1, sram_bank,
+				       rtd->ch1, rtd->sram_bank,
 				       rtd->dma_dscr_idx_1, asic_type);
 	/* Configure ACP SRAM <-> I2S DMA descriptors */
 	set_acp_to_i2s_dma_descriptors(acp_mmio, rtd->size,
-				       rtd->direction, sram_bank,
+				       rtd->direction, rtd->sram_bank,
 				       rtd->destination, rtd->ch2,
 				       rtd->dma_dscr_idx_2, asic_type);
 }
@@ -795,6 +782,7 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 		}
 		rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
 		rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
+		rtd->sram_bank = ACP_SRAM_BANK_1_ADDRESS;
 		rtd->destination = TO_ACP_I2S_1;
 		rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
 		rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
@@ -805,9 +793,11 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 		switch (adata->asic_type) {
 		case CHIP_STONEY:
 			rtd->pte_offset = ACP_ST_CAPTURE_PTE_OFFSET;
+			rtd->sram_bank = ACP_SRAM_BANK_2_ADDRESS;
 			break;
 		default:
 			rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET;
+			rtd->sram_bank = ACP_SRAM_BANK_5_ADDRESS;
 		}
 		rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
 		rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 2f48d1d..62695ed 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -19,12 +19,19 @@
 
 #define ACP_PHYSICAL_BASE			0x14000
 
-/* Playback SRAM address (as a destination in dma descriptor) */
-#define ACP_SHARED_RAM_BANK_1_ADDRESS		0x4002000
-
-/* Capture SRAM address (as a source in dma descriptor) */
-#define ACP_SHARED_RAM_BANK_5_ADDRESS		0x400A000
-#define ACP_SHARED_RAM_BANK_3_ADDRESS		0x4006000
+/*
+ * In case of I2S SP controller instance, Stoney uses SRAM bank 1 for
+ * playback and SRAM Bank 2 for capture where as in case of BT I2S
+ * Instance, Stoney uses SRAM Bank 3 for playback & SRAM Bank 4 will
+ * be used for capture. Carrizo uses I2S SP controller instance. SRAM Banks
+ * 1, 2, 3, 4 will be used for playback & SRAM Banks 5, 6, 7, 8 will be used
+ * for capture scenario.
+ */
+#define ACP_SRAM_BANK_1_ADDRESS		0x4002000
+#define ACP_SRAM_BANK_2_ADDRESS		0x4004000
+#define ACP_SRAM_BANK_3_ADDRESS		0x4006000
+#define ACP_SRAM_BANK_4_ADDRESS		0x4008000
+#define ACP_SRAM_BANK_5_ADDRESS		0x400A000
 
 #define ACP_DMA_RESET_TIME			10000
 #define ACP_CLOCK_EN_TIME_OUT_VALUE		0x000000FF
@@ -95,6 +102,7 @@ struct audio_substream_data {
 	u16 dma_dscr_idx_1;
 	u16 dma_dscr_idx_2;
 	u32 pte_offset;
+	u32 sram_bank;
 	u32 byte_cnt_high_reg_offset;
 	u32 byte_cnt_low_reg_offset;
 	uint64_t size;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 06/10] ASoC: amd: memory release for rtd structure
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
                   ` (3 preceding siblings ...)
  2018-05-01 20:49 ` [PATCH 05/10] ASoC: amd: sram bank update changes Vijendar Mukunda
@ 2018-05-01 20:50 ` Vijendar Mukunda
  2018-05-01 20:50 ` [PATCH 07/10] ASoC: AMD: Move clk enable from hw_params/free to startup/shutdown Vijendar Mukunda
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-01 20:50 UTC (permalink / raw)
  Cc: Vijendar Mukunda, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Alex Deucher, Akshu Agrawal, Jason Clinton,
	Guenter Roeck, Kuninori Morimoto,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

rtd structure freed early may result in kernel panic in dma close
call back. moved releasing memory for rtd structure to the end of
dma close callback.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
 sound/soc/amd/acp-pcm-dma.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index 8236116..ec9cab3 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -998,8 +998,6 @@ static int acp_dma_close(struct snd_pcm_substream *substream)
 								    DRV_NAME);
 	struct audio_drv_data *adata = dev_get_drvdata(component->dev);
 
-	kfree(rtd);
-
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 		adata->play_i2ssp_stream = NULL;
 		/*
@@ -1028,7 +1026,7 @@ static int acp_dma_close(struct snd_pcm_substream *substream)
 	 */
 	if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream)
 		acp_reg_write(0, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB);
-
+	kfree(rtd);
 	return 0;
 }
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 07/10] ASoC: AMD: Move clk enable from hw_params/free to startup/shutdown
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
                   ` (4 preceding siblings ...)
  2018-05-01 20:50 ` [PATCH 06/10] ASoC: amd: memory release for rtd structure Vijendar Mukunda
@ 2018-05-01 20:50 ` Vijendar Mukunda
  2018-05-01 20:50 ` [PATCH 08/10] ASoC: AMD: Fix clocks in CZ DA7219 machine driver Vijendar Mukunda
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-01 20:50 UTC (permalink / raw)
  Cc: Akshu Agrawal, Vijendar Mukunda, Liam Girdwood, Mark Brown,
	Jaroslav Kysela, Takashi Iwai, Agrawal, Akshu, Kuninori Morimoto,
	Alex Deucher, Daniel Kurtz, Wei Yongjun,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

From: Akshu Agrawal <akshu.agrawal@amd.com>

hw_param can be called multiple times and thus we can have
more clk enable. The clk may not get diabled due to refcounting.
startup/shutdown ensures single clk enable/disable call.

Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
 sound/soc/amd/acp-da7219-max98357a.c | 49 +++++++++++++++++++++++++-----------
 1 file changed, 35 insertions(+), 14 deletions(-)

diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c
index 215b06b..6495eed 100644
--- a/sound/soc/amd/acp-da7219-max98357a.c
+++ b/sound/soc/amd/acp-da7219-max98357a.c
@@ -91,8 +91,7 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)
 	return 0;
 }
 
-static int cz_da7219_hw_params(struct snd_pcm_substream *substream,
-			     struct snd_pcm_hw_params *params)
+static int da7219_clk_enable(struct snd_pcm_substream *substream)
 {
 	int ret = 0;
 	struct snd_soc_pcm_runtime *rtd = substream->private_data;
@@ -106,11 +105,9 @@ static int cz_da7219_hw_params(struct snd_pcm_substream *substream,
 	return ret;
 }
 
-static int cz_da7219_hw_free(struct snd_pcm_substream *substream)
+static void da7219_clk_disable(void)
 {
 	clk_disable_unprepare(da7219_dai_clk);
-
-	return 0;
 }
 
 static const unsigned int channels[] = {
@@ -133,7 +130,7 @@ static const struct snd_pcm_hw_constraint_list constraints_channels = {
 	.mask = 0,
 };
 
-static int cz_fe_startup(struct snd_pcm_substream *substream)
+static int cz_da7219_startup(struct snd_pcm_substream *substream)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
 
@@ -147,23 +144,47 @@ static int cz_fe_startup(struct snd_pcm_substream *substream)
 	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,
 				   &constraints_rates);
 
-	return 0;
+	return da7219_clk_enable(substream);
+}
+
+static void cz_da7219_shutdown(struct snd_pcm_substream *substream)
+{
+	da7219_clk_disable();
+}
+
+static int cz_max_startup(struct snd_pcm_substream *substream)
+{
+	return da7219_clk_enable(substream);
+}
+
+static void cz_max_shutdown(struct snd_pcm_substream *substream)
+{
+	da7219_clk_disable();
+}
+
+static int cz_dmic_startup(struct snd_pcm_substream *substream)
+{
+	return da7219_clk_enable(substream);
+}
+
+static void cz_dmic_shutdown(struct snd_pcm_substream *substream)
+{
+	da7219_clk_disable();
 }
 
 static struct snd_soc_ops cz_da7219_cap_ops = {
-	.hw_params = cz_da7219_hw_params,
-	.hw_free = cz_da7219_hw_free,
-	.startup = cz_fe_startup,
+	.startup = cz_da7219_startup,
+	.shutdown = cz_da7219_shutdown,
 };
 
 static struct snd_soc_ops cz_max_play_ops = {
-	.hw_params = cz_da7219_hw_params,
-	.hw_free = cz_da7219_hw_free,
+	.startup = cz_max_startup,
+	.shutdown = cz_max_shutdown,
 };
 
 static struct snd_soc_ops cz_dmic_cap_ops = {
-	.hw_params = cz_da7219_hw_params,
-	.hw_free = cz_da7219_hw_free,
+	.startup = cz_dmic_startup,
+	.shutdown = cz_dmic_shutdown,
 };
 
 static struct snd_soc_dai_link cz_dai_7219_98357[] = {
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 08/10] ASoC: AMD: Fix clocks in CZ DA7219 machine driver
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
                   ` (5 preceding siblings ...)
  2018-05-01 20:50 ` [PATCH 07/10] ASoC: AMD: Move clk enable from hw_params/free to startup/shutdown Vijendar Mukunda
@ 2018-05-01 20:50 ` Vijendar Mukunda
  2018-05-01 20:50 ` [PATCH 09/10] ASoC: AMD: Add const to snd_soc_ops instances Vijendar Mukunda
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-01 20:50 UTC (permalink / raw)
  Cc: Akshu Agrawal, Vijendar Mukunda, Liam Girdwood, Mark Brown,
	Jaroslav Kysela, Takashi Iwai, Agrawal, Akshu, Kuninori Morimoto,
	Alex Deucher, Daniel Kurtz, Wei Yongjun,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

From: Akshu Agrawal <akshu.agrawal@amd.com>

System clock on the platform is 25Mhz and not 24Mhz.

PLL_OUT for da7219 codec to use DA7219_PLL_FREQ_OUT_98304
as it is for 48KHz SR.

Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
---
 sound/soc/amd/acp-da7219-max98357a.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c
index 6495eed..fa5ad5b 100644
--- a/sound/soc/amd/acp-da7219-max98357a.c
+++ b/sound/soc/amd/acp-da7219-max98357a.c
@@ -39,8 +39,7 @@
 #include "../codecs/da7219.h"
 #include "../codecs/da7219-aad.h"
 
-#define CZ_PLAT_CLK 24000000
-#define MCLK_RATE 24576000
+#define CZ_PLAT_CLK 25000000
 #define DUAL_CHANNEL		2
 
 static struct snd_soc_jack cz_jack;
@@ -63,7 +62,7 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)
 	}
 
 	ret = snd_soc_dai_set_pll(codec_dai, 0, DA7219_SYSCLK_PLL,
-				  CZ_PLAT_CLK, MCLK_RATE);
+				  CZ_PLAT_CLK, DA7219_PLL_FREQ_OUT_98304);
 	if (ret < 0) {
 		dev_err(rtd->dev, "can't set codec pll: %d\n", ret);
 		return ret;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 09/10] ASoC: AMD: Add const to snd_soc_ops instances
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
                   ` (6 preceding siblings ...)
  2018-05-01 20:50 ` [PATCH 08/10] ASoC: AMD: Fix clocks in CZ DA7219 machine driver Vijendar Mukunda
@ 2018-05-01 20:50 ` Vijendar Mukunda
  2018-05-01 20:50 ` [PATCH V3 10/10] ASoC: amd: dma driver changes for bt i2s instance Vijendar Mukunda
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-01 20:50 UTC (permalink / raw)
  Cc: Akshu Agrawal, Vijendar Mukunda, Liam Girdwood, Mark Brown,
	Jaroslav Kysela, Takashi Iwai, Agrawal, Akshu, Alex Deucher,
	Kuninori Morimoto, Daniel Kurtz, Wei Yongjun,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

From: Akshu Agrawal <akshu.agrawal@amd.com>

Marking snd_soc_ops instances const

Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
---
 sound/soc/amd/acp-da7219-max98357a.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c
index fa5ad5b..133139d 100644
--- a/sound/soc/amd/acp-da7219-max98357a.c
+++ b/sound/soc/amd/acp-da7219-max98357a.c
@@ -171,17 +171,17 @@ static void cz_dmic_shutdown(struct snd_pcm_substream *substream)
 	da7219_clk_disable();
 }
 
-static struct snd_soc_ops cz_da7219_cap_ops = {
+static const struct snd_soc_ops cz_da7219_cap_ops = {
 	.startup = cz_da7219_startup,
 	.shutdown = cz_da7219_shutdown,
 };
 
-static struct snd_soc_ops cz_max_play_ops = {
+static const struct snd_soc_ops cz_max_play_ops = {
 	.startup = cz_max_startup,
 	.shutdown = cz_max_shutdown,
 };
 
-static struct snd_soc_ops cz_dmic_cap_ops = {
+static const struct snd_soc_ops cz_dmic_cap_ops = {
 	.startup = cz_dmic_startup,
 	.shutdown = cz_dmic_shutdown,
 };
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH V3 10/10] ASoC: amd: dma driver changes for bt i2s instance
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
                   ` (7 preceding siblings ...)
  2018-05-01 20:50 ` [PATCH 09/10] ASoC: AMD: Add const to snd_soc_ops instances Vijendar Mukunda
@ 2018-05-01 20:50 ` Vijendar Mukunda
  2018-05-03  5:43   ` Daniel Kurtz
  2018-05-07  6:27 ` [PATCH V2 01/10] ASoC: amd: dma config parameters changes Mukunda,Vijendar
  2018-05-11  3:20 ` Applied "ASoC: amd: dma config parameters changes" to the asoc tree Mark Brown
  10 siblings, 1 reply; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-01 20:50 UTC (permalink / raw)
  Cc: Vijendar Mukunda, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Agrawal, Akshu, Kuninori Morimoto, Alex Deucher,
	Daniel Kurtz, Wei Yongjun, Jason Clinton, Guenter Roeck,
	Greg Kroah-Hartman, Kate Stewart,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

With in ACP, There are three I2S controllers can be
configured/enabled ( I2S SP, I2S MICSP, I2S BT).
Default enabled I2S controller instance is I2S SP.
This patch provides required changes to support I2S BT
controller Instance.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
v1->v2: defined i2s instance macros in acp header file
v2->v3: sqaushed previous patch series and spilt changes
	into multiple patches (acp dma driver code cleanup
	patches and bt i2s instance specific changes)
 sound/soc/amd/acp-da7219-max98357a.c |  23 ++++
 sound/soc/amd/acp-pcm-dma.c          | 256 +++++++++++++++++++++++++++--------
 sound/soc/amd/acp.h                  |  40 ++++++
 3 files changed, 262 insertions(+), 57 deletions(-)

diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c
index 133139d..b3184ab 100644
--- a/sound/soc/amd/acp-da7219-max98357a.c
+++ b/sound/soc/amd/acp-da7219-max98357a.c
@@ -36,6 +36,7 @@
 #include <linux/input.h>
 #include <linux/acpi.h>
 
+#include "acp.h"
 #include "../codecs/da7219.h"
 #include "../codecs/da7219-aad.h"
 
@@ -44,6 +45,7 @@
 
 static struct snd_soc_jack cz_jack;
 static struct clk *da7219_dai_clk;
+extern int bt_pad_enable;
 
 static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)
 {
@@ -132,6 +134,9 @@ static const struct snd_pcm_hw_constraint_list constraints_channels = {
 static int cz_da7219_startup(struct snd_pcm_substream *substream)
 {
 	struct snd_pcm_runtime *runtime = substream->runtime;
+	struct snd_soc_pcm_runtime *rtd = substream->private_data;
+	struct snd_soc_card *card = rtd->card;
+	struct acp_platform_info *machine = snd_soc_card_get_drvdata(card);
 
 	/*
 	 * On this platform for PCM device we support stereo
@@ -143,6 +148,7 @@ static int cz_da7219_startup(struct snd_pcm_substream *substream)
 	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,
 				   &constraints_rates);
 
+	machine->i2s_instance = I2S_BT_INSTANCE;
 	return da7219_clk_enable(substream);
 }
 
@@ -153,6 +159,11 @@ static void cz_da7219_shutdown(struct snd_pcm_substream *substream)
 
 static int cz_max_startup(struct snd_pcm_substream *substream)
 {
+	struct snd_soc_pcm_runtime *rtd = substream->private_data;
+	struct snd_soc_card *card = rtd->card;
+	struct acp_platform_info *machine = snd_soc_card_get_drvdata(card);
+
+	machine->i2s_instance = I2S_SP_INSTANCE;
 	return da7219_clk_enable(substream);
 }
 
@@ -163,6 +174,11 @@ static void cz_max_shutdown(struct snd_pcm_substream *substream)
 
 static int cz_dmic_startup(struct snd_pcm_substream *substream)
 {
+	struct snd_soc_pcm_runtime *rtd = substream->private_data;
+	struct snd_soc_card *card = rtd->card;
+	struct acp_platform_info *machine = snd_soc_card_get_drvdata(card);
+
+	machine->i2s_instance = I2S_SP_INSTANCE;
 	return da7219_clk_enable(substream);
 }
 
@@ -266,10 +282,16 @@ static int cz_probe(struct platform_device *pdev)
 {
 	int ret;
 	struct snd_soc_card *card;
+	struct acp_platform_info *machine;
 
+	machine = devm_kzalloc(&pdev->dev, sizeof(struct acp_platform_info),
+			       GFP_KERNEL);
+	if (!machine)
+		return -ENOMEM;
 	card = &cz_card;
 	cz_card.dev = &pdev->dev;
 	platform_set_drvdata(pdev, card);
+	snd_soc_card_set_drvdata(card, machine);
 	ret = devm_snd_soc_register_card(&pdev->dev, &cz_card);
 	if (ret) {
 		dev_err(&pdev->dev,
@@ -277,6 +299,7 @@ static int cz_probe(struct platform_device *pdev)
 				cz_card.name, ret);
 		return ret;
 	}
+	bt_pad_enable = device_property_read_bool(&pdev->dev, "bt-pad-enable");
 	return 0;
 }
 
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index ec9cab3..2ea103a 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -37,12 +37,14 @@
 #define MAX_BUFFER (PLAYBACK_MAX_PERIOD_SIZE * PLAYBACK_MAX_NUM_PERIODS)
 #define MIN_BUFFER MAX_BUFFER
 
-#define ST_PLAYBACK_MAX_PERIOD_SIZE 8192
+#define ST_PLAYBACK_MAX_PERIOD_SIZE 4096
 #define ST_CAPTURE_MAX_PERIOD_SIZE  ST_PLAYBACK_MAX_PERIOD_SIZE
 #define ST_MAX_BUFFER (ST_PLAYBACK_MAX_PERIOD_SIZE * PLAYBACK_MAX_NUM_PERIODS)
 #define ST_MIN_BUFFER ST_MAX_BUFFER
 
 #define DRV_NAME "acp_audio_dma"
+bool bt_pad_enable = false;
+EXPORT_SYMBOL(bt_pad_enable);
 
 static const struct snd_pcm_hardware acp_pcm_hardware_playback = {
 	.info = SNDRV_PCM_INFO_INTERLEAVED |
@@ -357,6 +359,9 @@ static void acp_dma_start(void __iomem *acp_mmio,
 	case ACP_TO_I2S_DMA_CH_NUM:
 	case ACP_TO_SYSRAM_CH_NUM:
 	case I2S_TO_ACP_DMA_CH_NUM:
+	case ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM:
+	case ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM:
+	case I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM:
 		dma_ctrl |= ACP_DMA_CNTL_0__DMAChIOCEn_MASK;
 		break;
 	default:
@@ -519,6 +524,13 @@ static int acp_init(void __iomem *acp_mmio, u32 asic_type)
 	val &= ~ACP_SOFT_RESET__SoftResetAud_MASK;
 	acp_reg_write(val, acp_mmio, mmACP_SOFT_RESET);
 
+	/* For BT instance change pins from UART to BT */
+	if (bt_pad_enable) {
+		val = acp_reg_read(acp_mmio, mmACP_BT_UART_PAD_SEL);
+		val |= ACP_BT_UART_PAD_SELECT_MASK;
+		acp_reg_write(val, acp_mmio, mmACP_BT_UART_PAD_SEL);
+	}
+
 	/* initiailize Onion control DAGB register */
 	acp_reg_write(ACP_ONION_CNTL_DEFAULT, acp_mmio,
 		      mmACP_AXI2DAGB_ONION_CNTL);
@@ -637,6 +649,24 @@ static irqreturn_t dma_irq_handler(int irq, void *arg)
 			      acp_mmio, mmACP_EXTERNAL_INTR_STAT);
 	}
 
+	if ((intr_flag & BIT(ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM)) != 0) {
+		valid_irq = true;
+		if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_9) ==
+			PLAYBACK_START_DMA_DESCR_CH9)
+			dscr_idx = PLAYBACK_END_DMA_DESCR_CH8;
+		else
+			dscr_idx = PLAYBACK_START_DMA_DESCR_CH8;
+		config_acp_dma_channel(acp_mmio,
+				       SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM,
+				       dscr_idx, 1, 0);
+		acp_dma_start(acp_mmio, SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM,
+			      false);
+		snd_pcm_period_elapsed(irq_data->play_i2sbt_stream);
+		acp_reg_write((intr_flag &
+			      BIT(ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM)) << 16,
+			      acp_mmio, mmACP_EXTERNAL_INTR_STAT);
+	}
+
 	if ((intr_flag & BIT(I2S_TO_ACP_DMA_CH_NUM)) != 0) {
 		valid_irq = true;
 		if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_15) ==
@@ -659,6 +689,31 @@ static irqreturn_t dma_irq_handler(int irq, void *arg)
 			      acp_mmio, mmACP_EXTERNAL_INTR_STAT);
 	}
 
+	if ((intr_flag & BIT(I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM)) != 0) {
+		valid_irq = true;
+		if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_11) ==
+			CAPTURE_START_DMA_DESCR_CH11)
+			dscr_idx = CAPTURE_END_DMA_DESCR_CH10;
+		else
+			dscr_idx = CAPTURE_START_DMA_DESCR_CH10;
+		config_acp_dma_channel(acp_mmio,
+				       ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM,
+				       dscr_idx, 1, 0);
+		acp_dma_start(acp_mmio, ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM,
+			      false);
+		acp_reg_write((intr_flag &
+			      BIT(I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM)) << 16,
+			      acp_mmio, mmACP_EXTERNAL_INTR_STAT);
+	}
+
+	if ((intr_flag & BIT(ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM)) != 0) {
+		valid_irq = true;
+		snd_pcm_period_elapsed(irq_data->capture_i2sbt_stream);
+		acp_reg_write((intr_flag &
+			      BIT(ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM)) << 16,
+			      acp_mmio, mmACP_EXTERNAL_INTR_STAT);
+	}
+
 	if (valid_irq)
 		return IRQ_HANDLED;
 	else
@@ -714,11 +769,11 @@ static int acp_dma_open(struct snd_pcm_substream *substream)
 	 * This enablement is not required for another stream, if current
 	 * stream is not closed
 	 */
-	if (!intr_data->play_i2ssp_stream && !intr_data->capture_i2ssp_stream)
+	if (!intr_data->play_i2ssp_stream && !intr_data->capture_i2ssp_stream &&
+	    !intr_data->play_i2sbt_stream && !intr_data->capture_i2sbt_stream)
 		acp_reg_write(1, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB);
 
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		intr_data->play_i2ssp_stream = substream;
 		/*
 		 * For Stoney, Memory gating is disabled,i.e SRAM Banks
 		 * won't be turned off. The default state for SRAM banks is ON.
@@ -730,7 +785,6 @@ static int acp_dma_open(struct snd_pcm_substream *substream)
 							bank, true);
 		}
 	} else {
-		intr_data->capture_i2ssp_stream = substream;
 		if (intr_data->asic_type != CHIP_STONEY) {
 			for (bank = 5; bank <= 8; bank++)
 				acp_set_sram_bank_state(intr_data->acp_mmio,
@@ -754,6 +808,8 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 	struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd,
 								    DRV_NAME);
 	struct audio_drv_data *adata = dev_get_drvdata(component->dev);
+	struct snd_soc_card *card = prtd->card;
+	struct acp_platform_info *pinfo = snd_soc_card_get_drvdata(card);
 
 	runtime = substream->runtime;
 	rtd = runtime->private_data;
@@ -761,52 +817,109 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 	if (WARN_ON(!rtd))
 		return -EINVAL;
 
+	rtd->i2s_instance = pinfo->i2s_instance;
 	if (adata->asic_type == CHIP_STONEY) {
 		val = acp_reg_read(adata->acp_mmio,
 				   mmACP_I2S_16BIT_RESOLUTION_EN);
-		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
-			val |= ACP_I2S_SP_16BIT_RESOLUTION_EN;
-		else
-			val |= ACP_I2S_MIC_16BIT_RESOLUTION_EN;
+		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+			switch (rtd->i2s_instance) {
+			case I2S_BT_INSTANCE:
+				val |= ACP_I2S_BT_16BIT_RESOLUTION_EN;
+				break;
+			case I2S_SP_INSTANCE:
+			default:
+				val |= ACP_I2S_SP_16BIT_RESOLUTION_EN;
+			}
+		} else {
+			switch (rtd->i2s_instance) {
+			case I2S_BT_INSTANCE:
+				val |= ACP_I2S_BT_16BIT_RESOLUTION_EN;
+				break;
+			case I2S_SP_INSTANCE:
+			default:
+				val |= ACP_I2S_MIC_16BIT_RESOLUTION_EN;
+			}
+		}
 		acp_reg_write(val, adata->acp_mmio,
 			      mmACP_I2S_16BIT_RESOLUTION_EN);
 	}
 
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		switch (adata->asic_type) {
-		case CHIP_STONEY:
-			rtd->pte_offset = ACP_ST_PLAYBACK_PTE_OFFSET;
+		switch (rtd->i2s_instance) {
+		case I2S_BT_INSTANCE:
+			rtd->pte_offset = ACP_ST_BT_PLAYBACK_PTE_OFFSET;
+			rtd->ch1 = SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM;
+			rtd->ch2 = ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM;
+			rtd->sram_bank = ACP_SRAM_BANK_3_ADDRESS;
+			rtd->destination = TO_BLUETOOTH;
+			rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH8;
+			rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH9;
+			rtd->byte_cnt_high_reg_offset =
+					mmACP_I2S_BT_TRANSMIT_BYTE_CNT_HIGH;
+			rtd->byte_cnt_low_reg_offset =
+					mmACP_I2S_BT_TRANSMIT_BYTE_CNT_LOW;
+			adata->play_i2sbt_stream = substream;
 			break;
+		case I2S_SP_INSTANCE:
 		default:
-			rtd->pte_offset = ACP_PLAYBACK_PTE_OFFSET;
+			switch (adata->asic_type) {
+			case CHIP_STONEY:
+				rtd->pte_offset = ACP_ST_PLAYBACK_PTE_OFFSET;
+				break;
+			default:
+				rtd->pte_offset = ACP_PLAYBACK_PTE_OFFSET;
+			}
+			rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
+			rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
+			rtd->sram_bank = ACP_SRAM_BANK_1_ADDRESS;
+			rtd->destination = TO_ACP_I2S_1;
+			rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
+			rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
+			rtd->byte_cnt_high_reg_offset =
+					mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
+			rtd->byte_cnt_low_reg_offset =
+					mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
+			adata->play_i2ssp_stream = substream;
 		}
-		rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
-		rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
-		rtd->sram_bank = ACP_SRAM_BANK_1_ADDRESS;
-		rtd->destination = TO_ACP_I2S_1;
-		rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
-		rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
-		rtd->byte_cnt_high_reg_offset =
-				mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
-		rtd->byte_cnt_low_reg_offset = mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
 	} else {
-		switch (adata->asic_type) {
-		case CHIP_STONEY:
-			rtd->pte_offset = ACP_ST_CAPTURE_PTE_OFFSET;
-			rtd->sram_bank = ACP_SRAM_BANK_2_ADDRESS;
+		switch (rtd->i2s_instance) {
+		case I2S_BT_INSTANCE:
+			rtd->pte_offset = ACP_ST_BT_CAPTURE_PTE_OFFSET;
+			rtd->ch1 = ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM;
+			rtd->ch2 = I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM;
+			rtd->sram_bank = ACP_SRAM_BANK_4_ADDRESS;
+			rtd->destination = FROM_BLUETOOTH;
+			rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH10;
+			rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH11;
+			rtd->byte_cnt_high_reg_offset =
+					mmACP_I2S_BT_RECEIVE_BYTE_CNT_HIGH;
+			rtd->byte_cnt_low_reg_offset =
+					mmACP_I2S_BT_RECEIVE_BYTE_CNT_LOW;
+			adata->capture_i2sbt_stream = substream;
 			break;
+		case I2S_SP_INSTANCE:
 		default:
 			rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET;
-			rtd->sram_bank = ACP_SRAM_BANK_5_ADDRESS;
+			rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
+			rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
+			switch (adata->asic_type) {
+			case CHIP_STONEY:
+				rtd->pte_offset = ACP_ST_CAPTURE_PTE_OFFSET;
+				rtd->sram_bank = ACP_SRAM_BANK_2_ADDRESS;
+				break;
+			default:
+				rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET;
+				rtd->sram_bank = ACP_SRAM_BANK_5_ADDRESS;
+			}
+			rtd->destination = FROM_ACP_I2S_1;
+			rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14;
+			rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15;
+			rtd->byte_cnt_high_reg_offset =
+					mmACP_I2S_RECEIVED_BYTE_CNT_HIGH;
+			rtd->byte_cnt_low_reg_offset =
+					mmACP_I2S_RECEIVED_BYTE_CNT_LOW;
+			adata->capture_i2ssp_stream = substream;
 		}
-		rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
-		rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
-		rtd->destination = FROM_ACP_I2S_1;
-		rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14;
-		rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15;
-		rtd->byte_cnt_high_reg_offset =
-				mmACP_I2S_RECEIVED_BYTE_CNT_HIGH;
-		rtd->byte_cnt_low_reg_offset = mmACP_I2S_RECEIVED_BYTE_CNT_LOW;
 	}
 
 	size = params_buffer_bytes(params);
@@ -999,24 +1112,39 @@ static int acp_dma_close(struct snd_pcm_substream *substream)
 	struct audio_drv_data *adata = dev_get_drvdata(component->dev);
 
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		adata->play_i2ssp_stream = NULL;
-		/*
-		 * For Stoney, Memory gating is disabled,i.e SRAM Banks
-		 * won't be turned off. The default state for SRAM banks is ON.
-		 * Setting SRAM bank state code skipped for STONEY platform.
-		 * added condition checks for Carrizo platform only
-		 */
-		if (adata->asic_type != CHIP_STONEY) {
-			for (bank = 1; bank <= 4; bank++)
-				acp_set_sram_bank_state(adata->acp_mmio, bank,
-							false);
+		switch (rtd->i2s_instance) {
+		case I2S_BT_INSTANCE:
+			adata->play_i2sbt_stream = NULL;
+			break;
+		case I2S_SP_INSTANCE:
+		default:
+			adata->play_i2ssp_stream = NULL;
+			/*
+			 * For Stoney, Memory gating is disabled,i.e SRAM Banks
+			 * won't be turned off. The default state for SRAM banks
+			 * is ON.Setting SRAM bank state code skipped for STONEY
+			 * platform. Added condition checks for Carrizo platform
+			 * only.
+			 */
+			if (adata->asic_type != CHIP_STONEY) {
+				for (bank = 1; bank <= 4; bank++)
+					acp_set_sram_bank_state(adata->acp_mmio,
+								bank, false);
+			}
 		}
 	} else  {
-		adata->capture_i2ssp_stream = NULL;
-		if (adata->asic_type != CHIP_STONEY) {
-			for (bank = 5; bank <= 8; bank++)
-				acp_set_sram_bank_state(adata->acp_mmio, bank,
-							false);
+		switch (rtd->i2s_instance) {
+		case I2S_BT_INSTANCE:
+			adata->capture_i2sbt_stream = NULL;
+			break;
+		case I2S_SP_INSTANCE:
+		default:
+			adata->capture_i2ssp_stream = NULL;
+			if (adata->asic_type != CHIP_STONEY) {
+				for (bank = 5; bank <= 8; bank++)
+					acp_set_sram_bank_state(adata->acp_mmio,
+								bank, false);
+			}
 		}
 	}
 
@@ -1024,7 +1152,8 @@ static int acp_dma_close(struct snd_pcm_substream *substream)
 	 * Disable ACP irq, when the current stream is being closed and
 	 * another stream is also not active.
 	 */
-	if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream)
+	if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream &&
+	    !adata->play_i2sbt_stream && !adata->capture_i2sbt_stream)
 		acp_reg_write(0, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB);
 	kfree(rtd);
 	return 0;
@@ -1078,6 +1207,8 @@ static int acp_audio_probe(struct platform_device *pdev)
 
 	audio_drv_data->play_i2ssp_stream = NULL;
 	audio_drv_data->capture_i2ssp_stream = NULL;
+	audio_drv_data->play_i2sbt_stream = NULL;
+	audio_drv_data->capture_i2sbt_stream = NULL;
 
 	audio_drv_data->asic_type =  *pdata;
 
@@ -1134,6 +1265,7 @@ static int acp_pcm_resume(struct device *dev)
 {
 	u16 bank;
 	int status;
+	struct audio_substream_data *rtd;
 	struct audio_drv_data *adata = dev_get_drvdata(dev);
 
 	status = acp_init(adata->acp_mmio, adata->asic_type);
@@ -1153,9 +1285,8 @@ static int acp_pcm_resume(struct device *dev)
 				acp_set_sram_bank_state(adata->acp_mmio, bank,
 							true);
 		}
-		config_acp_dma(adata->acp_mmio,
-			       adata->play_i2ssp_stream->runtime->private_data,
-			       adata->asic_type);
+		rtd = adata->play_i2ssp_stream->runtime->private_data;
+		config_acp_dma(adata->acp_mmio, rtd, adata->asic_type);
 	}
 	if (adata->capture_i2ssp_stream &&
 	    adata->capture_i2ssp_stream->runtime) {
@@ -1164,9 +1295,20 @@ static int acp_pcm_resume(struct device *dev)
 				acp_set_sram_bank_state(adata->acp_mmio, bank,
 							true);
 		}
-		config_acp_dma(adata->acp_mmio,
-			       adata->capture_i2ssp_stream->runtime->private_data,
-			       adata->asic_type);
+		rtd =  adata->capture_i2ssp_stream->runtime->private_data;
+		config_acp_dma(adata->acp_mmio, rtd, adata->asic_type);
+	}
+	if (adata->asic_type != CHIP_CARRIZO) {
+		if (adata->play_i2sbt_stream &&
+		    adata->play_i2sbt_stream->runtime) {
+			rtd = adata->play_i2sbt_stream->runtime->private_data;
+			config_acp_dma(adata->acp_mmio, rtd, adata->asic_type);
+		}
+		if (adata->capture_i2sbt_stream &&
+		    adata->capture_i2sbt_stream->runtime) {
+			rtd = adata->capture_i2sbt_stream->runtime->private_data;
+			config_acp_dma(adata->acp_mmio, rtd, adata->asic_type);
+		}
 	}
 	acp_reg_write(1, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB);
 	return 0;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 62695ed..9cd3e96 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -13,6 +13,8 @@
 /* Playback and Capture Offset for Stoney */
 #define ACP_ST_PLAYBACK_PTE_OFFSET	0x04
 #define ACP_ST_CAPTURE_PTE_OFFSET	0x00
+#define ACP_ST_BT_PLAYBACK_PTE_OFFSET	0x08
+#define ACP_ST_BT_CAPTURE_PTE_OFFSET	0x0c
 
 #define ACP_GARLIC_CNTL_DEFAULT			0x00000FB4
 #define ACP_ONION_CNTL_DEFAULT			0x00000FB4
@@ -46,8 +48,13 @@
 
 #define TO_ACP_I2S_1   0x2
 #define TO_ACP_I2S_2   0x4
+#define TO_BLUETOOTH   0x3
 #define FROM_ACP_I2S_1 0xa
 #define FROM_ACP_I2S_2 0xb
+#define FROM_BLUETOOTH 0xb
+
+#define I2S_SP_INSTANCE                 0x01
+#define I2S_BT_INSTANCE                 0x02
 
 #define ACP_TILE_ON_MASK                0x03
 #define ACP_TILE_OFF_MASK               0x02
@@ -68,6 +75,14 @@
 #define ACP_TO_SYSRAM_CH_NUM 14
 #define I2S_TO_ACP_DMA_CH_NUM 15
 
+/* Playback DMA Channels for I2S BT instance */
+#define SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM  8
+#define ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM 9
+
+/* Capture DMA Channels for I2S BT Instance */
+#define ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM 10
+#define I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM 11
+
 #define NUM_DSCRS_PER_CHANNEL 2
 
 #define PLAYBACK_START_DMA_DESCR_CH12 0
@@ -80,9 +95,23 @@
 #define CAPTURE_START_DMA_DESCR_CH15 6
 #define CAPTURE_END_DMA_DESCR_CH15 7
 
+/* I2S BT Instance DMA Descriptors */
+#define PLAYBACK_START_DMA_DESCR_CH8 8
+#define PLAYBACK_END_DMA_DESCR_CH8 9
+#define PLAYBACK_START_DMA_DESCR_CH9 10
+#define PLAYBACK_END_DMA_DESCR_CH9 11
+
+#define CAPTURE_START_DMA_DESCR_CH10 12
+#define CAPTURE_END_DMA_DESCR_CH10 13
+#define CAPTURE_START_DMA_DESCR_CH11 14
+#define CAPTURE_END_DMA_DESCR_CH11 15
+
 #define mmACP_I2S_16BIT_RESOLUTION_EN       0x5209
 #define ACP_I2S_MIC_16BIT_RESOLUTION_EN 0x01
 #define ACP_I2S_SP_16BIT_RESOLUTION_EN	0x02
+#define ACP_I2S_BT_16BIT_RESOLUTION_EN	0x04
+#define ACP_BT_UART_PAD_SELECT_MASK	0x1
+
 enum acp_dma_priority_level {
 	/* 0x0 Specifies the DMA channel is given normal priority */
 	ACP_DMA_PRIORITY_LEVEL_NORMAL = 0x0,
@@ -95,6 +124,7 @@ struct audio_substream_data {
 	struct page *pg;
 	unsigned int order;
 	u16 num_of_pages;
+	u16 i2s_instance;
 	u16 direction;
 	u16 ch1;
 	u16 ch2;
@@ -113,10 +143,20 @@ struct audio_substream_data {
 struct audio_drv_data {
 	struct snd_pcm_substream *play_i2ssp_stream;
 	struct snd_pcm_substream *capture_i2ssp_stream;
+	struct snd_pcm_substream *play_i2sbt_stream;
+	struct snd_pcm_substream *capture_i2sbt_stream;
 	void __iomem *acp_mmio;
 	u32 asic_type;
 };
 
+/*
+ * this structure used for platform data transfer between machine driver
+ * and dma driver
+ */
+struct acp_platform_info {
+	u16 i2s_instance;
+};
+
 union acp_dma_count {
 	struct {
 	u32 low;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH V3 10/10] ASoC: amd: dma driver changes for bt i2s instance
  2018-05-01 20:50 ` [PATCH V3 10/10] ASoC: amd: dma driver changes for bt i2s instance Vijendar Mukunda
@ 2018-05-03  5:43   ` Daniel Kurtz
  2018-05-03  7:35     ` Mukunda,Vijendar
  0 siblings, 1 reply; 23+ messages in thread
From: Daniel Kurtz @ 2018-05-03  5:43 UTC (permalink / raw)
  To: Vijendar.Mukunda
  Cc: lgirdwood, broonie, perex, tiwai, Akshu.Agrawal,
	kuninori.morimoto.gx, alexander.deucher, weiyongjun1, jclinton,
	linux, gregkh, kstewart, alsa-devel, linux-kernel

Some checkpatch nits below...

On Tue, May 1, 2018 at 2:53 PM Vijendar Mukunda <Vijendar.Mukunda@amd.com>
wrote:

> With in ACP, There are three I2S controllers can be
> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
> Default enabled I2S controller instance is I2S SP.
> This patch provides required changes to support I2S BT
> controller Instance.

> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> v1->v2: defined i2s instance macros in acp header file
> v2->v3: sqaushed previous patch series and spilt changes
>           into multiple patches (acp dma driver code cleanup
>           patches and bt i2s instance specific changes)
>    sound/soc/amd/acp-da7219-max98357a.c |  23 ++++
>    sound/soc/amd/acp-pcm-dma.c          | 256
+++++++++++++++++++++++++++--------
>    sound/soc/amd/acp.h                  |  40 ++++++
>    3 files changed, 262 insertions(+), 57 deletions(-)

> diff --git a/sound/soc/amd/acp-da7219-max98357a.c
b/sound/soc/amd/acp-da7219-max98357a.c
> index 133139d..b3184ab 100644
> --- a/sound/soc/amd/acp-da7219-max98357a.c
> +++ b/sound/soc/amd/acp-da7219-max98357a.c
> @@ -36,6 +36,7 @@
>    #include <linux/input.h>
>    #include <linux/acpi.h>

> +#include "acp.h"
>    #include "../codecs/da7219.h"
>    #include "../codecs/da7219-aad.h"

> @@ -44,6 +45,7 @@

>    static struct snd_soc_jack cz_jack;
>    static struct clk *da7219_dai_clk;
> +extern int bt_pad_enable;

WARNING: externs should be avoided in .c files


>    static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)
>    {
> @@ -132,6 +134,9 @@ static const struct snd_pcm_hw_constraint_list
constraints_channels = {
>    static int cz_da7219_startup(struct snd_pcm_substream *substream)
>    {
>           struct snd_pcm_runtime *runtime = substream->runtime;
> +       struct snd_soc_pcm_runtime *rtd = substream->private_data;
> +       struct snd_soc_card *card = rtd->card;
> +       struct acp_platform_info *machine =
snd_soc_card_get_drvdata(card);

>           /*
>            * On this platform for PCM device we support stereo
> @@ -143,6 +148,7 @@ static int cz_da7219_startup(struct snd_pcm_substream
*substream)
>           snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,
>                                      &constraints_rates);

> +       machine->i2s_instance = I2S_BT_INSTANCE;

I'm not a big fan of this approach, but I don't know any other way to tell
a single "platform" driver (acp-pcm-dma) which of two channels (ST/BT) to
use via the pcm_open() callback.

Mark, can you recommend any other way of doing this?

>           return da7219_clk_enable(substream);
>    }

> @@ -153,6 +159,11 @@ static void cz_da7219_shutdown(struct
snd_pcm_substream *substream)

>    static int cz_max_startup(struct snd_pcm_substream *substream)
>    {
> +       struct snd_soc_pcm_runtime *rtd = substream->private_data;
> +       struct snd_soc_card *card = rtd->card;
> +       struct acp_platform_info *machine =
snd_soc_card_get_drvdata(card);
> +
> +       machine->i2s_instance = I2S_SP_INSTANCE;
>           return da7219_clk_enable(substream);
>    }

> @@ -163,6 +174,11 @@ static void cz_max_shutdown(struct snd_pcm_substream
*substream)

>    static int cz_dmic_startup(struct snd_pcm_substream *substream)
>    {
> +       struct snd_soc_pcm_runtime *rtd = substream->private_data;
> +       struct snd_soc_card *card = rtd->card;
> +       struct acp_platform_info *machine =
snd_soc_card_get_drvdata(card);
> +
> +       machine->i2s_instance = I2S_SP_INSTANCE;
>           return da7219_clk_enable(substream);
>    }

> @@ -266,10 +282,16 @@ static int cz_probe(struct platform_device *pdev)
>    {
>           int ret;
>           struct snd_soc_card *card;
> +       struct acp_platform_info *machine;

> +       machine = devm_kzalloc(&pdev->dev, sizeof(struct
acp_platform_info),
> +                              GFP_KERNEL);
> +       if (!machine)
> +               return -ENOMEM;
>           card = &cz_card;
>           cz_card.dev = &pdev->dev;
>           platform_set_drvdata(pdev, card);
> +       snd_soc_card_set_drvdata(card, machine);
>           ret = devm_snd_soc_register_card(&pdev->dev, &cz_card);
>           if (ret) {
>                   dev_err(&pdev->dev,
> @@ -277,6 +299,7 @@ static int cz_probe(struct platform_device *pdev)
>                                   cz_card.name, ret);
>                   return ret;
>           }
> +       bt_pad_enable = device_property_read_bool(&pdev->dev,
"bt-pad-enable");
>           return 0;
>    }

> diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
> index ec9cab3..2ea103a 100644
> --- a/sound/soc/amd/acp-pcm-dma.c
> +++ b/sound/soc/amd/acp-pcm-dma.c
> @@ -37,12 +37,14 @@
>    #define MAX_BUFFER (PLAYBACK_MAX_PERIOD_SIZE * PLAYBACK_MAX_NUM_PERIODS)
>    #define MIN_BUFFER MAX_BUFFER

> -#define ST_PLAYBACK_MAX_PERIOD_SIZE 8192
> +#define ST_PLAYBACK_MAX_PERIOD_SIZE 4096
>    #define ST_CAPTURE_MAX_PERIOD_SIZE  ST_PLAYBACK_MAX_PERIOD_SIZE
>    #define ST_MAX_BUFFER (ST_PLAYBACK_MAX_PERIOD_SIZE *
PLAYBACK_MAX_NUM_PERIODS)
>    #define ST_MIN_BUFFER ST_MAX_BUFFER

>    #define DRV_NAME "acp_audio_dma"
> +bool bt_pad_enable = false;

ERROR: do not initialise globals to false

> +EXPORT_SYMBOL(bt_pad_enable);

>    static const struct snd_pcm_hardware acp_pcm_hardware_playback = {
>           .info = SNDRV_PCM_INFO_INTERLEAVED |
> @@ -357,6 +359,9 @@ static void acp_dma_start(void __iomem *acp_mmio,
>           case ACP_TO_I2S_DMA_CH_NUM:
>           case ACP_TO_SYSRAM_CH_NUM:
>           case I2S_TO_ACP_DMA_CH_NUM:
> +       case ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM:
> +       case ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM:
> +       case I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM:
>                   dma_ctrl |= ACP_DMA_CNTL_0__DMAChIOCEn_MASK;
>                   break;
>           default:
> @@ -519,6 +524,13 @@ static int acp_init(void __iomem *acp_mmio, u32
asic_type)
>           val &= ~ACP_SOFT_RESET__SoftResetAud_MASK;
>           acp_reg_write(val, acp_mmio, mmACP_SOFT_RESET);

> +       /* For BT instance change pins from UART to BT */
> +       if (bt_pad_enable) {
> +               val = acp_reg_read(acp_mmio, mmACP_BT_UART_PAD_SEL);
> +               val |= ACP_BT_UART_PAD_SELECT_MASK;
> +               acp_reg_write(val, acp_mmio, mmACP_BT_UART_PAD_SEL);
> +       }
> +
>           /* initiailize Onion control DAGB register */
>           acp_reg_write(ACP_ONION_CNTL_DEFAULT, acp_mmio,
>                         mmACP_AXI2DAGB_ONION_CNTL);
> @@ -637,6 +649,24 @@ static irqreturn_t dma_irq_handler(int irq, void
*arg)
>                                 acp_mmio, mmACP_EXTERNAL_INTR_STAT);
>           }

> +       if ((intr_flag & BIT(ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM)) != 0) {
> +               valid_irq = true;
> +               if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_9) ==
> +                       PLAYBACK_START_DMA_DESCR_CH9)
> +                       dscr_idx = PLAYBACK_END_DMA_DESCR_CH8;
> +               else
> +                       dscr_idx = PLAYBACK_START_DMA_DESCR_CH8;
> +               config_acp_dma_channel(acp_mmio,
> +                                      SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM,
> +                                      dscr_idx, 1, 0);
> +               acp_dma_start(acp_mmio, SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM,
> +                             false);
> +               snd_pcm_period_elapsed(irq_data->play_i2sbt_stream);
> +               acp_reg_write((intr_flag &
> +                             BIT(ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM)) <<
16,
> +                             acp_mmio, mmACP_EXTERNAL_INTR_STAT);
> +       }
> +
>           if ((intr_flag & BIT(I2S_TO_ACP_DMA_CH_NUM)) != 0) {
>                   valid_irq = true;
>                   if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_15) ==
> @@ -659,6 +689,31 @@ static irqreturn_t dma_irq_handler(int irq, void
*arg)
>                                 acp_mmio, mmACP_EXTERNAL_INTR_STAT);
>           }

> +       if ((intr_flag & BIT(I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM)) != 0) {
> +               valid_irq = true;
> +               if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_11) ==
> +                       CAPTURE_START_DMA_DESCR_CH11)
> +                       dscr_idx = CAPTURE_END_DMA_DESCR_CH10;
> +               else
> +                       dscr_idx = CAPTURE_START_DMA_DESCR_CH10;
> +               config_acp_dma_channel(acp_mmio,
> +                                      ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM,
> +                                      dscr_idx, 1, 0);
> +               acp_dma_start(acp_mmio, ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM,
> +                             false);
> +               acp_reg_write((intr_flag &
> +                             BIT(I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM)) <<
16,
> +                             acp_mmio, mmACP_EXTERNAL_INTR_STAT);
> +       }
> +
> +       if ((intr_flag & BIT(ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM)) != 0) {
> +               valid_irq = true;
> +               snd_pcm_period_elapsed(irq_data->capture_i2sbt_stream);
> +               acp_reg_write((intr_flag &
> +                             BIT(ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM)) <<
16,
> +                             acp_mmio, mmACP_EXTERNAL_INTR_STAT);
> +       }
> +
>           if (valid_irq)
>                   return IRQ_HANDLED;
>           else
> @@ -714,11 +769,11 @@ static int acp_dma_open(struct snd_pcm_substream
*substream)
>            * This enablement is not required for another stream, if current
>            * stream is not closed
>            */
> -       if (!intr_data->play_i2ssp_stream &&
!intr_data->capture_i2ssp_stream)
> +       if (!intr_data->play_i2ssp_stream &&
!intr_data->capture_i2ssp_stream &&
> +           !intr_data->play_i2sbt_stream &&
!intr_data->capture_i2sbt_stream)
>                   acp_reg_write(1, adata->acp_mmio,
mmACP_EXTERNAL_INTR_ENB);

>           if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> -               intr_data->play_i2ssp_stream = substream;
>                   /*
>                    * For Stoney, Memory gating is disabled,i.e SRAM Banks
>                    * won't be turned off. The default state for SRAM banks
is ON.
> @@ -730,7 +785,6 @@ static int acp_dma_open(struct snd_pcm_substream
*substream)
>                                                           bank, true);
>                   }
>           } else {
> -               intr_data->capture_i2ssp_stream = substream;
>                   if (intr_data->asic_type != CHIP_STONEY) {
>                           for (bank = 5; bank <= 8; bank++)

acp_set_sram_bank_state(intr_data->acp_mmio,
> @@ -754,6 +808,8 @@ static int acp_dma_hw_params(struct snd_pcm_substream
*substream,
>           struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd,

DRV_NAME);
>           struct audio_drv_data *adata = dev_get_drvdata(component->dev);
> +       struct snd_soc_card *card = prtd->card;
> +       struct acp_platform_info *pinfo = snd_soc_card_get_drvdata(card);

>           runtime = substream->runtime;
>           rtd = runtime->private_data;
> @@ -761,52 +817,109 @@ static int acp_dma_hw_params(struct
snd_pcm_substream *substream,
>           if (WARN_ON(!rtd))
>                   return -EINVAL;

> +       rtd->i2s_instance = pinfo->i2s_instance;
>           if (adata->asic_type == CHIP_STONEY) {
>                   val = acp_reg_read(adata->acp_mmio,
>                                      mmACP_I2S_16BIT_RESOLUTION_EN);
> -               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> -                       val |= ACP_I2S_SP_16BIT_RESOLUTION_EN;
> -               else
> -                       val |= ACP_I2S_MIC_16BIT_RESOLUTION_EN;
> +               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> +                       switch (rtd->i2s_instance) {
> +                       case I2S_BT_INSTANCE:
> +                               val |= ACP_I2S_BT_16BIT_RESOLUTION_EN;
> +                               break;
> +                       case I2S_SP_INSTANCE:
> +                       default:
> +                               val |= ACP_I2S_SP_16BIT_RESOLUTION_EN;
> +                       }
> +               } else {
> +                       switch (rtd->i2s_instance) {
> +                       case I2S_BT_INSTANCE:
> +                               val |= ACP_I2S_BT_16BIT_RESOLUTION_EN;
> +                               break;
> +                       case I2S_SP_INSTANCE:
> +                       default:
> +                               val |= ACP_I2S_MIC_16BIT_RESOLUTION_EN;
> +                       }
> +               }
>                   acp_reg_write(val, adata->acp_mmio,
>                                 mmACP_I2S_16BIT_RESOLUTION_EN);
>           }

>           if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> -               switch (adata->asic_type) {
> -               case CHIP_STONEY:
> -                       rtd->pte_offset = ACP_ST_PLAYBACK_PTE_OFFSET;
> +               switch (rtd->i2s_instance) {
> +               case I2S_BT_INSTANCE:
> +                       rtd->pte_offset = ACP_ST_BT_PLAYBACK_PTE_OFFSET;
> +                       rtd->ch1 = SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM;
> +                       rtd->ch2 = ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM;
> +                       rtd->sram_bank = ACP_SRAM_BANK_3_ADDRESS;
> +                       rtd->destination = TO_BLUETOOTH;
> +                       rtd->dma_dscr_idx_1 =
PLAYBACK_START_DMA_DESCR_CH8;
> +                       rtd->dma_dscr_idx_2 =
PLAYBACK_START_DMA_DESCR_CH9;
> +                       rtd->byte_cnt_high_reg_offset =
> +
mmACP_I2S_BT_TRANSMIT_BYTE_CNT_HIGH;
> +                       rtd->byte_cnt_low_reg_offset =
> +
mmACP_I2S_BT_TRANSMIT_BYTE_CNT_LOW;
> +                       adata->play_i2sbt_stream = substream;
>                           break;
> +               case I2S_SP_INSTANCE:
>                   default:
> -                       rtd->pte_offset = ACP_PLAYBACK_PTE_OFFSET;
> +                       switch (adata->asic_type) {
> +                       case CHIP_STONEY:
> +                               rtd->pte_offset =
ACP_ST_PLAYBACK_PTE_OFFSET;
> +                               break;
> +                       default:
> +                               rtd->pte_offset = ACP_PLAYBACK_PTE_OFFSET;
> +                       }
> +                       rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
> +                       rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
> +                       rtd->sram_bank = ACP_SRAM_BANK_1_ADDRESS;
> +                       rtd->destination = TO_ACP_I2S_1;
> +                       rtd->dma_dscr_idx_1 =
PLAYBACK_START_DMA_DESCR_CH12;
> +                       rtd->dma_dscr_idx_2 =
PLAYBACK_START_DMA_DESCR_CH13;
> +                       rtd->byte_cnt_high_reg_offset =
> +                                       mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
> +                       rtd->byte_cnt_low_reg_offset =
> +                                       mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
> +                       adata->play_i2ssp_stream = substream;
>                   }
> -               rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
> -               rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
> -               rtd->sram_bank = ACP_SRAM_BANK_1_ADDRESS;
> -               rtd->destination = TO_ACP_I2S_1;
> -               rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
> -               rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
> -               rtd->byte_cnt_high_reg_offset =
> -                               mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
> -               rtd->byte_cnt_low_reg_offset =
mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
>           } else {
> -               switch (adata->asic_type) {
> -               case CHIP_STONEY:
> -                       rtd->pte_offset = ACP_ST_CAPTURE_PTE_OFFSET;
> -                       rtd->sram_bank = ACP_SRAM_BANK_2_ADDRESS;
> +               switch (rtd->i2s_instance) {
> +               case I2S_BT_INSTANCE:
> +                       rtd->pte_offset = ACP_ST_BT_CAPTURE_PTE_OFFSET;
> +                       rtd->ch1 = ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM;
> +                       rtd->ch2 = I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM;
> +                       rtd->sram_bank = ACP_SRAM_BANK_4_ADDRESS;
> +                       rtd->destination = FROM_BLUETOOTH;
> +                       rtd->dma_dscr_idx_1 =
CAPTURE_START_DMA_DESCR_CH10;
> +                       rtd->dma_dscr_idx_2 =
CAPTURE_START_DMA_DESCR_CH11;
> +                       rtd->byte_cnt_high_reg_offset =
> +
mmACP_I2S_BT_RECEIVE_BYTE_CNT_HIGH;
> +                       rtd->byte_cnt_low_reg_offset =
> +                                       mmACP_I2S_BT_RECEIVE_BYTE_CNT_LOW;
> +                       adata->capture_i2sbt_stream = substream;
>                           break;
> +               case I2S_SP_INSTANCE:
>                   default:
>                           rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET;
> -                       rtd->sram_bank = ACP_SRAM_BANK_5_ADDRESS;
> +                       rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
> +                       rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
> +                       switch (adata->asic_type) {
> +                       case CHIP_STONEY:
> +                               rtd->pte_offset =
ACP_ST_CAPTURE_PTE_OFFSET;
> +                               rtd->sram_bank = ACP_SRAM_BANK_2_ADDRESS;
> +                               break;
> +                       default:
> +                               rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET;
> +                               rtd->sram_bank = ACP_SRAM_BANK_5_ADDRESS;
> +                       }
> +                       rtd->destination = FROM_ACP_I2S_1;
> +                       rtd->dma_dscr_idx_1 =
CAPTURE_START_DMA_DESCR_CH14;
> +                       rtd->dma_dscr_idx_2 =
CAPTURE_START_DMA_DESCR_CH15;
> +                       rtd->byte_cnt_high_reg_offset =
> +                                       mmACP_I2S_RECEIVED_BYTE_CNT_HIGH;
> +                       rtd->byte_cnt_low_reg_offset =
> +                                       mmACP_I2S_RECEIVED_BYTE_CNT_LOW;
> +                       adata->capture_i2ssp_stream = substream;
>                   }
> -               rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
> -               rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
> -               rtd->destination = FROM_ACP_I2S_1;
> -               rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14;
> -               rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15;
> -               rtd->byte_cnt_high_reg_offset =
> -                               mmACP_I2S_RECEIVED_BYTE_CNT_HIGH;
> -               rtd->byte_cnt_low_reg_offset =
mmACP_I2S_RECEIVED_BYTE_CNT_LOW;
>           }

>           size = params_buffer_bytes(params);
> @@ -999,24 +1112,39 @@ static int acp_dma_close(struct snd_pcm_substream
*substream)
>           struct audio_drv_data *adata = dev_get_drvdata(component->dev);

>           if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> -               adata->play_i2ssp_stream = NULL;
> -               /*
> -                * For Stoney, Memory gating is disabled,i.e SRAM Banks
> -                * won't be turned off. The default state for SRAM banks
is ON.
> -                * Setting SRAM bank state code skipped for STONEY
platform.
> -                * added condition checks for Carrizo platform only
> -                */
> -               if (adata->asic_type != CHIP_STONEY) {
> -                       for (bank = 1; bank <= 4; bank++)
> -                               acp_set_sram_bank_state(adata->acp_mmio,
bank,
> -                                                       false);
> +               switch (rtd->i2s_instance) {
> +               case I2S_BT_INSTANCE:
> +                       adata->play_i2sbt_stream = NULL;
> +                       break;
> +               case I2S_SP_INSTANCE:
> +               default:
> +                       adata->play_i2ssp_stream = NULL;
> +                       /*
> +                        * For Stoney, Memory gating is disabled,i.e SRAM
Banks
> +                        * won't be turned off. The default state for
SRAM banks
> +                        * is ON.Setting SRAM bank state code skipped for
STONEY
> +                        * platform. Added condition checks for Carrizo
platform
> +                        * only.
> +                        */
> +                       if (adata->asic_type != CHIP_STONEY) {
> +                               for (bank = 1; bank <= 4; bank++)
> +
acp_set_sram_bank_state(adata->acp_mmio,
> +                                                               bank,
false);
> +                       }
>                   }
>           } else  {
> -               adata->capture_i2ssp_stream = NULL;
> -               if (adata->asic_type != CHIP_STONEY) {
> -                       for (bank = 5; bank <= 8; bank++)
> -                               acp_set_sram_bank_state(adata->acp_mmio,
bank,
> -                                                       false);
> +               switch (rtd->i2s_instance) {
> +               case I2S_BT_INSTANCE:
> +                       adata->capture_i2sbt_stream = NULL;
> +                       break;
> +               case I2S_SP_INSTANCE:
> +               default:
> +                       adata->capture_i2ssp_stream = NULL;
> +                       if (adata->asic_type != CHIP_STONEY) {
> +                               for (bank = 5; bank <= 8; bank++)
> +
acp_set_sram_bank_state(adata->acp_mmio,
> +                                                               bank,
false);
> +                       }
>                   }
>           }

> @@ -1024,7 +1152,8 @@ static int acp_dma_close(struct snd_pcm_substream
*substream)
>            * Disable ACP irq, when the current stream is being closed and
>            * another stream is also not active.
>            */
> -       if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream)
> +       if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream &&
> +           !adata->play_i2sbt_stream && !adata->capture_i2sbt_stream)
>                   acp_reg_write(0, adata->acp_mmio,
mmACP_EXTERNAL_INTR_ENB);
>           kfree(rtd);
>           return 0;
> @@ -1078,6 +1207,8 @@ static int acp_audio_probe(struct platform_device
*pdev)

>           audio_drv_data->play_i2ssp_stream = NULL;
>           audio_drv_data->capture_i2ssp_stream = NULL;
> +       audio_drv_data->play_i2sbt_stream = NULL;
> +       audio_drv_data->capture_i2sbt_stream = NULL;

>           audio_drv_data->asic_type =  *pdata;

> @@ -1134,6 +1265,7 @@ static int acp_pcm_resume(struct device *dev)
>    {
>           u16 bank;
>           int status;
> +       struct audio_substream_data *rtd;
>           struct audio_drv_data *adata = dev_get_drvdata(dev);

>           status = acp_init(adata->acp_mmio, adata->asic_type);
> @@ -1153,9 +1285,8 @@ static int acp_pcm_resume(struct device *dev)
>                                   acp_set_sram_bank_state(adata->acp_mmio,
bank,
>                                                           true);
>                   }
> -               config_acp_dma(adata->acp_mmio,
> -
   adata->play_i2ssp_stream->runtime->private_data,
> -                              adata->asic_type);
> +               rtd = adata->play_i2ssp_stream->runtime->private_data;
> +               config_acp_dma(adata->acp_mmio, rtd, adata->asic_type);
>           }
>           if (adata->capture_i2ssp_stream &&
>               adata->capture_i2ssp_stream->runtime) {
> @@ -1164,9 +1295,20 @@ static int acp_pcm_resume(struct device *dev)
>                                   acp_set_sram_bank_state(adata->acp_mmio,
bank,
>                                                           true);
>                   }
> -               config_acp_dma(adata->acp_mmio,
> -
   adata->capture_i2ssp_stream->runtime->private_data,
> -                              adata->asic_type);
> +               rtd =  adata->capture_i2ssp_stream->runtime->private_data;
> +               config_acp_dma(adata->acp_mmio, rtd, adata->asic_type);
> +       }
> +       if (adata->asic_type != CHIP_CARRIZO) {
> +               if (adata->play_i2sbt_stream &&
> +                   adata->play_i2sbt_stream->runtime) {
> +                       rtd =
adata->play_i2sbt_stream->runtime->private_data;
> +                       config_acp_dma(adata->acp_mmio, rtd,
adata->asic_type);
> +               }
> +               if (adata->capture_i2sbt_stream &&
> +                   adata->capture_i2sbt_stream->runtime) {
> +                       rtd =
adata->capture_i2sbt_stream->runtime->private_data;

WARNING: line over 80 characters


> +                       config_acp_dma(adata->acp_mmio, rtd,
adata->asic_type);
> +               }
>           }
>           acp_reg_write(1, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB);
>           return 0;
> diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
> index 62695ed..9cd3e96 100644
> --- a/sound/soc/amd/acp.h
> +++ b/sound/soc/amd/acp.h
> @@ -13,6 +13,8 @@
>    /* Playback and Capture Offset for Stoney */
>    #define ACP_ST_PLAYBACK_PTE_OFFSET     0x04
>    #define ACP_ST_CAPTURE_PTE_OFFSET      0x00
> +#define ACP_ST_BT_PLAYBACK_PTE_OFFSET  0x08
> +#define ACP_ST_BT_CAPTURE_PTE_OFFSET   0x0c

>    #define ACP_GARLIC_CNTL_DEFAULT                        0x00000FB4
>    #define ACP_ONION_CNTL_DEFAULT                 0x00000FB4
> @@ -46,8 +48,13 @@

>    #define TO_ACP_I2S_1   0x2
>    #define TO_ACP_I2S_2   0x4
> +#define TO_BLUETOOTH   0x3
>    #define FROM_ACP_I2S_1 0xa
>    #define FROM_ACP_I2S_2 0xb
> +#define FROM_BLUETOOTH 0xb
> +
> +#define I2S_SP_INSTANCE                 0x01
> +#define I2S_BT_INSTANCE                 0x02

>    #define ACP_TILE_ON_MASK                0x03
>    #define ACP_TILE_OFF_MASK               0x02
> @@ -68,6 +75,14 @@
>    #define ACP_TO_SYSRAM_CH_NUM 14
>    #define I2S_TO_ACP_DMA_CH_NUM 15

> +/* Playback DMA Channels for I2S BT instance */
> +#define SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM  8
> +#define ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM 9
> +
> +/* Capture DMA Channels for I2S BT Instance */
> +#define ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM 10
> +#define I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM 11
> +
>    #define NUM_DSCRS_PER_CHANNEL 2

>    #define PLAYBACK_START_DMA_DESCR_CH12 0
> @@ -80,9 +95,23 @@
>    #define CAPTURE_START_DMA_DESCR_CH15 6
>    #define CAPTURE_END_DMA_DESCR_CH15 7

> +/* I2S BT Instance DMA Descriptors */
> +#define PLAYBACK_START_DMA_DESCR_CH8 8
> +#define PLAYBACK_END_DMA_DESCR_CH8 9
> +#define PLAYBACK_START_DMA_DESCR_CH9 10
> +#define PLAYBACK_END_DMA_DESCR_CH9 11
> +
> +#define CAPTURE_START_DMA_DESCR_CH10 12
> +#define CAPTURE_END_DMA_DESCR_CH10 13
> +#define CAPTURE_START_DMA_DESCR_CH11 14
> +#define CAPTURE_END_DMA_DESCR_CH11 15
> +
>    #define mmACP_I2S_16BIT_RESOLUTION_EN       0x5209
>    #define ACP_I2S_MIC_16BIT_RESOLUTION_EN 0x01
>    #define ACP_I2S_SP_16BIT_RESOLUTION_EN 0x02
> +#define ACP_I2S_BT_16BIT_RESOLUTION_EN 0x04
> +#define ACP_BT_UART_PAD_SELECT_MASK    0x1
> +
>    enum acp_dma_priority_level {
>           /* 0x0 Specifies the DMA channel is given normal priority */
>           ACP_DMA_PRIORITY_LEVEL_NORMAL = 0x0,
> @@ -95,6 +124,7 @@ struct audio_substream_data {
>           struct page *pg;
>           unsigned int order;
>           u16 num_of_pages;
> +       u16 i2s_instance;
>           u16 direction;
>           u16 ch1;
>           u16 ch2;
> @@ -113,10 +143,20 @@ struct audio_substream_data {
>    struct audio_drv_data {
>           struct snd_pcm_substream *play_i2ssp_stream;
>           struct snd_pcm_substream *capture_i2ssp_stream;
> +       struct snd_pcm_substream *play_i2sbt_stream;
> +       struct snd_pcm_substream *capture_i2sbt_stream;
>           void __iomem *acp_mmio;
>           u32 asic_type;
>    };

> +/*
> + * this structure used for platform data transfer between machine driver
> + * and dma driver
> + */
> +struct acp_platform_info {
> +       u16 i2s_instance;
> +};
> +
>    union acp_dma_count {
>           struct {
>           u32 low;
> --
> 2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH V3 10/10] ASoC: amd: dma driver changes for bt i2s instance
  2018-05-03  5:43   ` Daniel Kurtz
@ 2018-05-03  7:35     ` Mukunda,Vijendar
  2018-05-03 16:40       ` Daniel Kurtz
  0 siblings, 1 reply; 23+ messages in thread
From: Mukunda,Vijendar @ 2018-05-03  7:35 UTC (permalink / raw)
  To: Daniel Kurtz
  Cc: lgirdwood, broonie, perex, tiwai, Akshu.Agrawal,
	kuninori.morimoto.gx, alexander.deucher, weiyongjun1, jclinton,
	linux, gregkh, kstewart, alsa-devel, linux-kernel



On Thursday 03 May 2018 11:13 AM, Daniel Kurtz wrote:
> Some checkpatch nits below...
> 
> On Tue, May 1, 2018 at 2:53 PM Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> wrote:
> 
>> With in ACP, There are three I2S controllers can be
>> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
>> Default enabled I2S controller instance is I2S SP.
>> This patch provides required changes to support I2S BT
>> controller Instance.
> 
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> ---
>> v1->v2: defined i2s instance macros in acp header file
>> v2->v3: sqaushed previous patch series and spilt changes
>>            into multiple patches (acp dma driver code cleanup
>>            patches and bt i2s instance specific changes)
>>     sound/soc/amd/acp-da7219-max98357a.c |  23 ++++
>>     sound/soc/amd/acp-pcm-dma.c          | 256
> +++++++++++++++++++++++++++--------
>>     sound/soc/amd/acp.h                  |  40 ++++++
>>     3 files changed, 262 insertions(+), 57 deletions(-)
> 
>> diff --git a/sound/soc/amd/acp-da7219-max98357a.c
> b/sound/soc/amd/acp-da7219-max98357a.c
>> index 133139d..b3184ab 100644
>> --- a/sound/soc/amd/acp-da7219-max98357a.c
>> +++ b/sound/soc/amd/acp-da7219-max98357a.c
>> @@ -36,6 +36,7 @@
>>     #include <linux/input.h>
>>     #include <linux/acpi.h>
> 
>> +#include "acp.h"
>>     #include "../codecs/da7219.h"
>>     #include "../codecs/da7219-aad.h"
> 
>> @@ -44,6 +45,7 @@
> 
>>     static struct snd_soc_jack cz_jack;
>>     static struct clk *da7219_dai_clk;
>> +extern int bt_pad_enable;
> 
> WARNING: externs should be avoided in .c files

We don't have .h file for machine driver and It can be ignored for
one variable.
> 
> 
>>     static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)
>>     {
>> @@ -132,6 +134,9 @@ static const struct snd_pcm_hw_constraint_list
> constraints_channels = {
>>     static int cz_da7219_startup(struct snd_pcm_substream *substream)
>>     {
>>            struct snd_pcm_runtime *runtime = substream->runtime;
>> +       struct snd_soc_pcm_runtime *rtd = substream->private_data;
>> +       struct snd_soc_card *card = rtd->card;
>> +       struct acp_platform_info *machine =
> snd_soc_card_get_drvdata(card);
> 
>>            /*
>>             * On this platform for PCM device we support stereo
>> @@ -143,6 +148,7 @@ static int cz_da7219_startup(struct snd_pcm_substream
> *substream)
>>            snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,
>>                                       &constraints_rates);
> 
>> +       machine->i2s_instance = I2S_BT_INSTANCE;
> 
> I'm not a big fan of this approach, but I don't know any other way to tell
> a single "platform" driver (acp-pcm-dma) which of two channels (ST/BT) to
> use via the pcm_open() callback.
> 
> Mark, can you recommend any other way of doing this?

Hi Dan,

There have been couple of approaches worked upon this earlier.
1) To compare cpu dai name to get the I2S instance value in 
acp_dma_open() call.

But, Mark suggested not to implement this approach as we are comparing
dynamically generated cpu dai names.

2) We added i2s_instance parameter as platform data to dwc driver.
By querying dwc driver platform data in acp dma driver, current i2s 
instance was programmed in acp_dma_open ().

But Mark's latest comment was to implement platform specific changes in
machine driver. Machine driver and Dma driver should exchange the data
regarding this. We accepted this and current approach is based on the
same comment.
Below is the reference.
https://lkml.org/lkml/2018/4/18/597

-
Vijendar

> 
>>            return da7219_clk_enable(substream);
>>     }
> 
>> @@ -153,6 +159,11 @@ static void cz_da7219_shutdown(struct
> snd_pcm_substream *substream)
> 
>>     static int cz_max_startup(struct snd_pcm_substream *substream)
>>     {
>> +       struct snd_soc_pcm_runtime *rtd = substream->private_data;
>> +       struct snd_soc_card *card = rtd->card;
>> +       struct acp_platform_info *machine =
> snd_soc_card_get_drvdata(card);
>> +
>> +       machine->i2s_instance = I2S_SP_INSTANCE;
>>            return da7219_clk_enable(substream);
>>     }
> 
>> @@ -163,6 +174,11 @@ static void cz_max_shutdown(struct snd_pcm_substream
> *substream)
> 
>>     static int cz_dmic_startup(struct snd_pcm_substream *substream)
>>     {
>> +       struct snd_soc_pcm_runtime *rtd = substream->private_data;
>> +       struct snd_soc_card *card = rtd->card;
>> +       struct acp_platform_info *machine =
> snd_soc_card_get_drvdata(card);
>> +
>> +       machine->i2s_instance = I2S_SP_INSTANCE;
>>            return da7219_clk_enable(substream);
>>     }
> 
>> @@ -266,10 +282,16 @@ static int cz_probe(struct platform_device *pdev)
>>     {
>>            int ret;
>>            struct snd_soc_card *card;
>> +       struct acp_platform_info *machine;
> 
>> +       machine = devm_kzalloc(&pdev->dev, sizeof(struct
> acp_platform_info),
>> +                              GFP_KERNEL);
>> +       if (!machine)
>> +               return -ENOMEM;
>>            card = &cz_card;
>>            cz_card.dev = &pdev->dev;
>>            platform_set_drvdata(pdev, card);
>> +       snd_soc_card_set_drvdata(card, machine);
>>            ret = devm_snd_soc_register_card(&pdev->dev, &cz_card);
>>            if (ret) {
>>                    dev_err(&pdev->dev,
>> @@ -277,6 +299,7 @@ static int cz_probe(struct platform_device *pdev)
>>                                    cz_card.name, ret);
>>                    return ret;
>>            }
>> +       bt_pad_enable = device_property_read_bool(&pdev->dev,
> "bt-pad-enable");
>>            return 0;
>>     }
> 
>> diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
>> index ec9cab3..2ea103a 100644
>> --- a/sound/soc/amd/acp-pcm-dma.c
>> +++ b/sound/soc/amd/acp-pcm-dma.c
>> @@ -37,12 +37,14 @@
>>     #define MAX_BUFFER (PLAYBACK_MAX_PERIOD_SIZE * PLAYBACK_MAX_NUM_PERIODS)
>>     #define MIN_BUFFER MAX_BUFFER
> 
>> -#define ST_PLAYBACK_MAX_PERIOD_SIZE 8192
>> +#define ST_PLAYBACK_MAX_PERIOD_SIZE 4096
>>     #define ST_CAPTURE_MAX_PERIOD_SIZE  ST_PLAYBACK_MAX_PERIOD_SIZE
>>     #define ST_MAX_BUFFER (ST_PLAYBACK_MAX_PERIOD_SIZE *
> PLAYBACK_MAX_NUM_PERIODS)
>>     #define ST_MIN_BUFFER ST_MAX_BUFFER
> 
>>     #define DRV_NAME "acp_audio_dma"
>> +bool bt_pad_enable = false;
> 
> ERROR: do not initialise globals to false

We will fix it.
> 
>> +EXPORT_SYMBOL(bt_pad_enable);
> 
>>     static const struct snd_pcm_hardware acp_pcm_hardware_playback = {
>>            .info = SNDRV_PCM_INFO_INTERLEAVED |
>> @@ -357,6 +359,9 @@ static void acp_dma_start(void __iomem *acp_mmio,
>>            case ACP_TO_I2S_DMA_CH_NUM:
>>            case ACP_TO_SYSRAM_CH_NUM:
>>            case I2S_TO_ACP_DMA_CH_NUM:
>> +       case ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM:
>> +       case ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM:
>> +       case I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM:
>>                    dma_ctrl |= ACP_DMA_CNTL_0__DMAChIOCEn_MASK;
>>                    break;
>>            default:
>> @@ -519,6 +524,13 @@ static int acp_init(void __iomem *acp_mmio, u32
> asic_type)
>>            val &= ~ACP_SOFT_RESET__SoftResetAud_MASK;
>>            acp_reg_write(val, acp_mmio, mmACP_SOFT_RESET);
> 
>> +       /* For BT instance change pins from UART to BT */
>> +       if (bt_pad_enable) {
>> +               val = acp_reg_read(acp_mmio, mmACP_BT_UART_PAD_SEL);
>> +               val |= ACP_BT_UART_PAD_SELECT_MASK;
>> +               acp_reg_write(val, acp_mmio, mmACP_BT_UART_PAD_SEL);
>> +       }
>> +
>>            /* initiailize Onion control DAGB register */
>>            acp_reg_write(ACP_ONION_CNTL_DEFAULT, acp_mmio,
>>                          mmACP_AXI2DAGB_ONION_CNTL);
>> @@ -637,6 +649,24 @@ static irqreturn_t dma_irq_handler(int irq, void
> *arg)
>>                                  acp_mmio, mmACP_EXTERNAL_INTR_STAT);
>>            }
> 
>> +       if ((intr_flag & BIT(ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM)) != 0) {
>> +               valid_irq = true;
>> +               if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_9) ==
>> +                       PLAYBACK_START_DMA_DESCR_CH9)
>> +                       dscr_idx = PLAYBACK_END_DMA_DESCR_CH8;
>> +               else
>> +                       dscr_idx = PLAYBACK_START_DMA_DESCR_CH8;
>> +               config_acp_dma_channel(acp_mmio,
>> +                                      SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM,
>> +                                      dscr_idx, 1, 0);
>> +               acp_dma_start(acp_mmio, SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM,
>> +                             false);
>> +               snd_pcm_period_elapsed(irq_data->play_i2sbt_stream);
>> +               acp_reg_write((intr_flag &
>> +                             BIT(ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM)) <<
> 16,
>> +                             acp_mmio, mmACP_EXTERNAL_INTR_STAT);
>> +       }
>> +
>>            if ((intr_flag & BIT(I2S_TO_ACP_DMA_CH_NUM)) != 0) {
>>                    valid_irq = true;
>>                    if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_15) ==
>> @@ -659,6 +689,31 @@ static irqreturn_t dma_irq_handler(int irq, void
> *arg)
>>                                  acp_mmio, mmACP_EXTERNAL_INTR_STAT);
>>            }
> 
>> +       if ((intr_flag & BIT(I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM)) != 0) {
>> +               valid_irq = true;
>> +               if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_11) ==
>> +                       CAPTURE_START_DMA_DESCR_CH11)
>> +                       dscr_idx = CAPTURE_END_DMA_DESCR_CH10;
>> +               else
>> +                       dscr_idx = CAPTURE_START_DMA_DESCR_CH10;
>> +               config_acp_dma_channel(acp_mmio,
>> +                                      ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM,
>> +                                      dscr_idx, 1, 0);
>> +               acp_dma_start(acp_mmio, ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM,
>> +                             false);
>> +               acp_reg_write((intr_flag &
>> +                             BIT(I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM)) <<
> 16,
>> +                             acp_mmio, mmACP_EXTERNAL_INTR_STAT);
>> +       }
>> +
>> +       if ((intr_flag & BIT(ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM)) != 0) {
>> +               valid_irq = true;
>> +               snd_pcm_period_elapsed(irq_data->capture_i2sbt_stream);
>> +               acp_reg_write((intr_flag &
>> +                             BIT(ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM)) <<
> 16,
>> +                             acp_mmio, mmACP_EXTERNAL_INTR_STAT);
>> +       }
>> +
>>            if (valid_irq)
>>                    return IRQ_HANDLED;
>>            else
>> @@ -714,11 +769,11 @@ static int acp_dma_open(struct snd_pcm_substream
> *substream)
>>             * This enablement is not required for another stream, if current
>>             * stream is not closed
>>             */
>> -       if (!intr_data->play_i2ssp_stream &&
> !intr_data->capture_i2ssp_stream)
>> +       if (!intr_data->play_i2ssp_stream &&
> !intr_data->capture_i2ssp_stream &&
>> +           !intr_data->play_i2sbt_stream &&
> !intr_data->capture_i2sbt_stream)
>>                    acp_reg_write(1, adata->acp_mmio,
> mmACP_EXTERNAL_INTR_ENB);
> 
>>            if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
>> -               intr_data->play_i2ssp_stream = substream;
>>                    /*
>>                     * For Stoney, Memory gating is disabled,i.e SRAM Banks
>>                     * won't be turned off. The default state for SRAM banks
> is ON.
>> @@ -730,7 +785,6 @@ static int acp_dma_open(struct snd_pcm_substream
> *substream)
>>                                                            bank, true);
>>                    }
>>            } else {
>> -               intr_data->capture_i2ssp_stream = substream;
>>                    if (intr_data->asic_type != CHIP_STONEY) {
>>                            for (bank = 5; bank <= 8; bank++)
> 
> acp_set_sram_bank_state(intr_data->acp_mmio,
>> @@ -754,6 +808,8 @@ static int acp_dma_hw_params(struct snd_pcm_substream
> *substream,
>>            struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd,
> 
> DRV_NAME);
>>            struct audio_drv_data *adata = dev_get_drvdata(component->dev);
>> +       struct snd_soc_card *card = prtd->card;
>> +       struct acp_platform_info *pinfo = snd_soc_card_get_drvdata(card);
> 
>>            runtime = substream->runtime;
>>            rtd = runtime->private_data;
>> @@ -761,52 +817,109 @@ static int acp_dma_hw_params(struct
> snd_pcm_substream *substream,
>>            if (WARN_ON(!rtd))
>>                    return -EINVAL;
> 
>> +       rtd->i2s_instance = pinfo->i2s_instance;
>>            if (adata->asic_type == CHIP_STONEY) {
>>                    val = acp_reg_read(adata->acp_mmio,
>>                                       mmACP_I2S_16BIT_RESOLUTION_EN);
>> -               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
>> -                       val |= ACP_I2S_SP_16BIT_RESOLUTION_EN;
>> -               else
>> -                       val |= ACP_I2S_MIC_16BIT_RESOLUTION_EN;
>> +               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
>> +                       switch (rtd->i2s_instance) {
>> +                       case I2S_BT_INSTANCE:
>> +                               val |= ACP_I2S_BT_16BIT_RESOLUTION_EN;
>> +                               break;
>> +                       case I2S_SP_INSTANCE:
>> +                       default:
>> +                               val |= ACP_I2S_SP_16BIT_RESOLUTION_EN;
>> +                       }
>> +               } else {
>> +                       switch (rtd->i2s_instance) {
>> +                       case I2S_BT_INSTANCE:
>> +                               val |= ACP_I2S_BT_16BIT_RESOLUTION_EN;
>> +                               break;
>> +                       case I2S_SP_INSTANCE:
>> +                       default:
>> +                               val |= ACP_I2S_MIC_16BIT_RESOLUTION_EN;
>> +                       }
>> +               }
>>                    acp_reg_write(val, adata->acp_mmio,
>>                                  mmACP_I2S_16BIT_RESOLUTION_EN);
>>            }
> 
>>            if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
>> -               switch (adata->asic_type) {
>> -               case CHIP_STONEY:
>> -                       rtd->pte_offset = ACP_ST_PLAYBACK_PTE_OFFSET;
>> +               switch (rtd->i2s_instance) {
>> +               case I2S_BT_INSTANCE:
>> +                       rtd->pte_offset = ACP_ST_BT_PLAYBACK_PTE_OFFSET;
>> +                       rtd->ch1 = SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM;
>> +                       rtd->ch2 = ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM;
>> +                       rtd->sram_bank = ACP_SRAM_BANK_3_ADDRESS;
>> +                       rtd->destination = TO_BLUETOOTH;
>> +                       rtd->dma_dscr_idx_1 =
> PLAYBACK_START_DMA_DESCR_CH8;
>> +                       rtd->dma_dscr_idx_2 =
> PLAYBACK_START_DMA_DESCR_CH9;
>> +                       rtd->byte_cnt_high_reg_offset =
>> +
> mmACP_I2S_BT_TRANSMIT_BYTE_CNT_HIGH;
>> +                       rtd->byte_cnt_low_reg_offset =
>> +
> mmACP_I2S_BT_TRANSMIT_BYTE_CNT_LOW;
>> +                       adata->play_i2sbt_stream = substream;
>>                            break;
>> +               case I2S_SP_INSTANCE:
>>                    default:
>> -                       rtd->pte_offset = ACP_PLAYBACK_PTE_OFFSET;
>> +                       switch (adata->asic_type) {
>> +                       case CHIP_STONEY:
>> +                               rtd->pte_offset =
> ACP_ST_PLAYBACK_PTE_OFFSET;
>> +                               break;
>> +                       default:
>> +                               rtd->pte_offset = ACP_PLAYBACK_PTE_OFFSET;
>> +                       }
>> +                       rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
>> +                       rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
>> +                       rtd->sram_bank = ACP_SRAM_BANK_1_ADDRESS;
>> +                       rtd->destination = TO_ACP_I2S_1;
>> +                       rtd->dma_dscr_idx_1 =
> PLAYBACK_START_DMA_DESCR_CH12;
>> +                       rtd->dma_dscr_idx_2 =
> PLAYBACK_START_DMA_DESCR_CH13;
>> +                       rtd->byte_cnt_high_reg_offset =
>> +                                       mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
>> +                       rtd->byte_cnt_low_reg_offset =
>> +                                       mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
>> +                       adata->play_i2ssp_stream = substream;
>>                    }
>> -               rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
>> -               rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
>> -               rtd->sram_bank = ACP_SRAM_BANK_1_ADDRESS;
>> -               rtd->destination = TO_ACP_I2S_1;
>> -               rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
>> -               rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
>> -               rtd->byte_cnt_high_reg_offset =
>> -                               mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
>> -               rtd->byte_cnt_low_reg_offset =
> mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
>>            } else {
>> -               switch (adata->asic_type) {
>> -               case CHIP_STONEY:
>> -                       rtd->pte_offset = ACP_ST_CAPTURE_PTE_OFFSET;
>> -                       rtd->sram_bank = ACP_SRAM_BANK_2_ADDRESS;
>> +               switch (rtd->i2s_instance) {
>> +               case I2S_BT_INSTANCE:
>> +                       rtd->pte_offset = ACP_ST_BT_CAPTURE_PTE_OFFSET;
>> +                       rtd->ch1 = ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM;
>> +                       rtd->ch2 = I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM;
>> +                       rtd->sram_bank = ACP_SRAM_BANK_4_ADDRESS;
>> +                       rtd->destination = FROM_BLUETOOTH;
>> +                       rtd->dma_dscr_idx_1 =
> CAPTURE_START_DMA_DESCR_CH10;
>> +                       rtd->dma_dscr_idx_2 =
> CAPTURE_START_DMA_DESCR_CH11;
>> +                       rtd->byte_cnt_high_reg_offset =
>> +
> mmACP_I2S_BT_RECEIVE_BYTE_CNT_HIGH;
>> +                       rtd->byte_cnt_low_reg_offset =
>> +                                       mmACP_I2S_BT_RECEIVE_BYTE_CNT_LOW;
>> +                       adata->capture_i2sbt_stream = substream;
>>                            break;
>> +               case I2S_SP_INSTANCE:
>>                    default:
>>                            rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET;
>> -                       rtd->sram_bank = ACP_SRAM_BANK_5_ADDRESS;
>> +                       rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
>> +                       rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
>> +                       switch (adata->asic_type) {
>> +                       case CHIP_STONEY:
>> +                               rtd->pte_offset =
> ACP_ST_CAPTURE_PTE_OFFSET;
>> +                               rtd->sram_bank = ACP_SRAM_BANK_2_ADDRESS;
>> +                               break;
>> +                       default:
>> +                               rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET;
>> +                               rtd->sram_bank = ACP_SRAM_BANK_5_ADDRESS;
>> +                       }
>> +                       rtd->destination = FROM_ACP_I2S_1;
>> +                       rtd->dma_dscr_idx_1 =
> CAPTURE_START_DMA_DESCR_CH14;
>> +                       rtd->dma_dscr_idx_2 =
> CAPTURE_START_DMA_DESCR_CH15;
>> +                       rtd->byte_cnt_high_reg_offset =
>> +                                       mmACP_I2S_RECEIVED_BYTE_CNT_HIGH;
>> +                       rtd->byte_cnt_low_reg_offset =
>> +                                       mmACP_I2S_RECEIVED_BYTE_CNT_LOW;
>> +                       adata->capture_i2ssp_stream = substream;
>>                    }
>> -               rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
>> -               rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
>> -               rtd->destination = FROM_ACP_I2S_1;
>> -               rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14;
>> -               rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15;
>> -               rtd->byte_cnt_high_reg_offset =
>> -                               mmACP_I2S_RECEIVED_BYTE_CNT_HIGH;
>> -               rtd->byte_cnt_low_reg_offset =
> mmACP_I2S_RECEIVED_BYTE_CNT_LOW;
>>            }
> 
>>            size = params_buffer_bytes(params);
>> @@ -999,24 +1112,39 @@ static int acp_dma_close(struct snd_pcm_substream
> *substream)
>>            struct audio_drv_data *adata = dev_get_drvdata(component->dev);
> 
>>            if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
>> -               adata->play_i2ssp_stream = NULL;
>> -               /*
>> -                * For Stoney, Memory gating is disabled,i.e SRAM Banks
>> -                * won't be turned off. The default state for SRAM banks
> is ON.
>> -                * Setting SRAM bank state code skipped for STONEY
> platform.
>> -                * added condition checks for Carrizo platform only
>> -                */
>> -               if (adata->asic_type != CHIP_STONEY) {
>> -                       for (bank = 1; bank <= 4; bank++)
>> -                               acp_set_sram_bank_state(adata->acp_mmio,
> bank,
>> -                                                       false);
>> +               switch (rtd->i2s_instance) {
>> +               case I2S_BT_INSTANCE:
>> +                       adata->play_i2sbt_stream = NULL;
>> +                       break;
>> +               case I2S_SP_INSTANCE:
>> +               default:
>> +                       adata->play_i2ssp_stream = NULL;
>> +                       /*
>> +                        * For Stoney, Memory gating is disabled,i.e SRAM
> Banks
>> +                        * won't be turned off. The default state for
> SRAM banks
>> +                        * is ON.Setting SRAM bank state code skipped for
> STONEY
>> +                        * platform. Added condition checks for Carrizo
> platform
>> +                        * only.
>> +                        */
>> +                       if (adata->asic_type != CHIP_STONEY) {
>> +                               for (bank = 1; bank <= 4; bank++)
>> +
> acp_set_sram_bank_state(adata->acp_mmio,
>> +                                                               bank,
> false);
>> +                       }
>>                    }
>>            } else  {
>> -               adata->capture_i2ssp_stream = NULL;
>> -               if (adata->asic_type != CHIP_STONEY) {
>> -                       for (bank = 5; bank <= 8; bank++)
>> -                               acp_set_sram_bank_state(adata->acp_mmio,
> bank,
>> -                                                       false);
>> +               switch (rtd->i2s_instance) {
>> +               case I2S_BT_INSTANCE:
>> +                       adata->capture_i2sbt_stream = NULL;
>> +                       break;
>> +               case I2S_SP_INSTANCE:
>> +               default:
>> +                       adata->capture_i2ssp_stream = NULL;
>> +                       if (adata->asic_type != CHIP_STONEY) {
>> +                               for (bank = 5; bank <= 8; bank++)
>> +
> acp_set_sram_bank_state(adata->acp_mmio,
>> +                                                               bank,
> false);
>> +                       }
>>                    }
>>            }
> 
>> @@ -1024,7 +1152,8 @@ static int acp_dma_close(struct snd_pcm_substream
> *substream)
>>             * Disable ACP irq, when the current stream is being closed and
>>             * another stream is also not active.
>>             */
>> -       if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream)
>> +       if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream &&
>> +           !adata->play_i2sbt_stream && !adata->capture_i2sbt_stream)
>>                    acp_reg_write(0, adata->acp_mmio,
> mmACP_EXTERNAL_INTR_ENB);
>>            kfree(rtd);
>>            return 0;
>> @@ -1078,6 +1207,8 @@ static int acp_audio_probe(struct platform_device
> *pdev)
> 
>>            audio_drv_data->play_i2ssp_stream = NULL;
>>            audio_drv_data->capture_i2ssp_stream = NULL;
>> +       audio_drv_data->play_i2sbt_stream = NULL;
>> +       audio_drv_data->capture_i2sbt_stream = NULL;
> 
>>            audio_drv_data->asic_type =  *pdata;
> 
>> @@ -1134,6 +1265,7 @@ static int acp_pcm_resume(struct device *dev)
>>     {
>>            u16 bank;
>>            int status;
>> +       struct audio_substream_data *rtd;
>>            struct audio_drv_data *adata = dev_get_drvdata(dev);
> 
>>            status = acp_init(adata->acp_mmio, adata->asic_type);
>> @@ -1153,9 +1285,8 @@ static int acp_pcm_resume(struct device *dev)
>>                                    acp_set_sram_bank_state(adata->acp_mmio,
> bank,
>>                                                            true);
>>                    }
>> -               config_acp_dma(adata->acp_mmio,
>> -
>     adata->play_i2ssp_stream->runtime->private_data,
>> -                              adata->asic_type);
>> +               rtd = adata->play_i2ssp_stream->runtime->private_data;
>> +               config_acp_dma(adata->acp_mmio, rtd, adata->asic_type);
>>            }
>>            if (adata->capture_i2ssp_stream &&
>>                adata->capture_i2ssp_stream->runtime) {
>> @@ -1164,9 +1295,20 @@ static int acp_pcm_resume(struct device *dev)
>>                                    acp_set_sram_bank_state(adata->acp_mmio,
> bank,
>>                                                            true);
>>                    }
>> -               config_acp_dma(adata->acp_mmio,
>> -
>     adata->capture_i2ssp_stream->runtime->private_data,
>> -                              adata->asic_type);
>> +               rtd =  adata->capture_i2ssp_stream->runtime->private_data;
>> +               config_acp_dma(adata->acp_mmio, rtd, adata->asic_type);
>> +       }
>> +       if (adata->asic_type != CHIP_CARRIZO) {
>> +               if (adata->play_i2sbt_stream &&
>> +                   adata->play_i2sbt_stream->runtime) {
>> +                       rtd =
> adata->play_i2sbt_stream->runtime->private_data;
>> +                       config_acp_dma(adata->acp_mmio, rtd,
> adata->asic_type);
>> +               }
>> +               if (adata->capture_i2sbt_stream &&
>> +                   adata->capture_i2sbt_stream->runtime) {
>> +                       rtd =
> adata->capture_i2sbt_stream->runtime->private_data;
> 
> WARNING: line over 80 characters
> 
> 
>> +                       config_acp_dma(adata->acp_mmio, rtd,
> adata->asic_type);
>> +               }
>>            }
>>            acp_reg_write(1, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB);
>>            return 0;
>> diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
>> index 62695ed..9cd3e96 100644
>> --- a/sound/soc/amd/acp.h
>> +++ b/sound/soc/amd/acp.h
>> @@ -13,6 +13,8 @@
>>     /* Playback and Capture Offset for Stoney */
>>     #define ACP_ST_PLAYBACK_PTE_OFFSET     0x04
>>     #define ACP_ST_CAPTURE_PTE_OFFSET      0x00
>> +#define ACP_ST_BT_PLAYBACK_PTE_OFFSET  0x08
>> +#define ACP_ST_BT_CAPTURE_PTE_OFFSET   0x0c
> 
>>     #define ACP_GARLIC_CNTL_DEFAULT                        0x00000FB4
>>     #define ACP_ONION_CNTL_DEFAULT                 0x00000FB4
>> @@ -46,8 +48,13 @@
> 
>>     #define TO_ACP_I2S_1   0x2
>>     #define TO_ACP_I2S_2   0x4
>> +#define TO_BLUETOOTH   0x3
>>     #define FROM_ACP_I2S_1 0xa
>>     #define FROM_ACP_I2S_2 0xb
>> +#define FROM_BLUETOOTH 0xb
>> +
>> +#define I2S_SP_INSTANCE                 0x01
>> +#define I2S_BT_INSTANCE                 0x02
> 
>>     #define ACP_TILE_ON_MASK                0x03
>>     #define ACP_TILE_OFF_MASK               0x02
>> @@ -68,6 +75,14 @@
>>     #define ACP_TO_SYSRAM_CH_NUM 14
>>     #define I2S_TO_ACP_DMA_CH_NUM 15
> 
>> +/* Playback DMA Channels for I2S BT instance */
>> +#define SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM  8
>> +#define ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM 9
>> +
>> +/* Capture DMA Channels for I2S BT Instance */
>> +#define ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM 10
>> +#define I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM 11
>> +
>>     #define NUM_DSCRS_PER_CHANNEL 2
> 
>>     #define PLAYBACK_START_DMA_DESCR_CH12 0
>> @@ -80,9 +95,23 @@
>>     #define CAPTURE_START_DMA_DESCR_CH15 6
>>     #define CAPTURE_END_DMA_DESCR_CH15 7
> 
>> +/* I2S BT Instance DMA Descriptors */
>> +#define PLAYBACK_START_DMA_DESCR_CH8 8
>> +#define PLAYBACK_END_DMA_DESCR_CH8 9
>> +#define PLAYBACK_START_DMA_DESCR_CH9 10
>> +#define PLAYBACK_END_DMA_DESCR_CH9 11
>> +
>> +#define CAPTURE_START_DMA_DESCR_CH10 12
>> +#define CAPTURE_END_DMA_DESCR_CH10 13
>> +#define CAPTURE_START_DMA_DESCR_CH11 14
>> +#define CAPTURE_END_DMA_DESCR_CH11 15
>> +
>>     #define mmACP_I2S_16BIT_RESOLUTION_EN       0x5209
>>     #define ACP_I2S_MIC_16BIT_RESOLUTION_EN 0x01
>>     #define ACP_I2S_SP_16BIT_RESOLUTION_EN 0x02
>> +#define ACP_I2S_BT_16BIT_RESOLUTION_EN 0x04
>> +#define ACP_BT_UART_PAD_SELECT_MASK    0x1
>> +
>>     enum acp_dma_priority_level {
>>            /* 0x0 Specifies the DMA channel is given normal priority */
>>            ACP_DMA_PRIORITY_LEVEL_NORMAL = 0x0,
>> @@ -95,6 +124,7 @@ struct audio_substream_data {
>>            struct page *pg;
>>            unsigned int order;
>>            u16 num_of_pages;
>> +       u16 i2s_instance;
>>            u16 direction;
>>            u16 ch1;
>>            u16 ch2;
>> @@ -113,10 +143,20 @@ struct audio_substream_data {
>>     struct audio_drv_data {
>>            struct snd_pcm_substream *play_i2ssp_stream;
>>            struct snd_pcm_substream *capture_i2ssp_stream;
>> +       struct snd_pcm_substream *play_i2sbt_stream;
>> +       struct snd_pcm_substream *capture_i2sbt_stream;
>>            void __iomem *acp_mmio;
>>            u32 asic_type;
>>     };
> 
>> +/*
>> + * this structure used for platform data transfer between machine driver
>> + * and dma driver
>> + */
>> +struct acp_platform_info {
>> +       u16 i2s_instance;
>> +};
>> +
>>     union acp_dma_count {
>>            struct {
>>            u32 low;
>> --
>> 2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH V3 10/10] ASoC: amd: dma driver changes for bt i2s instance
  2018-05-03  7:35     ` Mukunda,Vijendar
@ 2018-05-03 16:40       ` Daniel Kurtz
  2018-05-04  4:34         ` Agrawal, Akshu
  0 siblings, 1 reply; 23+ messages in thread
From: Daniel Kurtz @ 2018-05-03 16:40 UTC (permalink / raw)
  To: vijendar.mukunda
  Cc: Liam Girdwood, Mark Brown, perex, tiwai, Akshu Agrawal,
	Kuninori Morimoto, alexander.deucher, weiyongjun1, jclinton,
	Guenter Roeck, Greg Kroah-Hartman, Kate Stewart, alsa-devel,
	linux-kernel

On Thu, May 3, 2018 at 1:33 AM Mukunda,Vijendar <vijendar.mukunda@amd.com>
wrote:



> On Thursday 03 May 2018 11:13 AM, Daniel Kurtz wrote:
> > Some checkpatch nits below...
> >
> > On Tue, May 1, 2018 at 2:53 PM Vijendar Mukunda <
Vijendar.Mukunda@amd.com>
> > wrote:
> >
> >> With in ACP, There are three I2S controllers can be
> >> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
> >> Default enabled I2S controller instance is I2S SP.
> >> This patch provides required changes to support I2S BT
> >> controller Instance.
> >
> >> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> >> ---
> >> v1->v2: defined i2s instance macros in acp header file
> >> v2->v3: sqaushed previous patch series and spilt changes
> >>            into multiple patches (acp dma driver code cleanup
> >>            patches and bt i2s instance specific changes)
> >>     sound/soc/amd/acp-da7219-max98357a.c |  23 ++++
> >>     sound/soc/amd/acp-pcm-dma.c          | 256
> > +++++++++++++++++++++++++++--------
> >>     sound/soc/amd/acp.h                  |  40 ++++++
> >>     3 files changed, 262 insertions(+), 57 deletions(-)
> >
> >> diff --git a/sound/soc/amd/acp-da7219-max98357a.c
> > b/sound/soc/amd/acp-da7219-max98357a.c
> >> index 133139d..b3184ab 100644
> >> --- a/sound/soc/amd/acp-da7219-max98357a.c
> >> +++ b/sound/soc/amd/acp-da7219-max98357a.c
> >> @@ -36,6 +36,7 @@
> >>     #include <linux/input.h>
> >>     #include <linux/acpi.h>
> >
> >> +#include "acp.h"
> >>     #include "../codecs/da7219.h"
> >>     #include "../codecs/da7219-aad.h"
> >
> >> @@ -44,6 +45,7 @@
> >
> >>     static struct snd_soc_jack cz_jack;
> >>     static struct clk *da7219_dai_clk;
> >> +extern int bt_pad_enable;
> >
> > WARNING: externs should be avoided in .c files

> We don't have .h file for machine driver and It can be ignored for
> one variable.
> >
> >
> >>     static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)
> >>     {
> >> @@ -132,6 +134,9 @@ static const struct snd_pcm_hw_constraint_list
> > constraints_channels = {
> >>     static int cz_da7219_startup(struct snd_pcm_substream *substream)
> >>     {
> >>            struct snd_pcm_runtime *runtime = substream->runtime;
> >> +       struct snd_soc_pcm_runtime *rtd = substream->private_data;
> >> +       struct snd_soc_card *card = rtd->card;
> >> +       struct acp_platform_info *machine =
> > snd_soc_card_get_drvdata(card);
> >
> >>            /*
> >>             * On this platform for PCM device we support stereo
> >> @@ -143,6 +148,7 @@ static int cz_da7219_startup(struct
snd_pcm_substream
> > *substream)
> >>            snd_pcm_hw_constraint_list(runtime, 0,
SNDRV_PCM_HW_PARAM_RATE,
> >>                                       &constraints_rates);
> >
> >> +       machine->i2s_instance = I2S_BT_INSTANCE;
> >
> > I'm not a big fan of this approach, but I don't know any other way to
tell
> > a single "platform" driver (acp-pcm-dma) which of two channels (ST/BT)
to
> > use via the pcm_open() callback.
> >
> > Mark, can you recommend any other way of doing this?

> Hi Dan,

> There have been couple of approaches worked upon this earlier.
> 1) To compare cpu dai name to get the I2S instance value in
> acp_dma_open() call.

> But, Mark suggested not to implement this approach as we are comparing
> dynamically generated cpu dai names.

> 2) We added i2s_instance parameter as platform data to dwc driver.
> By querying dwc driver platform data in acp dma driver, current i2s
> instance was programmed in acp_dma_open ().

> But Mark's latest comment was to implement platform specific changes in
> machine driver. Machine driver and Dma driver should exchange the data
> regarding this. We accepted this and current approach is based on the
> same comment.
> Below is the reference.
> https://lkml.org/lkml/2018/4/18/597

Yes, I saw Mark's previous comment, but what we are trying to implement
here is the SoC specific binding between i2s channel and acp-dma channel.
This is a feature of the SoC, not of the i2s controller, but also not a
feature of the audio configuration on the board.  For these SoCs, the link
between DMA registers & I2S-channel is hard-coded.  The machine driver is
already specifying which i2s channel to use when it configures, for
example, '.cpu_dai_name = "designware-i2s.2.auto"'.  The i2s channel
selection already implies a particular DMA configuration.  It seems
redundant to create this separate out-of-band infrastructure to make the
machine driver also tell its platform driver '.platform_name =
"acp_audio_dma.0.auto"' which i2s channel it is using.

Perhaps the acp-pcm-dma.c should register two different platform drivers,
and let the machine driver pick the appropriate one (ie,
acp_audio_dma.0.auto or acp_audio_dma.1.auto) depending on which i2s port
it needs?  Then each of these would have its own
snd_soc_platform_driver->ops->open() that could setup
snd_pcm_runtime->private_data appropriately?  Or is there another standard
way to have a single snd_soc_platform_driver handle multiple channels?

-Dan

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH V3 10/10] ASoC: amd: dma driver changes for bt i2s instance
  2018-05-03 16:40       ` Daniel Kurtz
@ 2018-05-04  4:34         ` Agrawal, Akshu
  2018-05-07  6:44           ` Daniel Kurtz
  0 siblings, 1 reply; 23+ messages in thread
From: Agrawal, Akshu @ 2018-05-04  4:34 UTC (permalink / raw)
  To: Daniel Kurtz, vijendar.mukunda
  Cc: Liam Girdwood, Mark Brown, perex, tiwai, Kuninori Morimoto,
	alexander.deucher, weiyongjun1, jclinton, Guenter Roeck,
	Greg Kroah-Hartman, Kate Stewart, alsa-devel, linux-kernel



On 5/3/2018 10:10 PM, Daniel Kurtz wrote:
> On Thu, May 3, 2018 at 1:33 AM Mukunda,Vijendar <vijendar.mukunda@amd.com>
> wrote:
> 
> 
> 
>> On Thursday 03 May 2018 11:13 AM, Daniel Kurtz wrote:
>>> Some checkpatch nits below...
>>>
>>> On Tue, May 1, 2018 at 2:53 PM Vijendar Mukunda <
> Vijendar.Mukunda@amd.com>
>>> wrote:
>>>
>>>> With in ACP, There are three I2S controllers can be
>>>> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
>>>> Default enabled I2S controller instance is I2S SP.
>>>> This patch provides required changes to support I2S BT
>>>> controller Instance.
>>>
>>>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>>>> ---
>>>> v1->v2: defined i2s instance macros in acp header file
>>>> v2->v3: sqaushed previous patch series and spilt changes
>>>>             into multiple patches (acp dma driver code cleanup
>>>>             patches and bt i2s instance specific changes)
>>>>      sound/soc/amd/acp-da7219-max98357a.c |  23 ++++
>>>>      sound/soc/amd/acp-pcm-dma.c          | 256
>>> +++++++++++++++++++++++++++--------
>>>>      sound/soc/amd/acp.h                  |  40 ++++++
>>>>      3 files changed, 262 insertions(+), 57 deletions(-)
>>>
>>>> diff --git a/sound/soc/amd/acp-da7219-max98357a.c
>>> b/sound/soc/amd/acp-da7219-max98357a.c
>>>> index 133139d..b3184ab 100644
>>>> --- a/sound/soc/amd/acp-da7219-max98357a.c
>>>> +++ b/sound/soc/amd/acp-da7219-max98357a.c
>>>> @@ -36,6 +36,7 @@
>>>>      #include <linux/input.h>
>>>>      #include <linux/acpi.h>
>>>
>>>> +#include "acp.h"
>>>>      #include "../codecs/da7219.h"
>>>>      #include "../codecs/da7219-aad.h"
>>>
>>>> @@ -44,6 +45,7 @@
>>>
>>>>      static struct snd_soc_jack cz_jack;
>>>>      static struct clk *da7219_dai_clk;
>>>> +extern int bt_pad_enable;
>>>
>>> WARNING: externs should be avoided in .c files
> 
>> We don't have .h file for machine driver and It can be ignored for
>> one variable.
>>>
>>>
>>>>      static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)
>>>>      {
>>>> @@ -132,6 +134,9 @@ static const struct snd_pcm_hw_constraint_list
>>> constraints_channels = {
>>>>      static int cz_da7219_startup(struct snd_pcm_substream *substream)
>>>>      {
>>>>             struct snd_pcm_runtime *runtime = substream->runtime;
>>>> +       struct snd_soc_pcm_runtime *rtd = substream->private_data;
>>>> +       struct snd_soc_card *card = rtd->card;
>>>> +       struct acp_platform_info *machine =
>>> snd_soc_card_get_drvdata(card);
>>>
>>>>             /*
>>>>              * On this platform for PCM device we support stereo
>>>> @@ -143,6 +148,7 @@ static int cz_da7219_startup(struct
> snd_pcm_substream
>>> *substream)
>>>>             snd_pcm_hw_constraint_list(runtime, 0,
> SNDRV_PCM_HW_PARAM_RATE,
>>>>                                        &constraints_rates);
>>>
>>>> +       machine->i2s_instance = I2S_BT_INSTANCE;
>>>
>>> I'm not a big fan of this approach, but I don't know any other way to
> tell
>>> a single "platform" driver (acp-pcm-dma) which of two channels (ST/BT)
> to
>>> use via the pcm_open() callback.
>>>
>>> Mark, can you recommend any other way of doing this?
> 
>> Hi Dan,
> 
>> There have been couple of approaches worked upon this earlier.
>> 1) To compare cpu dai name to get the I2S instance value in
>> acp_dma_open() call.
> 
>> But, Mark suggested not to implement this approach as we are comparing
>> dynamically generated cpu dai names.
> 
>> 2) We added i2s_instance parameter as platform data to dwc driver.
>> By querying dwc driver platform data in acp dma driver, current i2s
>> instance was programmed in acp_dma_open ().
> 
>> But Mark's latest comment was to implement platform specific changes in
>> machine driver. Machine driver and Dma driver should exchange the data
>> regarding this. We accepted this and current approach is based on the
>> same comment.
>> Below is the reference.
>> https://lkml.org/lkml/2018/4/18/597
> 
> Yes, I saw Mark's previous comment, but what we are trying to implement
> here is the SoC specific binding between i2s channel and acp-dma channel.
> This is a feature of the SoC, not of the i2s controller, but also not a
> feature of the audio configuration on the board.
The binding of channel and dma is soc specific but codec to channel is 
board specific.
These linkages can change from one board to another. Machine driver is 
specific to a board (grunt here) and dma driver being common for various 
boards (but specific to a platform like ST/CZ here). Tomorrow there can 
be some other board with x codec linked to BT and y to SP.
Hence, machine driver should send this board specific link information 
to dma driver for it to dma on the correct channel as per the board.
   For these SoCs, the link
> between DMA registers & I2S-channel is hard-coded.  The machine driver is
> already specifying which i2s channel to use when it configures, for
> example, '.cpu_dai_name = "designware-i2s.2.auto"'.  The i2s channel
> selection already implies a particular DMA configuration.  It seems
> redundant to create this separate out-of-band infrastructure to make the
> machine driver also tell its platform driver '.platform_name =
> "acp_audio_dma.0.auto"' which i2s channel it is using.
> 

We could have decided on the basis of "cpu_dai_name" but the decision 
would have been based on dynamically generated name. Though maybe 
redundant in nature, but machine driver is just sending info to dma 
driver that this codec is playing so play on this instance.

> Perhaps the acp-pcm-dma.c should register two different platform drivers,
> and let the machine driver pick the appropriate one (ie,
> acp_audio_dma.0.auto or acp_audio_dma.1.auto) depending on which i2s port
> it needs?  Then each of these would have its own
> snd_soc_platform_driver->ops->open() that could setup
> snd_pcm_runtime->private_data appropriately?

I guess it would be overkill to have 2 platform drivers one for each 
instance but actually for a single platform.

   Or is there another standard
> way to have a single snd_soc_platform_driver handle multiple channels?
> 

Don't know if there is a standard but would be interesting to know how 
other platforms handle multiple instances.

Thanks,
Akshu
> -Dan
> 

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH V2 01/10] ASoC: amd: dma config parameters changes
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
                   ` (8 preceding siblings ...)
  2018-05-01 20:50 ` [PATCH V3 10/10] ASoC: amd: dma driver changes for bt i2s instance Vijendar Mukunda
@ 2018-05-07  6:27 ` Mukunda,Vijendar
  2018-05-07 10:22   ` Mukunda,Vijendar
  2018-05-11  3:20 ` Applied "ASoC: amd: dma config parameters changes" to the asoc tree Mark Brown
  10 siblings, 1 reply; 23+ messages in thread
From: Mukunda,Vijendar @ 2018-05-07  6:27 UTC (permalink / raw)
  To: Mark Brown
  Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Alex Deucher,
	Jason Clinton, Akshu Agrawal, Guenter Roeck, Kuninori Morimoto,
	Philippe Ombredanne, Kate Stewart, Greg Kroah-Hartman,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list, djkurtz



On Wednesday 02 May 2018 02:19 AM, Vijendar Mukunda wrote:
> Added dma configuration parameters to rtd structure.
> Moved dma configuration parameters initialization to
> hw_params callback.
> Removed hard coding in prepare and trigger callbacks.
> 
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> v1->v2 : Fixed capture stream wrong channel assignment
> 	 added comments in dma trigger api
>   sound/soc/amd/acp-pcm-dma.c | 103 ++++++++++++++++++--------------------------
>   sound/soc/amd/acp.h         |   5 +++
>   2 files changed, 48 insertions(+), 60 deletions(-)

Hi Mark,

In this series, patches 01/10 to 09/10 are good to go from Dan, could 
you please review and merge them.

For 10/10 please let us know your thoughts on it, discussion reference:
https://lkml.org/lkml/2018/5/4/23

Thanks,
Vijendar

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH V3 10/10] ASoC: amd: dma driver changes for bt i2s instance
  2018-05-04  4:34         ` Agrawal, Akshu
@ 2018-05-07  6:44           ` Daniel Kurtz
  0 siblings, 0 replies; 23+ messages in thread
From: Daniel Kurtz @ 2018-05-07  6:44 UTC (permalink / raw)
  To: Akshu Agrawal
  Cc: vijendar.mukunda, Liam Girdwood, Mark Brown, perex, tiwai,
	Kuninori Morimoto, alexander.deucher, weiyongjun1, jclinton,
	Guenter Roeck, Greg Kroah-Hartman, Kate Stewart, alsa-devel,
	linux-kernel

On Thu, May 3, 2018 at 10:35 PM Agrawal, Akshu <Akshu.Agrawal@amd.com>
wrote:



> On 5/3/2018 10:10 PM, Daniel Kurtz wrote:
> > On Thu, May 3, 2018 at 1:33 AM Mukunda,Vijendar <
vijendar.mukunda@amd.com>
> > wrote:
> >
> >
> >
> >> On Thursday 03 May 2018 11:13 AM, Daniel Kurtz wrote:
> >>> Some checkpatch nits below...
> >>>
> >>> On Tue, May 1, 2018 at 2:53 PM Vijendar Mukunda <
> > Vijendar.Mukunda@amd.com>
> >>> wrote:
> >>>
> >>>> With in ACP, There are three I2S controllers can be
> >>>> configured/enabled ( I2S SP, I2S MICSP, I2S BT).
> >>>> Default enabled I2S controller instance is I2S SP.
> >>>> This patch provides required changes to support I2S BT
> >>>> controller Instance.
> >>>
> >>>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> >>>> ---
> >>>> v1->v2: defined i2s instance macros in acp header file
> >>>> v2->v3: sqaushed previous patch series and spilt changes
> >>>>             into multiple patches (acp dma driver code cleanup
> >>>>             patches and bt i2s instance specific changes)
> >>>>      sound/soc/amd/acp-da7219-max98357a.c |  23 ++++
> >>>>      sound/soc/amd/acp-pcm-dma.c          | 256
> >>> +++++++++++++++++++++++++++--------
> >>>>      sound/soc/amd/acp.h                  |  40 ++++++
> >>>>      3 files changed, 262 insertions(+), 57 deletions(-)
> >>>
> >>>> diff --git a/sound/soc/amd/acp-da7219-max98357a.c
> >>> b/sound/soc/amd/acp-da7219-max98357a.c
> >>>> index 133139d..b3184ab 100644
> >>>> --- a/sound/soc/amd/acp-da7219-max98357a.c
> >>>> +++ b/sound/soc/amd/acp-da7219-max98357a.c
> >>>> @@ -36,6 +36,7 @@
> >>>>      #include <linux/input.h>
> >>>>      #include <linux/acpi.h>
> >>>
> >>>> +#include "acp.h"
> >>>>      #include "../codecs/da7219.h"
> >>>>      #include "../codecs/da7219-aad.h"
> >>>
> >>>> @@ -44,6 +45,7 @@
> >>>
> >>>>      static struct snd_soc_jack cz_jack;
> >>>>      static struct clk *da7219_dai_clk;
> >>>> +extern int bt_pad_enable;
> >>>
> >>> WARNING: externs should be avoided in .c files
> >
> >> We don't have .h file for machine driver and It can be ignored for
> >> one variable.
> >>>
> >>>
> >>>>      static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)
> >>>>      {
> >>>> @@ -132,6 +134,9 @@ static const struct snd_pcm_hw_constraint_list
> >>> constraints_channels = {
> >>>>      static int cz_da7219_startup(struct snd_pcm_substream
*substream)
> >>>>      {
> >>>>             struct snd_pcm_runtime *runtime = substream->runtime;
> >>>> +       struct snd_soc_pcm_runtime *rtd = substream->private_data;
> >>>> +       struct snd_soc_card *card = rtd->card;
> >>>> +       struct acp_platform_info *machine =
> >>> snd_soc_card_get_drvdata(card);
> >>>
> >>>>             /*
> >>>>              * On this platform for PCM device we support stereo
> >>>> @@ -143,6 +148,7 @@ static int cz_da7219_startup(struct
> > snd_pcm_substream
> >>> *substream)
> >>>>             snd_pcm_hw_constraint_list(runtime, 0,
> > SNDRV_PCM_HW_PARAM_RATE,
> >>>>                                        &constraints_rates);
> >>>
> >>>> +       machine->i2s_instance = I2S_BT_INSTANCE;
> >>>
> >>> I'm not a big fan of this approach, but I don't know any other way to
> > tell
> >>> a single "platform" driver (acp-pcm-dma) which of two channels (ST/BT)
> > to
> >>> use via the pcm_open() callback.
> >>>
> >>> Mark, can you recommend any other way of doing this?
> >
> >> Hi Dan,
> >
> >> There have been couple of approaches worked upon this earlier.
> >> 1) To compare cpu dai name to get the I2S instance value in
> >> acp_dma_open() call.
> >
> >> But, Mark suggested not to implement this approach as we are comparing
> >> dynamically generated cpu dai names.
> >
> >> 2) We added i2s_instance parameter as platform data to dwc driver.
> >> By querying dwc driver platform data in acp dma driver, current i2s
> >> instance was programmed in acp_dma_open ().
> >
> >> But Mark's latest comment was to implement platform specific changes in
> >> machine driver. Machine driver and Dma driver should exchange the data
> >> regarding this. We accepted this and current approach is based on the
> >> same comment.
> >> Below is the reference.
> >> https://lkml.org/lkml/2018/4/18/597
> >
> > Yes, I saw Mark's previous comment, but what we are trying to implement
> > here is the SoC specific binding between i2s channel and acp-dma
channel.
> > This is a feature of the SoC, not of the i2s controller, but also not a
> > feature of the audio configuration on the board.
> The binding of channel and dma is soc specific but codec to channel is
> board specific.
> These linkages can change from one board to another. Machine driver is
> specific to a board (grunt here) and dma driver being common for various
> boards (but specific to a platform like ST/CZ here). Tomorrow there can
> be some other board with x codec linked to BT and y to SP.
> Hence, machine driver should send this board specific link information
> to dma driver for it to dma on the correct channel as per the board.
>     For these SoCs, the link
> > between DMA registers & I2S-channel is hard-coded.  The machine driver
is
> > already specifying which i2s channel to use when it configures, for
> > example, '.cpu_dai_name = "designware-i2s.2.auto"'.  The i2s channel
> > selection already implies a particular DMA configuration.  It seems
> > redundant to create this separate out-of-band infrastructure to make the
> > machine driver also tell its platform driver '.platform_name =
> > "acp_audio_dma.0.auto"' which i2s channel it is using.
> >

> We could have decided on the basis of "cpu_dai_name" but the decision
> would have been based on dynamically generated name. Though maybe
> redundant in nature, but machine driver is just sending info to dma
> driver that this codec is playing so play on this instance.

> > Perhaps the acp-pcm-dma.c should register two different platform
drivers,
> > and let the machine driver pick the appropriate one (ie,
> > acp_audio_dma.0.auto or acp_audio_dma.1.auto) depending on which i2s
port
> > it needs?  Then each of these would have its own
> > snd_soc_platform_driver->ops->open() that could setup
> > snd_pcm_runtime->private_data appropriately?

> I guess it would be overkill to have 2 platform drivers one for each
> instance but actually for a single platform.

>     Or is there another standard
> > way to have a single snd_soc_platform_driver handle multiple channels?
> >

> Don't know if there is a standard but would be interesting to know how
> other platforms handle multiple instances.


Hmm, there may be another way that we don't see yet, but in any case, I see
no harm in merging this patch set as is.
So, for the series, feel free to add:

Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>



> Thanks,
> Akshu
> > -Dan
> >

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH V2 01/10] ASoC: amd: dma config parameters changes
  2018-05-07  6:27 ` [PATCH V2 01/10] ASoC: amd: dma config parameters changes Mukunda,Vijendar
@ 2018-05-07 10:22   ` Mukunda,Vijendar
  0 siblings, 0 replies; 23+ messages in thread
From: Mukunda,Vijendar @ 2018-05-07 10:22 UTC (permalink / raw)
  To: Mark Brown
  Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Alex Deucher,
	Jason Clinton, Akshu Agrawal, Guenter Roeck, Kuninori Morimoto,
	Philippe Ombredanne, Kate Stewart, Greg Kroah-Hartman,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list, djkurtz



On Monday 07 May 2018 11:57 AM, Mukunda,Vijendar wrote:
> 
> 
> On Wednesday 02 May 2018 02:19 AM, Vijendar Mukunda wrote:
>> Added dma configuration parameters to rtd structure.
>> Moved dma configuration parameters initialization to
>> hw_params callback.
>> Removed hard coding in prepare and trigger callbacks.
>>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> ---
>> v1->v2 : Fixed capture stream wrong channel assignment
>>      added comments in dma trigger api
>>   sound/soc/amd/acp-pcm-dma.c | 103 
>> ++++++++++++++++++--------------------------
>>   sound/soc/amd/acp.h         |   5 +++
>>   2 files changed, 48 insertions(+), 60 deletions(-)
> 
> Hi Mark,
> 
> In this series, patches 01/10 to 09/10 are good to go from Dan, could 
> you please review and merge them.
> 
> For 10/10 please let us know your thoughts on it, discussion reference:
> https://lkml.org/lkml/2018/5/4/23
> 
> Thanks,
> Vijendar


Hi Mark,

After comment from Dan on 10/10 , re-spinning the patch series by
adding Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

Thanks,
Vijendar

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Applied "ASoC: amd: removed separate byte count variables for playback and capture" to the asoc tree
  2018-05-01 20:49 ` [PATCH V2 03/10] ASoC: amd: removed separate byte count variables for playback and capture Vijendar Mukunda
@ 2018-05-11  3:19   ` Mark Brown
  0 siblings, 0 replies; 23+ messages in thread
From: Mark Brown @ 2018-05-11  3:19 UTC (permalink / raw)
  To: Vijendar Mukunda
  Cc: Mark Brown, ,
	moderated list:SOUND - SOC,
	LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list, Kuninori Morimoto, Liam Girdwood, Greg Kroah-Hartman,
	Philippe Ombredanne, Takashi Iwai, Jason Clinton, Mark Brown,
	Alex Deucher, Thomas Gleixner, Akshu Agrawal, Guenter Roeck,
	alsa-devel

The patch

   ASoC: amd: removed separate byte count variables for playback and capture

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 9af8937e5589693f888e855b052dde5c45fb4a1f Mon Sep 17 00:00:00 2001
From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Date: Tue, 8 May 2018 10:17:46 +0530
Subject: [PATCH] ASoC: amd: removed separate byte count variables for playback
 and capture

Removed separate byte count variables for playback and capture.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/amd/acp-pcm-dma.c | 19 +++++--------------
 sound/soc/amd/acp.h         |  3 +--
 2 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index 3dc3de1040a4..e6d59f47ed00 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -866,13 +866,8 @@ static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream)
 	buffersize = frames_to_bytes(runtime, runtime->buffer_size);
 	bytescount = acp_get_byte_count(rtd);
 
-	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		if (bytescount > rtd->i2ssp_renderbytescount)
-			bytescount = bytescount - rtd->i2ssp_renderbytescount;
-	} else {
-		if (bytescount > rtd->i2ssp_capturebytescount)
-			bytescount = bytescount - rtd->i2ssp_capturebytescount;
-	}
+	if (bytescount > rtd->bytescount)
+		bytescount -= rtd->bytescount;
 	pos = do_div(bytescount, buffersize);
 	return bytes_to_frames(runtime, pos);
 }
@@ -921,9 +916,9 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
 	case SNDRV_PCM_TRIGGER_RESUME:
 		bytescount = acp_get_byte_count(rtd);
+		if (rtd->bytescount == 0)
+			rtd->bytescount = bytescount;
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-			if (rtd->i2ssp_renderbytescount == 0)
-				rtd->i2ssp_renderbytescount = bytescount;
 			acp_dma_start(rtd->acp_mmio, rtd->ch1, false);
 			while (acp_reg_read(rtd->acp_mmio, mmACP_DMA_CH_STS) &
 				BIT(rtd->ch1)) {
@@ -934,9 +929,6 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 				}
 				cpu_relax();
 			}
-		} else {
-			if (rtd->i2ssp_capturebytescount == 0)
-				rtd->i2ssp_capturebytescount = bytescount;
 		}
 		acp_dma_start(rtd->acp_mmio, rtd->ch2, true);
 		ret = 0;
@@ -955,12 +947,11 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 			acp_dma_stop(rtd->acp_mmio, rtd->ch1);
 			ret =  acp_dma_stop(rtd->acp_mmio, rtd->ch2);
-			rtd->i2ssp_renderbytescount = 0;
 		} else {
 			acp_dma_stop(rtd->acp_mmio, rtd->ch2);
 			ret = acp_dma_stop(rtd->acp_mmio, rtd->ch1);
-			rtd->i2ssp_capturebytescount = 0;
 		}
+		rtd->bytescount = 0;
 		break;
 	default:
 		ret = -EINVAL;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 3b076c6a0ae2..82470bc710f0 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -93,8 +93,7 @@ struct audio_substream_data {
 	u32 byte_cnt_high_reg_offset;
 	u32 byte_cnt_low_reg_offset;
 	uint64_t size;
-	u64 i2ssp_renderbytescount;
-	u64 i2ssp_capturebytescount;
+	u64 bytescount;
 	void __iomem *acp_mmio;
 };
 
-- 
2.17.0

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Applied "ASoC: amd: added byte count register offset variables to rtd" to the asoc tree
  2018-05-01 20:49 ` [PATCH V2 02/10] ASoC: amd: added byte count register offset variables to rtd Vijendar Mukunda
@ 2018-05-11  3:20   ` Mark Brown
  0 siblings, 0 replies; 23+ messages in thread
From: Mark Brown @ 2018-05-11  3:20 UTC (permalink / raw)
  To: Vijendar Mukunda
  Cc: Mark Brown, ,
	Kate Stewart, moderated list:SOUND - SOC LAYER / DYNAMIC,
	AUDIO POWER MANAGEM...,
	open list, Kuninori Morimoto, Liam Girdwood, Greg Kroah-Hartman,
	Takashi Iwai, Jason Clinton, Mark Brown, Alex Deucher,
	Akshu Agrawal, Guenter Roeck, alsa-devel

The patch

   ASoC: amd: added byte count register offset variables to rtd

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 7f0048478470046c9efc956c6100b70836ac9f97 Mon Sep 17 00:00:00 2001
From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Date: Tue, 8 May 2018 10:17:45 +0530
Subject: [PATCH] ASoC: amd: added byte count register offset variables to rtd

Added byte count register offset variables to audio_substream_data
structure. Modified dma pointer callback.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/amd/acp-pcm-dma.c | 36 +++++++++++++++---------------------
 sound/soc/amd/acp.h         |  2 ++
 2 files changed, 17 insertions(+), 21 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index fa451d0408b4..3dc3de1040a4 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -793,12 +793,18 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 		rtd->destination = TO_ACP_I2S_1;
 		rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
 		rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
+		rtd->byte_cnt_high_reg_offset =
+				mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
+		rtd->byte_cnt_low_reg_offset = mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
 	} else {
 		rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
 		rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
 		rtd->destination = FROM_ACP_I2S_1;
 		rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14;
 		rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15;
+		rtd->byte_cnt_high_reg_offset =
+				mmACP_I2S_RECEIVED_BYTE_CNT_HIGH;
+		rtd->byte_cnt_low_reg_offset = mmACP_I2S_RECEIVED_BYTE_CNT_LOW;
 	}
 
 	size = params_buffer_bytes(params);
@@ -834,26 +840,15 @@ static int acp_dma_hw_free(struct snd_pcm_substream *substream)
 	return snd_pcm_lib_free_pages(substream);
 }
 
-static u64 acp_get_byte_count(void __iomem *acp_mmio, int stream)
+static u64 acp_get_byte_count(struct audio_substream_data *rtd)
 {
-	union acp_dma_count playback_dma_count;
-	union acp_dma_count capture_dma_count;
-	u64 bytescount = 0;
+	union acp_dma_count byte_count;
 
-	if (stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		playback_dma_count.bcount.high = acp_reg_read(acp_mmio,
-					mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH);
-		playback_dma_count.bcount.low  = acp_reg_read(acp_mmio,
-					mmACP_I2S_TRANSMIT_BYTE_CNT_LOW);
-		bytescount = playback_dma_count.bytescount;
-	} else {
-		capture_dma_count.bcount.high = acp_reg_read(acp_mmio,
-					mmACP_I2S_RECEIVED_BYTE_CNT_HIGH);
-		capture_dma_count.bcount.low  = acp_reg_read(acp_mmio,
-					mmACP_I2S_RECEIVED_BYTE_CNT_LOW);
-		bytescount = capture_dma_count.bytescount;
-	}
-	return bytescount;
+	byte_count.bcount.high = acp_reg_read(rtd->acp_mmio,
+					      rtd->byte_cnt_high_reg_offset);
+	byte_count.bcount.low  = acp_reg_read(rtd->acp_mmio,
+					      rtd->byte_cnt_low_reg_offset);
+	return byte_count.bytescount;
 }
 
 static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream)
@@ -869,7 +864,7 @@ static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream)
 		return -EINVAL;
 
 	buffersize = frames_to_bytes(runtime, runtime->buffer_size);
-	bytescount = acp_get_byte_count(rtd->acp_mmio, substream->stream);
+	bytescount = acp_get_byte_count(rtd);
 
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 		if (bytescount > rtd->i2ssp_renderbytescount)
@@ -925,8 +920,7 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 	case SNDRV_PCM_TRIGGER_START:
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
 	case SNDRV_PCM_TRIGGER_RESUME:
-		bytescount = acp_get_byte_count(rtd->acp_mmio,
-						substream->stream);
+		bytescount = acp_get_byte_count(rtd);
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 			if (rtd->i2ssp_renderbytescount == 0)
 				rtd->i2ssp_renderbytescount = bytescount;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 5e25428e6bbe..3b076c6a0ae2 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -90,6 +90,8 @@ struct audio_substream_data {
 	u16 destination;
 	u16 dma_dscr_idx_1;
 	u16 dma_dscr_idx_2;
+	u32 byte_cnt_high_reg_offset;
+	u32 byte_cnt_low_reg_offset;
 	uint64_t size;
 	u64 i2ssp_renderbytescount;
 	u64 i2ssp_capturebytescount;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Applied "ASoC: amd: dma config parameters changes" to the asoc tree
  2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
                   ` (9 preceding siblings ...)
  2018-05-07  6:27 ` [PATCH V2 01/10] ASoC: amd: dma config parameters changes Mukunda,Vijendar
@ 2018-05-11  3:20 ` Mark Brown
  10 siblings, 0 replies; 23+ messages in thread
From: Mark Brown @ 2018-05-11  3:20 UTC (permalink / raw)
  To: Vijendar Mukunda
  Cc: Mark Brown, ,
	Kate Stewart, moderated list:SOUND - SOC,
	LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list, Kuninori Morimoto, Liam Girdwood, Greg Kroah-Hartman,
	Philippe Ombredanne, Takashi Iwai, Jason Clinton, Mark Brown,
	Alex Deucher, Akshu Agrawal, Guenter Roeck, alsa-devel

The patch

   ASoC: amd: dma config parameters changes

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 8769bb55fe1d9912c9cd9e008afb14e22a762103 Mon Sep 17 00:00:00 2001
From: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Date: Tue, 8 May 2018 10:17:44 +0530
Subject: [PATCH] ASoC: amd: dma config parameters changes

Added dma configuration parameters to rtd structure.
Moved dma configuration parameters initialization to
hw_params callback.
Removed hard coding in prepare and trigger callbacks.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/amd/acp-pcm-dma.c | 103 +++++++++++++++---------------------
 sound/soc/amd/acp.h         |   5 ++
 2 files changed, 48 insertions(+), 60 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index 2b9a020e0b3e..fa451d0408b4 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -321,19 +321,12 @@ static void config_acp_dma(void __iomem *acp_mmio,
 			   u32 asic_type)
 {
 	u32 pte_offset, sram_bank;
-	u16 ch1, ch2, destination, dma_dscr_idx;
 
 	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK) {
 		pte_offset = ACP_PLAYBACK_PTE_OFFSET;
-		ch1 = SYSRAM_TO_ACP_CH_NUM;
-		ch2 = ACP_TO_I2S_DMA_CH_NUM;
 		sram_bank = ACP_SHARED_RAM_BANK_1_ADDRESS;
-		destination = TO_ACP_I2S_1;
-
 	} else {
 		pte_offset = ACP_CAPTURE_PTE_OFFSET;
-		ch1 = SYSRAM_TO_ACP_CH_NUM;
-		ch2 = ACP_TO_I2S_DMA_CH_NUM;
 		switch (asic_type) {
 		case CHIP_STONEY:
 			sram_bank = ACP_SHARED_RAM_BANK_3_ADDRESS;
@@ -341,30 +334,19 @@ static void config_acp_dma(void __iomem *acp_mmio,
 		default:
 			sram_bank = ACP_SHARED_RAM_BANK_5_ADDRESS;
 		}
-		destination = FROM_ACP_I2S_1;
 	}
-
 	acp_pte_config(acp_mmio, rtd->pg, rtd->num_of_pages,
 		       pte_offset);
-	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK)
-		dma_dscr_idx = PLAYBACK_START_DMA_DESCR_CH12;
-	else
-		dma_dscr_idx = CAPTURE_START_DMA_DESCR_CH14;
-
 	/* Configure System memory <-> ACP SRAM DMA descriptors */
 	set_acp_sysmem_dma_descriptors(acp_mmio, rtd->size,
-				       rtd->direction, pte_offset, ch1,
-				       sram_bank, dma_dscr_idx, asic_type);
-
-	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK)
-		dma_dscr_idx = PLAYBACK_START_DMA_DESCR_CH13;
-	else
-		dma_dscr_idx = CAPTURE_START_DMA_DESCR_CH15;
+				       rtd->direction, pte_offset,
+				       rtd->ch1, sram_bank,
+				       rtd->dma_dscr_idx_1, asic_type);
 	/* Configure ACP SRAM <-> I2S DMA descriptors */
 	set_acp_to_i2s_dma_descriptors(acp_mmio, rtd->size,
 				       rtd->direction, sram_bank,
-				       destination, ch2, dma_dscr_idx,
-				       asic_type);
+				       rtd->destination, rtd->ch2,
+				       rtd->dma_dscr_idx_2, asic_type);
 }
 
 /* Start a given DMA channel transfer */
@@ -804,6 +786,21 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 		acp_reg_write(val, adata->acp_mmio,
 			      mmACP_I2S_16BIT_RESOLUTION_EN);
 	}
+
+	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+		rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
+		rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
+		rtd->destination = TO_ACP_I2S_1;
+		rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
+		rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
+	} else {
+		rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
+		rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
+		rtd->destination = FROM_ACP_I2S_1;
+		rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14;
+		rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15;
+	}
+
 	size = params_buffer_bytes(params);
 	status = snd_pcm_lib_malloc_pages(substream, size);
 	if (status < 0)
@@ -898,21 +895,15 @@ static int acp_dma_prepare(struct snd_pcm_substream *substream)
 
 	if (!rtd)
 		return -EINVAL;
-	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		config_acp_dma_channel(rtd->acp_mmio, SYSRAM_TO_ACP_CH_NUM,
-				       PLAYBACK_START_DMA_DESCR_CH12,
-				       NUM_DSCRS_PER_CHANNEL, 0);
-		config_acp_dma_channel(rtd->acp_mmio, ACP_TO_I2S_DMA_CH_NUM,
-				       PLAYBACK_START_DMA_DESCR_CH13,
-				       NUM_DSCRS_PER_CHANNEL, 0);
-	} else {
-		config_acp_dma_channel(rtd->acp_mmio, ACP_TO_SYSRAM_CH_NUM,
-				       CAPTURE_START_DMA_DESCR_CH14,
-				       NUM_DSCRS_PER_CHANNEL, 0);
-		config_acp_dma_channel(rtd->acp_mmio, I2S_TO_ACP_DMA_CH_NUM,
-				       CAPTURE_START_DMA_DESCR_CH15,
-				       NUM_DSCRS_PER_CHANNEL, 0);
-	}
+
+	config_acp_dma_channel(rtd->acp_mmio,
+			       rtd->ch1,
+			       rtd->dma_dscr_idx_1,
+			       NUM_DSCRS_PER_CHANNEL, 0);
+	config_acp_dma_channel(rtd->acp_mmio,
+			       rtd->ch2,
+			       rtd->dma_dscr_idx_2,
+			       NUM_DSCRS_PER_CHANNEL, 0);
 	return 0;
 }
 
@@ -939,10 +930,9 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 			if (rtd->i2ssp_renderbytescount == 0)
 				rtd->i2ssp_renderbytescount = bytescount;
-			acp_dma_start(rtd->acp_mmio,
-				      SYSRAM_TO_ACP_CH_NUM, false);
+			acp_dma_start(rtd->acp_mmio, rtd->ch1, false);
 			while (acp_reg_read(rtd->acp_mmio, mmACP_DMA_CH_STS) &
-						BIT(SYSRAM_TO_ACP_CH_NUM)) {
+				BIT(rtd->ch1)) {
 				if (!loops--) {
 					dev_err(component->dev,
 						"acp dma start timeout\n");
@@ -950,38 +940,31 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 				}
 				cpu_relax();
 			}
-
-			acp_dma_start(rtd->acp_mmio,
-				      ACP_TO_I2S_DMA_CH_NUM, true);
-
 		} else {
 			if (rtd->i2ssp_capturebytescount == 0)
 				rtd->i2ssp_capturebytescount = bytescount;
-			acp_dma_start(rtd->acp_mmio,
-				      I2S_TO_ACP_DMA_CH_NUM, true);
 		}
+		acp_dma_start(rtd->acp_mmio, rtd->ch2, true);
 		ret = 0;
 		break;
 	case SNDRV_PCM_TRIGGER_STOP:
 	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
 	case SNDRV_PCM_TRIGGER_SUSPEND:
-		/*
-		 * Need to stop only circular DMA channels :
-		 * ACP_TO_I2S_DMA_CH_NUM / I2S_TO_ACP_DMA_CH_NUM. Non-circular
-		 * channels will stopped automatically after its transfer
-		 * completes : SYSRAM_TO_ACP_CH_NUM / ACP_TO_SYSRAM_CH_NUM
+		/* For playback, non circular dma should be stopped first
+		 * i.e Sysram to acp dma transfer channel(rtd->ch1) should be
+		 * stopped before stopping cirular dma which is acp sram to i2s
+		 * fifo dma transfer channel(rtd->ch2). Where as in Capture
+		 * scenario, i2s fifo to acp sram dma channel(rtd->ch2) stopped
+		 * first before stopping acp sram to sysram which is circular
+		 * dma(rtd->ch1).
 		 */
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-			ret = acp_dma_stop(rtd->acp_mmio,
-					   SYSRAM_TO_ACP_CH_NUM);
-			ret = acp_dma_stop(rtd->acp_mmio,
-					   ACP_TO_I2S_DMA_CH_NUM);
+			acp_dma_stop(rtd->acp_mmio, rtd->ch1);
+			ret =  acp_dma_stop(rtd->acp_mmio, rtd->ch2);
 			rtd->i2ssp_renderbytescount = 0;
 		} else {
-			ret = acp_dma_stop(rtd->acp_mmio,
-					   I2S_TO_ACP_DMA_CH_NUM);
-			ret = acp_dma_stop(rtd->acp_mmio,
-					   ACP_TO_SYSRAM_CH_NUM);
+			acp_dma_stop(rtd->acp_mmio, rtd->ch2);
+			ret = acp_dma_stop(rtd->acp_mmio, rtd->ch1);
 			rtd->i2ssp_capturebytescount = 0;
 		}
 		break;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 0e6089b4f8a0..5e25428e6bbe 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -85,6 +85,11 @@ struct audio_substream_data {
 	unsigned int order;
 	u16 num_of_pages;
 	u16 direction;
+	u16 ch1;
+	u16 ch2;
+	u16 destination;
+	u16 dma_dscr_idx_1;
+	u16 dma_dscr_idx_2;
 	uint64_t size;
 	u64 i2ssp_renderbytescount;
 	u64 i2ssp_capturebytescount;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Applied "ASoC: amd: sram bank update changes" to the asoc tree
  2018-05-01 20:49 ` [PATCH 05/10] ASoC: amd: sram bank update changes Vijendar Mukunda
@ 2018-05-21 15:48   ` Mark Brown
  0 siblings, 0 replies; 23+ messages in thread
From: Mark Brown @ 2018-05-21 15:48 UTC (permalink / raw)
  To: Mukunda, Vijendar
  Cc: Vijendar Mukunda, Mark Brown, ,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list, Kuninori Morimoto, Liam Girdwood, Greg Kroah-Hartman,
	Philippe Ombredanne, Takashi Iwai, Jason Clinton, Mark Brown,
	Vijendar Mukunda, Alex Deucher, Akshu Agrawal, Guenter Roeck,
	alsa-devel

The patch

   ASoC: amd: sram bank update changes

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 18e8a40dd387856e7f7a067dcfecbe644afe6944 Mon Sep 17 00:00:00 2001
From: "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>
Date: Tue, 8 May 2018 10:17:48 +0530
Subject: [PATCH] ASoC: amd: sram bank update changes

Added sram bank variable to audio_substream_data structure.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/amd/acp-pcm-dma.c | 20 +++++---------------
 sound/soc/amd/acp.h         | 20 ++++++++++++++------
 2 files changed, 19 insertions(+), 21 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index a3a7470a54db..39cd54f1b493 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -320,29 +320,16 @@ static void config_acp_dma(void __iomem *acp_mmio,
 			   struct audio_substream_data *rtd,
 			   u32 asic_type)
 {
-	u32 sram_bank;
-
-	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK)
-		sram_bank = ACP_SHARED_RAM_BANK_1_ADDRESS;
-	else {
-		switch (asic_type) {
-		case CHIP_STONEY:
-			sram_bank = ACP_SHARED_RAM_BANK_3_ADDRESS;
-			break;
-		default:
-			sram_bank = ACP_SHARED_RAM_BANK_5_ADDRESS;
-		}
-	}
 	acp_pte_config(acp_mmio, rtd->pg, rtd->num_of_pages,
 		       rtd->pte_offset);
 	/* Configure System memory <-> ACP SRAM DMA descriptors */
 	set_acp_sysmem_dma_descriptors(acp_mmio, rtd->size,
 				       rtd->direction, rtd->pte_offset,
-				       rtd->ch1, sram_bank,
+				       rtd->ch1, rtd->sram_bank,
 				       rtd->dma_dscr_idx_1, asic_type);
 	/* Configure ACP SRAM <-> I2S DMA descriptors */
 	set_acp_to_i2s_dma_descriptors(acp_mmio, rtd->size,
-				       rtd->direction, sram_bank,
+				       rtd->direction, rtd->sram_bank,
 				       rtd->destination, rtd->ch2,
 				       rtd->dma_dscr_idx_2, asic_type);
 }
@@ -795,6 +782,7 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 		}
 		rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
 		rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
+		rtd->sram_bank = ACP_SRAM_BANK_1_ADDRESS;
 		rtd->destination = TO_ACP_I2S_1;
 		rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
 		rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
@@ -805,9 +793,11 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 		switch (adata->asic_type) {
 		case CHIP_STONEY:
 			rtd->pte_offset = ACP_ST_CAPTURE_PTE_OFFSET;
+			rtd->sram_bank = ACP_SRAM_BANK_2_ADDRESS;
 			break;
 		default:
 			rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET;
+			rtd->sram_bank = ACP_SRAM_BANK_5_ADDRESS;
 		}
 		rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
 		rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 2f48d1d25243..62695ede997d 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -19,12 +19,19 @@
 
 #define ACP_PHYSICAL_BASE			0x14000
 
-/* Playback SRAM address (as a destination in dma descriptor) */
-#define ACP_SHARED_RAM_BANK_1_ADDRESS		0x4002000
-
-/* Capture SRAM address (as a source in dma descriptor) */
-#define ACP_SHARED_RAM_BANK_5_ADDRESS		0x400A000
-#define ACP_SHARED_RAM_BANK_3_ADDRESS		0x4006000
+/*
+ * In case of I2S SP controller instance, Stoney uses SRAM bank 1 for
+ * playback and SRAM Bank 2 for capture where as in case of BT I2S
+ * Instance, Stoney uses SRAM Bank 3 for playback & SRAM Bank 4 will
+ * be used for capture. Carrizo uses I2S SP controller instance. SRAM Banks
+ * 1, 2, 3, 4 will be used for playback & SRAM Banks 5, 6, 7, 8 will be used
+ * for capture scenario.
+ */
+#define ACP_SRAM_BANK_1_ADDRESS		0x4002000
+#define ACP_SRAM_BANK_2_ADDRESS		0x4004000
+#define ACP_SRAM_BANK_3_ADDRESS		0x4006000
+#define ACP_SRAM_BANK_4_ADDRESS		0x4008000
+#define ACP_SRAM_BANK_5_ADDRESS		0x400A000
 
 #define ACP_DMA_RESET_TIME			10000
 #define ACP_CLOCK_EN_TIME_OUT_VALUE		0x000000FF
@@ -95,6 +102,7 @@ struct audio_substream_data {
 	u16 dma_dscr_idx_1;
 	u16 dma_dscr_idx_2;
 	u32 pte_offset;
+	u32 sram_bank;
 	u32 byte_cnt_high_reg_offset;
 	u32 byte_cnt_low_reg_offset;
 	uint64_t size;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Applied "ASoC: amd: pte offset related dma driver changes" to the asoc tree
  2018-05-01 20:49 ` [PATCH V2 04/10] ASoC: amd: pte offset related dma driver changes Vijendar Mukunda
@ 2018-05-21 15:48   ` Mark Brown
  0 siblings, 0 replies; 23+ messages in thread
From: Mark Brown @ 2018-05-21 15:48 UTC (permalink / raw)
  To: Mukunda, Vijendar
  Cc: Vijendar Mukunda, Mark Brown, ,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list, Kuninori Morimoto, Liam Girdwood, Greg Kroah-Hartman,
	Philippe Ombredanne, Takashi Iwai, Jason Clinton, Mark Brown,
	Vijendar Mukunda, Alex Deucher, Akshu Agrawal, Guenter Roeck,
	alsa-devel

The patch

   ASoC: amd: pte offset related dma driver changes

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From e188c525b9e193bc5aec97c824bc0cd1a9cb6aeb Mon Sep 17 00:00:00 2001
From: "Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>
Date: Tue, 8 May 2018 10:17:47 +0530
Subject: [PATCH] ASoC: amd: pte offset related dma driver changes

Added pte offset variable in audio_substream_data structure.
Added Stoney related PTE offset macros in acp header file.
Modified hw_params callback to assign the pte offset value
based on asic_type.
PTE Offset macros used to calculate no of PTE entries
need to be programmed when memory allocated for audio buffer.
Depending upon allocated audio buffer size, PTE offset values
will change.
Compared to CZ, Stoney has SRAM memory limitation i.e 48k
It is required to define separate PTE Offset macros for
Stoney.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/amd/acp-pcm-dma.c | 26 +++++++++++++++++++-------
 sound/soc/amd/acp.h         |  5 +++++
 2 files changed, 24 insertions(+), 7 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index e6d59f47ed00..a3a7470a54db 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -320,13 +320,11 @@ static void config_acp_dma(void __iomem *acp_mmio,
 			   struct audio_substream_data *rtd,
 			   u32 asic_type)
 {
-	u32 pte_offset, sram_bank;
+	u32 sram_bank;
 
-	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK) {
-		pte_offset = ACP_PLAYBACK_PTE_OFFSET;
+	if (rtd->direction == SNDRV_PCM_STREAM_PLAYBACK)
 		sram_bank = ACP_SHARED_RAM_BANK_1_ADDRESS;
-	} else {
-		pte_offset = ACP_CAPTURE_PTE_OFFSET;
+	else {
 		switch (asic_type) {
 		case CHIP_STONEY:
 			sram_bank = ACP_SHARED_RAM_BANK_3_ADDRESS;
@@ -336,10 +334,10 @@ static void config_acp_dma(void __iomem *acp_mmio,
 		}
 	}
 	acp_pte_config(acp_mmio, rtd->pg, rtd->num_of_pages,
-		       pte_offset);
+		       rtd->pte_offset);
 	/* Configure System memory <-> ACP SRAM DMA descriptors */
 	set_acp_sysmem_dma_descriptors(acp_mmio, rtd->size,
-				       rtd->direction, pte_offset,
+				       rtd->direction, rtd->pte_offset,
 				       rtd->ch1, sram_bank,
 				       rtd->dma_dscr_idx_1, asic_type);
 	/* Configure ACP SRAM <-> I2S DMA descriptors */
@@ -788,6 +786,13 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 	}
 
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+		switch (adata->asic_type) {
+		case CHIP_STONEY:
+			rtd->pte_offset = ACP_ST_PLAYBACK_PTE_OFFSET;
+			break;
+		default:
+			rtd->pte_offset = ACP_PLAYBACK_PTE_OFFSET;
+		}
 		rtd->ch1 = SYSRAM_TO_ACP_CH_NUM;
 		rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM;
 		rtd->destination = TO_ACP_I2S_1;
@@ -797,6 +802,13 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 				mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
 		rtd->byte_cnt_low_reg_offset = mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
 	} else {
+		switch (adata->asic_type) {
+		case CHIP_STONEY:
+			rtd->pte_offset = ACP_ST_CAPTURE_PTE_OFFSET;
+			break;
+		default:
+			rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET;
+		}
 		rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
 		rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
 		rtd->destination = FROM_ACP_I2S_1;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 82470bc710f0..2f48d1d25243 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -10,6 +10,10 @@
 #define ACP_PLAYBACK_PTE_OFFSET			10
 #define ACP_CAPTURE_PTE_OFFSET			0
 
+/* Playback and Capture Offset for Stoney */
+#define ACP_ST_PLAYBACK_PTE_OFFSET	0x04
+#define ACP_ST_CAPTURE_PTE_OFFSET	0x00
+
 #define ACP_GARLIC_CNTL_DEFAULT			0x00000FB4
 #define ACP_ONION_CNTL_DEFAULT			0x00000FB4
 
@@ -90,6 +94,7 @@ struct audio_substream_data {
 	u16 destination;
 	u16 dma_dscr_idx_1;
 	u16 dma_dscr_idx_2;
+	u32 pte_offset;
 	u32 byte_cnt_high_reg_offset;
 	u32 byte_cnt_low_reg_offset;
 	uint64_t size;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH V2 02/10] ASoC: amd: added byte count register offset variables to rtd
  2018-05-08  4:47 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
@ 2018-05-08  4:47 ` Vijendar Mukunda
  0 siblings, 0 replies; 23+ messages in thread
From: Vijendar Mukunda @ 2018-05-08  4:47 UTC (permalink / raw)
  Cc: Vijendar Mukunda, Liam Girdwood, Mark Brown, Jaroslav Kysela,
	Takashi Iwai, Alex Deucher, Daniel Kurtz, Jason Clinton,
	Akshu Agrawal, Guenter Roeck, Kate Stewart, Greg Kroah-Hartman,
	moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
	open list

Added byte count register offset variables to audio_substream_data
structure. Modified dma pointer callback.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
---
v1->v2: Fixed Indentation issues
 sound/soc/amd/acp-pcm-dma.c | 36 +++++++++++++++---------------------
 sound/soc/amd/acp.h         |  2 ++
 2 files changed, 17 insertions(+), 21 deletions(-)

diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index e9736fe..6e338fe 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -793,12 +793,18 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,
 		rtd->destination = TO_ACP_I2S_1;
 		rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12;
 		rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13;
+		rtd->byte_cnt_high_reg_offset =
+				mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH;
+		rtd->byte_cnt_low_reg_offset = mmACP_I2S_TRANSMIT_BYTE_CNT_LOW;
 	} else {
 		rtd->ch1 = ACP_TO_SYSRAM_CH_NUM;
 		rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM;
 		rtd->destination = FROM_ACP_I2S_1;
 		rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14;
 		rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15;
+		rtd->byte_cnt_high_reg_offset =
+				mmACP_I2S_RECEIVED_BYTE_CNT_HIGH;
+		rtd->byte_cnt_low_reg_offset = mmACP_I2S_RECEIVED_BYTE_CNT_LOW;
 	}
 
 	size = params_buffer_bytes(params);
@@ -834,26 +840,15 @@ static int acp_dma_hw_free(struct snd_pcm_substream *substream)
 	return snd_pcm_lib_free_pages(substream);
 }
 
-static u64 acp_get_byte_count(void __iomem *acp_mmio, int stream)
+static u64 acp_get_byte_count(struct audio_substream_data *rtd)
 {
-	union acp_dma_count playback_dma_count;
-	union acp_dma_count capture_dma_count;
-	u64 bytescount = 0;
+	union acp_dma_count byte_count;
 
-	if (stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		playback_dma_count.bcount.high = acp_reg_read(acp_mmio,
-					mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH);
-		playback_dma_count.bcount.low  = acp_reg_read(acp_mmio,
-					mmACP_I2S_TRANSMIT_BYTE_CNT_LOW);
-		bytescount = playback_dma_count.bytescount;
-	} else {
-		capture_dma_count.bcount.high = acp_reg_read(acp_mmio,
-					mmACP_I2S_RECEIVED_BYTE_CNT_HIGH);
-		capture_dma_count.bcount.low  = acp_reg_read(acp_mmio,
-					mmACP_I2S_RECEIVED_BYTE_CNT_LOW);
-		bytescount = capture_dma_count.bytescount;
-	}
-	return bytescount;
+	byte_count.bcount.high = acp_reg_read(rtd->acp_mmio,
+					      rtd->byte_cnt_high_reg_offset);
+	byte_count.bcount.low  = acp_reg_read(rtd->acp_mmio,
+					      rtd->byte_cnt_low_reg_offset);
+	return byte_count.bytescount;
 }
 
 static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream)
@@ -869,7 +864,7 @@ static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream)
 		return -EINVAL;
 
 	buffersize = frames_to_bytes(runtime, runtime->buffer_size);
-	bytescount = acp_get_byte_count(rtd->acp_mmio, substream->stream);
+	bytescount = acp_get_byte_count(rtd);
 
 	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 		if (bytescount > rtd->i2ssp_renderbytescount)
@@ -925,8 +920,7 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)
 	case SNDRV_PCM_TRIGGER_START:
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
 	case SNDRV_PCM_TRIGGER_RESUME:
-		bytescount = acp_get_byte_count(rtd->acp_mmio,
-						substream->stream);
+		bytescount = acp_get_byte_count(rtd);
 		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
 			if (rtd->i2ssp_renderbytescount == 0)
 				rtd->i2ssp_renderbytescount = bytescount;
diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h
index 5e25428..3b076c6 100644
--- a/sound/soc/amd/acp.h
+++ b/sound/soc/amd/acp.h
@@ -90,6 +90,8 @@ struct audio_substream_data {
 	u16 destination;
 	u16 dma_dscr_idx_1;
 	u16 dma_dscr_idx_2;
+	u32 byte_cnt_high_reg_offset;
+	u32 byte_cnt_low_reg_offset;
 	uint64_t size;
 	u64 i2ssp_renderbytescount;
 	u64 i2ssp_capturebytescount;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2018-05-21 15:48 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-01 20:49 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
2018-05-01 20:49 ` [PATCH V2 02/10] ASoC: amd: added byte count register offset variables to rtd Vijendar Mukunda
2018-05-11  3:20   ` Applied "ASoC: amd: added byte count register offset variables to rtd" to the asoc tree Mark Brown
2018-05-01 20:49 ` [PATCH V2 03/10] ASoC: amd: removed separate byte count variables for playback and capture Vijendar Mukunda
2018-05-11  3:19   ` Applied "ASoC: amd: removed separate byte count variables for playback and capture" to the asoc tree Mark Brown
2018-05-01 20:49 ` [PATCH V2 04/10] ASoC: amd: pte offset related dma driver changes Vijendar Mukunda
2018-05-21 15:48   ` Applied "ASoC: amd: pte offset related dma driver changes" to the asoc tree Mark Brown
2018-05-01 20:49 ` [PATCH 05/10] ASoC: amd: sram bank update changes Vijendar Mukunda
2018-05-21 15:48   ` Applied "ASoC: amd: sram bank update changes" to the asoc tree Mark Brown
2018-05-01 20:50 ` [PATCH 06/10] ASoC: amd: memory release for rtd structure Vijendar Mukunda
2018-05-01 20:50 ` [PATCH 07/10] ASoC: AMD: Move clk enable from hw_params/free to startup/shutdown Vijendar Mukunda
2018-05-01 20:50 ` [PATCH 08/10] ASoC: AMD: Fix clocks in CZ DA7219 machine driver Vijendar Mukunda
2018-05-01 20:50 ` [PATCH 09/10] ASoC: AMD: Add const to snd_soc_ops instances Vijendar Mukunda
2018-05-01 20:50 ` [PATCH V3 10/10] ASoC: amd: dma driver changes for bt i2s instance Vijendar Mukunda
2018-05-03  5:43   ` Daniel Kurtz
2018-05-03  7:35     ` Mukunda,Vijendar
2018-05-03 16:40       ` Daniel Kurtz
2018-05-04  4:34         ` Agrawal, Akshu
2018-05-07  6:44           ` Daniel Kurtz
2018-05-07  6:27 ` [PATCH V2 01/10] ASoC: amd: dma config parameters changes Mukunda,Vijendar
2018-05-07 10:22   ` Mukunda,Vijendar
2018-05-11  3:20 ` Applied "ASoC: amd: dma config parameters changes" to the asoc tree Mark Brown
2018-05-08  4:47 [PATCH V2 01/10] ASoC: amd: dma config parameters changes Vijendar Mukunda
2018-05-08  4:47 ` [PATCH V2 02/10] ASoC: amd: added byte count register offset variables to rtd Vijendar Mukunda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).