LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Cc: "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Zheng, Joey" <yu.zheng@hxt-semitech.com>
Subject: Re: [PATCH] efi/capsule-loader: Don't output reset log when header flags is not set
Date: Wed, 2 May 2018 01:29:55 +0000	[thread overview]
Message-ID: <1525224594.2901.4.camel@hxt-semitech.com> (raw)
In-Reply-To: <CAKv+Gu89B-E+L2qybT9n5j72c+1vm1az4H9Cp7E71aP3i3VE6A@mail.gmail.com>

Hi, Ard,

On Tue, 2018-05-01 at 11:54 +0200, Ard Biesheuvel wrote:
> On 25 April 2018 at 05:10, Shunyong Yang <shunyong.yang@hxt-semitech.
> com> wrote:
> > 
> > It means firmware attempts to immediately process or launch the
> > capsule
> > when flags in capsule header is not set. Moreover, reset is not
> > needed
> > in this case. Current code will output log to indicate reset.
> > 
> > This patch adds a branch to avoid reset log output when the flags
> > is not
> > set.
> > 
> > Cc: Joey Zheng <yu.zheng@hxt-semitech.com>
> > Signed-off-by: Shunyong Yang <shunyong.yang@hxt-semitech.com>
> > ---
> >  drivers/firmware/efi/capsule-loader.c | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/firmware/efi/capsule-loader.c
> > b/drivers/firmware/efi/capsule-loader.c
> > index e456f4602df1..a63b8e5bde23 100644
> > --- a/drivers/firmware/efi/capsule-loader.c
> > +++ b/drivers/firmware/efi/capsule-loader.c
> > @@ -134,10 +134,15 @@ static ssize_t
> > efi_capsule_submit_update(struct capsule_info *cap_info)
> > 
> >         /* Indicate capsule binary uploading is done */
> >         cap_info->index = NO_FURTHER_WRITE_ACTION;
> > -       pr_info("Successfully upload capsule file with reboot type
> > '%s'\n",
> > -               !cap_info->reset_type ? "RESET_COLD" :
> > -               cap_info->reset_type == 1 ? "RESET_WARM" :
> > -               "RESET_SHUTDOWN");
> > +
> > +       if (cap_info->header.flags)
> You should check for the relevant flag bits here, because the 16
> lower
> bits are platform dependent.
In current three bits in flags, CAPSULE_FLAGS_POPULATE_SYSTEM_TABLE and
CAPSULE_FLAGS_INITIATE_RESET are dependent on
CAPSULE_FLAGS_PERSIST_ACROSS_RESET.

So, maybe I only need to check CAPSULE_FLAGS_PERSIST_ACROSS_RESET?

Thanks.
Shunyong.
> 
> > 
> > +               pr_info("Successfully upload capsule file with
> > reboot type '%s'\n",
> > +                       !cap_info->reset_type ? "RESET_COLD" :
> > +                       cap_info->reset_type == 1 ? "RESET_WARM" :
> > +                       "RESET_SHUTDOWN");
> > +       else
> > +               pr_info("Successfully upload, process and launch
> > capsule file\n");
> > +
> >         return 0;
> >  }
> > 
> > --
> > 1.8.3.1
> > 

  reply	other threads:[~2018-05-02  1:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25  3:10 Shunyong Yang
2018-05-01  9:54 ` Ard Biesheuvel
2018-05-02  1:29   ` Yang, Shunyong [this message]
2018-05-02  7:19     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525224594.2901.4.camel@hxt-semitech.com \
    --to=shunyong.yang@hxt-semitech.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yu.zheng@hxt-semitech.com \
    --subject='Re: [PATCH] efi/capsule-loader: Don'\''t output reset log when header flags is not set' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).