LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3] drm/i915: Disable some extra clang warnings
@ 2018-05-01 18:24 Matthias Kaehlcke
  2018-05-02  9:46 ` Chris Wilson
  0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2018-05-01 18:24 UTC (permalink / raw)
  To: Chris Wilson, Jani Nikula, Rodrigo Vivi, David Airlie
  Cc: intel-gfx, dri-devel, linux-kernel, Guenter Roeck, Matthias Kaehlcke

Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set
warnings to full") enabled extra warnings for i915 to spot possible
bugs in new code, and then disabled a subset of these warnings to keep
the current code building without warnings (with gcc). Enabling the
extra warnings also enabled some additional clang-only warnings, as a
result building i915 with clang currently is extremely noisy. For now
also disable the clang warnings sign-compare, sometimes-uninitialized,
unneeded-internal-declaration and initializer-overrides. If desired
they can be re-enabled after the code has been fixed.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v3:
- don't disable -Wunneeded-internal-declaration , the only occurrence
  can be fixed in the code
- removed 'Fixes' tag, since backporting is not necessary

 drivers/gpu/drm/i915/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 9bee52a949a9..dfe01452c8d1 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -18,6 +18,10 @@ subdir-ccflags-y += $(call cc-disable-warning, type-limits)
 subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)
 subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough)
 subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
+# clang warnings
+subdir-ccflags-y += $(call cc-disable-warning, sign-compare)
+subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized)
+subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides)
 subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
 
 # Fine grained warnings disable
-- 
2.17.0.441.gb46fe60e1d-goog

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] drm/i915: Disable some extra clang warnings
  2018-05-01 18:24 [PATCH v3] drm/i915: Disable some extra clang warnings Matthias Kaehlcke
@ 2018-05-02  9:46 ` Chris Wilson
  2018-05-02 15:39   ` Chris Wilson
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2018-05-02  9:46 UTC (permalink / raw)
  To: Matthias Kaehlcke, Jani Nikula, Rodrigo Vivi, David Airlie
  Cc: intel-gfx, dri-devel, linux-kernel, Guenter Roeck, Matthias Kaehlcke

Quoting Matthias Kaehlcke (2018-05-01 19:24:40)
> Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set
> warnings to full") enabled extra warnings for i915 to spot possible
> bugs in new code, and then disabled a subset of these warnings to keep
> the current code building without warnings (with gcc). Enabling the
> extra warnings also enabled some additional clang-only warnings, as a
> result building i915 with clang currently is extremely noisy. For now
> also disable the clang warnings sign-compare, sometimes-uninitialized,
> unneeded-internal-declaration and initializer-overrides. If desired
> they can be re-enabled after the code has been fixed.
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] drm/i915: Disable some extra clang warnings
  2018-05-02  9:46 ` Chris Wilson
@ 2018-05-02 15:39   ` Chris Wilson
  0 siblings, 0 replies; 3+ messages in thread
From: Chris Wilson @ 2018-05-02 15:39 UTC (permalink / raw)
  To: Matthias Kaehlcke, Jani Nikula, Rodrigo Vivi, David Airlie
  Cc: intel-gfx, dri-devel, linux-kernel, Guenter Roeck, Matthias Kaehlcke

Quoting Chris Wilson (2018-05-02 10:46:07)
> Quoting Matthias Kaehlcke (2018-05-01 19:24:40)
> > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set
> > warnings to full") enabled extra warnings for i915 to spot possible
> > bugs in new code, and then disabled a subset of these warnings to keep
> > the current code building without warnings (with gcc). Enabling the
> > extra warnings also enabled some additional clang-only warnings, as a
> > result building i915 with clang currently is extremely noisy. For now
> > also disable the clang warnings sign-compare, sometimes-uninitialized,
> > unneeded-internal-declaration and initializer-overrides. If desired
> > they can be re-enabled after the code has been fixed.
> > 
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

I've picked this for inclusion and will push shortly.
Thanks for the patch,
-Chris

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-02 15:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-01 18:24 [PATCH v3] drm/i915: Disable some extra clang warnings Matthias Kaehlcke
2018-05-02  9:46 ` Chris Wilson
2018-05-02 15:39   ` Chris Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).