LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Taniya Das <tdas@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Odelu Kukatla <okukatla@codeaurora.org>,
	Amit Nischal <anischal@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Taniya Das <tdas@codeaurora.org>
Subject: Re: [PATCH 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings
Date: Wed, 02 May 2018 08:10:52 -0700	[thread overview]
Message-ID: <152527385298.138124.8046800128520264876@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1525258277-3478-2-git-send-email-tdas@codeaurora.org>

Quoting Taniya Das (2018-05-02 03:51:16)
> Add RPMh clock device bindings for Qualcomm Technology Inc's SoCs. These
> devices would be used for communicating resource state requests to control
> the clocks managed by RPMh.
> 
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> Reviewed-by: Rob Herring <robh@kernel.org>

When you change things you shouldn't keep around reviewed-by tags if it
significantly changes..

> +Example :
> +
> +#include <dt-bindings/clock/qcom,rpmh.h>
> +
> +       &apps_rsc {
> +               rpmhcc: clock-controller {
> +                       compatible = "qcom,sdm845-rpmh-clk";
> +                       #clock-cells = <1>;
> +                       assigned-clocks = <&clock_rpmh RPMH_CXO_CLK>,
> +                                       <&clock_rpmh RPMH_CXO_CLK_A>,
> +                                       <&clock_rpmh RPMH_LN_BB_CLK2>,
> +                                       <&clock_rpmh RPMH_LN_BB_CLK2_A>,
> +                                       <&clock_rpmh RPMH_LN_BB_CLK3>,
> +                                       <&clock_rpmh RPMH_LN_BB_CLK3_A>;
> +                       assigned-clock-parents = <&xo_board_div>,
> +                                               <&xo_board_div>,
> +                                               <&xo_board_div>,
> +                                               <&xo_board_div>,
> +                                               <&xo_board_div>,
> +                                               <&xo_board_div>,

There's only one parent, so assigned-clock-parents doesn't really make
sense. If anything, we would have 'clocks = ' here and specify the xo
board clk and the div 2 clk that live in DT. But I already merged this
binding, two patchsets ago. Please look in clk-next.

> +               };
> +#define RPMH_RF_CLK2                           8
> +#define RPMH_RF_CLK2_A                         9
> +#define RPMH_RF_CLK3                           10
> +#define RPMH_RF_CLK3_A                         11
> +

Ok. I dropped CLK4* from the previous patch you sent and dropped Amit's
signed-off-by.

  reply	other threads:[~2018-05-02 15:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 10:51 [v6 0/2] clk: qcom: clk-rpmh: Add QCOM RPMh clock driver Taniya Das
2018-05-02 10:51 ` [PATCH 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings Taniya Das
2018-05-02 15:10   ` Stephen Boyd [this message]
2018-05-02 10:51 ` [PATCH 2/2] clk: qcom: clk-rpmh: Add QCOM RPMh clock driver Taniya Das
2018-05-02 15:27   ` Stephen Boyd
2018-05-02 15:30   ` Stephen Boyd
2018-05-03 10:33     ` Taniya Das
2018-05-03 17:04       ` Stephen Boyd
2018-05-02 15:12 ` [v6 0/2] " Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152527385298.138124.8046800128520264876@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=anischal@codeaurora.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=okukatla@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=sboyd@codeaurora.org \
    --cc=tdas@codeaurora.org \
    --subject='Re: [PATCH 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).