LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 0/4] enable early printing of hashed pointers
@ 2018-05-02 22:50 Tobin C. Harding
  2018-05-02 22:50 ` [PATCH v2 1/4] random: Fix whitespace pre random-bytes work Tobin C. Harding
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Tobin C. Harding @ 2018-05-02 22:50 UTC (permalink / raw)
  To: linux-kernel
  Cc: Tobin C. Harding, Linus Torvalds, Randy Dunlap, Steven Rostedt,
	Kees Cook, Anna-Maria Gleixner, Andrew Morton, Theodore Ts'o,
	Greg Kroah-Hartman, Arnd Bergmann

Currently if an attempt is made to print a pointer before there is
enough entropy then '(____ptrval____)' is printed.  This makes debugging
stack traces during early boot difficult.

It was observed that we can relax the requirement for cryptographically
secure hashing when debugging while still maintaining pointer hashing
behaviour.  This allows kernels to be debugged without developers
relying on different pointer printing behavior.

Using the hw RNG if available solves this problem for those machines
that have a hardware RNG, we would like to solve it for _all_ machines.

Patch 1 - Whitespace fixes.
Patch 2 - Fix get_random_bytes_arch()
Patch 3 - Use hw RNG for pointer hashing if available (by default).
Patch 4 - Use insecure hashing with command line option 'debug_early_boot'

Ted,

I retained your ack for patch 1 and patch 2 even though this version
changes patch 2.  Specifically, uses min_t() instead of min() and adds
__must_check function declaration in header file.

Changes since v1

 - Use min_t() instead of min() (thanks checkpatch).
 - Add __must_check to function declaration (thanks Steve).
 - Use hw RNG by default if available (as originally suggested by Kees).
 - Add command line option to use cryptographically insecure hashing.
   If debug_early_boot is enabled use hash_long() instead of siphash
   (as requested by Steve, and solves original problem for Anna-Maria).



thanks,
Tobin.


Tobin C. Harding (4):
  random: Fix whitespace pre random-bytes work
  random: Return nbytes filled from hw RNG
  vsprintf: Use hw RNG for ptr_key
  vsprintf: Add command line option debug_early_boot

 Documentation/admin-guide/kernel-parameters.txt |  8 ++++++
 drivers/char/random.c                           | 19 +++++++------
 include/linux/random.h                          |  2 +-
 lib/vsprintf.c                                  | 37 +++++++++++++++++++++++--
 4 files changed, 53 insertions(+), 13 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-05-03  5:09 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 22:50 [PATCH v2 0/4] enable early printing of hashed pointers Tobin C. Harding
2018-05-02 22:50 ` [PATCH v2 1/4] random: Fix whitespace pre random-bytes work Tobin C. Harding
2018-05-02 22:50 ` [PATCH v2 2/4] random: Return nbytes filled from hw RNG Tobin C. Harding
2018-05-02 22:50 ` [PATCH v2 3/4] vsprintf: Use hw RNG for ptr_key Tobin C. Harding
2018-05-02 22:50 ` [PATCH v2 4/4] vsprintf: Add command line option debug_early_boot Tobin C. Harding
2018-05-03  4:57   ` Kees Cook
2018-05-03  5:09     ` Tobin C. Harding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).