LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] clocksource/drivers/sprd: Fix Kconfig dependency
@ 2018-05-03 12:27 Chunyan Zhang
  2018-05-07  5:51 ` Daniel Lezcano
  0 siblings, 1 reply; 5+ messages in thread
From: Chunyan Zhang @ 2018-05-03 12:27 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: linux-kernel, Baolin Wang, Orson Zhai, Chunyan Zhang, Chunyan Zhang

SPRD arch doesn't select SPRD_TIMER, so this config would not
appear even if ARCH_SPRD is set and COMPILE_TEST is not.

Fix the Kconfig selection rule by letting the SPRD arch to select.

This patch also sets the default value of SPRD_TIMER with ARCH_SPRD,
but it still is selectable to users.

Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
---
 drivers/clocksource/Kconfig | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 619b120..c89e4d6 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -468,8 +468,9 @@ config MTK_TIMER
 	  Support for Mediatek timer driver.
 
 config SPRD_TIMER
-	bool "Spreadtrum timer driver" if COMPILE_TEST
-	depends on HAS_IOMEM
+	bool "Spreadtrum timer driver"
+	depends on HAS_IOMEM && (ARCH_SPRD || COMPILE_TEST)
+	default ARCH_SPRD
 	select TIMER_OF
 	help
 	  Enables support for the Spreadtrum timer driver.
-- 
2.7.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clocksource/drivers/sprd: Fix Kconfig dependency
  2018-05-03 12:27 [PATCH] clocksource/drivers/sprd: Fix Kconfig dependency Chunyan Zhang
@ 2018-05-07  5:51 ` Daniel Lezcano
  2018-05-07  6:04   ` Chunyan Zhang
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Lezcano @ 2018-05-07  5:51 UTC (permalink / raw)
  To: Chunyan Zhang; +Cc: linux-kernel, Baolin Wang, Orson Zhai, Chunyan Zhang

On Thu, May 03, 2018 at 08:27:32PM +0800, Chunyan Zhang wrote:
> SPRD arch doesn't select SPRD_TIMER, so this config would not
> appear even if ARCH_SPRD is set and COMPILE_TEST is not.
> 
> Fix the Kconfig selection rule by letting the SPRD arch to select.

Instead of changing this Kconfig, please fix the arch's Kconfig by selecting
SPRD_TIMER.



-- 

 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clocksource/drivers/sprd: Fix Kconfig dependency
  2018-05-07  5:51 ` Daniel Lezcano
@ 2018-05-07  6:04   ` Chunyan Zhang
  2018-05-07  7:49     ` Daniel Lezcano
  0 siblings, 1 reply; 5+ messages in thread
From: Chunyan Zhang @ 2018-05-07  6:04 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Chunyan Zhang, Linux Kernel Mailing List, Baolin Wang, Orson Zhai

Hi Daniel,

On 7 May 2018 at 13:51, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> On Thu, May 03, 2018 at 08:27:32PM +0800, Chunyan Zhang wrote:
>> SPRD arch doesn't select SPRD_TIMER, so this config would not
>> appear even if ARCH_SPRD is set and COMPILE_TEST is not.
>>
>> Fix the Kconfig selection rule by letting the SPRD arch to select.
>
> Instead of changing this Kconfig, please fix the arch's Kconfig by selecting
> SPRD_TIMER.

Oh, that's not my expectation, I hope we can give users permission of
not selecting SPRD TIMER driver even if SPRD arch is selected. (I can
confirm that all Spreadtrum's platforms in mainline can work without
this driver. An enough minimum workable system doesn't need this
driver indeed.)

Thanks,
Chunyan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clocksource/drivers/sprd: Fix Kconfig dependency
  2018-05-07  6:04   ` Chunyan Zhang
@ 2018-05-07  7:49     ` Daniel Lezcano
  2018-05-07  8:06       ` Chunyan Zhang
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Lezcano @ 2018-05-07  7:49 UTC (permalink / raw)
  To: Chunyan Zhang
  Cc: Chunyan Zhang, Linux Kernel Mailing List, Baolin Wang, Orson Zhai

On Mon, May 07, 2018 at 02:04:38PM +0800, Chunyan Zhang wrote:
> Hi Daniel,
> 
> On 7 May 2018 at 13:51, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> > On Thu, May 03, 2018 at 08:27:32PM +0800, Chunyan Zhang wrote:
> >> SPRD arch doesn't select SPRD_TIMER, so this config would not
> >> appear even if ARCH_SPRD is set and COMPILE_TEST is not.
> >>
> >> Fix the Kconfig selection rule by letting the SPRD arch to select.
> >
> > Instead of changing this Kconfig, please fix the arch's Kconfig by selecting
> > SPRD_TIMER.
> 
> Oh, that's not my expectation, I hope we can give users permission of
> not selecting SPRD TIMER driver even if SPRD arch is selected. (I can
> confirm that all Spreadtrum's platforms in mainline can work without
> this driver. An enough minimum workable system doesn't need this
> driver indeed.)

Ok, can you add the EXPERT option in addition to the bool like:

https://lkml.org/lkml/2018/4/3/897

Thanks.

  -- Daniel


-- 

 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] clocksource/drivers/sprd: Fix Kconfig dependency
  2018-05-07  7:49     ` Daniel Lezcano
@ 2018-05-07  8:06       ` Chunyan Zhang
  0 siblings, 0 replies; 5+ messages in thread
From: Chunyan Zhang @ 2018-05-07  8:06 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Chunyan Zhang, Linux Kernel Mailing List, Baolin Wang, Orson Zhai

On 7 May 2018 at 15:49, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> On Mon, May 07, 2018 at 02:04:38PM +0800, Chunyan Zhang wrote:
>> Hi Daniel,
>>
>> On 7 May 2018 at 13:51, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>> > On Thu, May 03, 2018 at 08:27:32PM +0800, Chunyan Zhang wrote:
>> >> SPRD arch doesn't select SPRD_TIMER, so this config would not
>> >> appear even if ARCH_SPRD is set and COMPILE_TEST is not.
>> >>
>> >> Fix the Kconfig selection rule by letting the SPRD arch to select.
>> >
>> > Instead of changing this Kconfig, please fix the arch's Kconfig by selecting
>> > SPRD_TIMER.
>>
>> Oh, that's not my expectation, I hope we can give users permission of
>> not selecting SPRD TIMER driver even if SPRD arch is selected. (I can
>> confirm that all Spreadtrum's platforms in mainline can work without
>> this driver. An enough minimum workable system doesn't need this
>> driver indeed.)
>
> Ok, can you add the EXPERT option in addition to the bool like:

Sure, that makes more sense indeed :)

Thanks for the review,
Chunyan

>
> https://lkml.org/lkml/2018/4/3/897
>
> Thanks.
>
>   -- Daniel
>
>
> --
>
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-05-07  8:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-03 12:27 [PATCH] clocksource/drivers/sprd: Fix Kconfig dependency Chunyan Zhang
2018-05-07  5:51 ` Daniel Lezcano
2018-05-07  6:04   ` Chunyan Zhang
2018-05-07  7:49     ` Daniel Lezcano
2018-05-07  8:06       ` Chunyan Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).