LKML Archive on
help / color / mirror / Atom feed
From: John Garry <>
To: <>, <>,
	<>, <>
Cc: <>, <>,
	<>, <>,
	<>, <>,
	<>, John Garry <>
Subject: [PATCH 0/2] HISI LPC ACPI UART support
Date: Thu, 3 May 2018 23:08:37 +0800	[thread overview]
Message-ID: <> (raw)

This patchset adds ACPI FW support for the UART on
the LPC bus on the Huawei D03 development board.

The UART is 8250-compatible, and has the following
- IO space iotype
- no interrupt, so polling mode required
- 16550 type

Currently an mfd-cell (platform device) is created per
device on the bus for using ACPI  firmware. As such,
we need require a platform driver for these devices.

Currently no platform driver exists for the UART. Indeed,
for PNP-compatible devices - like this UART - it would be
better to create a PNP device so that we may use the
existing PNP driver. Thus, we should use the 8250 PNP

However this host driver does not support PNP devices.
An RFC was sent for PNP support in [1]. However it was
deemed impractical to follow this path.

As a solution, we use the 8250 generic isa driver. For
this, we need to set the UART platform device name to
match the 8250 isa driver, so we require special setup 
for this. To support this, we introduce static MFD cells,
and support special setup handling for each device.
For the UART, this means passing the 8250 serial config
in the MFD cell platform data.


RFC -> v1:
- drop PNP support
- use static MFD cells
- add 8250 setup

John Garry (2):
  HISI LPC: Reference static MFD cells for ACPI support
  HISI LPC: Add ACPI UART support

 drivers/bus/hisi_lpc.c | 130 +++++++++++++++++++++++++++++++++++--------------
 1 file changed, 93 insertions(+), 37 deletions(-)


             reply	other threads:[~2018-05-03 15:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 15:08 John Garry [this message]
2018-05-03 15:08 ` [PATCH 1/2] HISI LPC: Reference static MFD cells for ACPI support John Garry
2018-05-03 16:54   ` Andy Shevchenko
2018-05-04  9:02     ` Lee Jones
2018-05-04  9:27       ` John Garry
2018-05-04 10:03         ` Lee Jones
2018-05-04 10:21           ` John Garry
2018-05-04 12:29     ` John Garry
2018-05-03 15:08 ` [PATCH 2/2] HISI LPC: Add ACPI UART support John Garry
2018-05-03 16:56   ` Andy Shevchenko
2018-05-04 12:33     ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 0/2] HISI LPC ACPI UART support' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).