LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Russell King <linux@armlinux.org.uk>
Cc: Wang Nan <wangnan0@huawei.com>, Will Deacon <will.deacon@arm.com>,
	Jon Medhurst <tixy@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mhiramat@kernel.org,
	David Long <dave.long@linaro.org>,
	stable@vger.kernel.org
Subject: [BUGFIX PATCH v3 2/4] arm: kprobes: Prohibit probing on optimized_callback
Date: Fri,  4 May 2018 13:15:29 +0900	[thread overview]
Message-ID: <152540732952.29650.11645105922811248579.stgit@devbox> (raw)
In-Reply-To: <152540727123.29650.13679359124038587629.stgit@devbox>

Prohibit probing on optimized_callback() because
it is called from kprobes itself. If we put a kprobes
on it, that will cause a recursive call loop.
Mark it NOKPROBE_SYMBOL.

Fixes: 0dc016dbd820 ("ARM: kprobes: enable OPTPROBES for ARM 32")
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: stable@vger.kernel.org
---
 arch/arm/probes/kprobes/opt-arm.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/probes/kprobes/opt-arm.c b/arch/arm/probes/kprobes/opt-arm.c
index ddc5a82eb10d..b2aa9b32bff2 100644
--- a/arch/arm/probes/kprobes/opt-arm.c
+++ b/arch/arm/probes/kprobes/opt-arm.c
@@ -192,6 +192,7 @@ optimized_callback(struct optimized_kprobe *op, struct pt_regs *regs)
 
 	local_irq_restore(flags);
 }
+NOKPROBE_SYMBOL(optimized_callback)
 
 int arch_prepare_optimized_kprobe(struct optimized_kprobe *op, struct kprobe *orig)
 {

  parent reply	other threads:[~2018-05-04  4:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04  4:14 [BUGFIX PATCH v3 0/4] arm: kprobes: Fix to prohibit probing on unsafe functions Masami Hiramatsu
2018-05-04  4:15 ` [BUGFIX PATCH v3 1/4] arm: kprobes: Fix to use get_kprobe_ctlblk after irq-disabed Masami Hiramatsu
2018-05-04  4:15 ` Masami Hiramatsu [this message]
2018-05-04  4:15 ` [BUGFIX PATCH v3 3/4] arm: kprobes: Prohibit kprobes on do_undefinstr Masami Hiramatsu
2018-05-04  4:16 ` [BUGFIX PATCH v3 4/4] arm: kprobes: Prohibit kprobes on get_user functions Masami Hiramatsu
2018-05-08 11:25 ` [BUGFIX PATCH v3 0/4] arm: kprobes: Fix to prohibit probing on unsafe functions Russell King - ARM Linux
2018-05-12  0:42   ` Masami Hiramatsu
2018-05-12  4:31     ` Greg KH
2018-05-12  9:06     ` Russell King - ARM Linux
2018-05-12 11:31   ` Masami Hiramatsu
2018-05-12 17:29     ` Florian Fainelli
2018-05-13  1:55       ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152540732952.29650.11645105922811248579.stgit@devbox \
    --to=mhiramat@kernel.org \
    --cc=dave.long@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=stable@vger.kernel.org \
    --cc=tixy@linaro.org \
    --cc=wangnan0@huawei.com \
    --cc=will.deacon@arm.com \
    --subject='Re: [BUGFIX PATCH v3 2/4] arm: kprobes: Prohibit probing on optimized_callback' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).