LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "stefan@agner.ch" <stefan@agner.ch>, "krzk@kernel.org" <krzk@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"dev@lynxeye.de" <dev@lynxeye.de>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: tegra: Add support for 256 MB Colibri-T20 (plus such board on Iris)
Date: Fri, 4 May 2018 09:37:47 +0000	[thread overview]
Message-ID: <1525426665.6296.7.camel@toradex.com> (raw)
In-Reply-To: <c47c07b2c112219093b668c0b4d46ac8@agner.ch>

Hi Krzysztof

On Fri, 2018-05-04 at 11:19 +0200, Stefan Agner wrote:
> On 03.05.2018 17:08, Krzysztof Kozlowski wrote:
> > Colibri-T20 can come in 256 MB RAM (with 512 MB NAND) or 512 MB RAM
> > (with 1024 MB NAND) flavors.  Add support for the 256 MB version on
> > Iris
> > evaluation board.
> 
> To we really need to specify memory size these days? I think all
> common
> boot loaders fill the memory node anyway.
> 
> arch/arm/boot/dts/imx6qdl-apalis.dtsi:
> 	/* Will be filled by the bootloader */
> 	memory@10000000 {
> 		reg = <0x10000000 0>;
> 	};

Yes, both mainline as well as our downstream U-Boot do actually set the
memory node.

In the past some people used to set it to the smallest SKU's memory
size just to be on the safe side.

However lately it is agreed that the memory node should no longer even
be present as can be seen from e.g. arch/arm/boot/dts/tegra30-
apalis.dtsi resp. tegra30-apalis-eval.dts.

> I think we should just rename tegra20-colibri-512.dtsi =>
> tegra20-colibri.dtsi and tegra20-iris-512.dts => tegra20-iris.dts
> avoid confusion and add such an empty node.

I would rather suggest going to the regular SoC, module, carrier naming
convention making it tegra20-colibri-iris.dts instead.

> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > 
> > ---
> > 
> > Changes since v1:
> > 1. Fix memory size in tegra20-colibri-256.dtsi (was working fine
> > because
> >    my bootloader uses mem= argument).
> 
> What boot loader are you using? You even can omit mem= if your boot
> loader fills the memory node properly.

Yes, using mem= should only be used to force memory size for test
purpose [1].

> --
> Stefan

[1] https://www.kernel.org/doc/html/v4.14/admin-guide/kernel-parameters
.html

Cheers

Marcel

  reply	other threads:[~2018-05-04  9:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 15:08 Krzysztof Kozlowski
2018-05-04  9:19 ` Stefan Agner
2018-05-04  9:37   ` Marcel Ziswiler [this message]
2018-05-04 10:03   ` Krzysztof Kozlowski
2018-05-04 10:14     ` Marcel Ziswiler
2018-05-08 12:35       ` Krzysztof Kozlowski
2018-05-08 13:03         ` Marcel Ziswiler
2018-05-07 16:58 ` Rob Herring
2018-05-08  7:26   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525426665.6296.7.camel@toradex.com \
    --to=marcel.ziswiler@toradex.com \
    --cc=dev@lynxeye.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=stefan@agner.ch \
    --cc=thierry.reding@gmail.com \
    --subject='Re: [PATCH v2] ARM: dts: tegra: Add support for 256 MB Colibri-T20 (plus such board on Iris)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).