LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alim Akhtar <alim.akhtar@samsung.com>
To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
vivek.gautam@codeaurora.org, subhashj@codeaurora.org,
vinholikatti@gmail.com, olof@lixom.net, alim.akhtar@samsung.com
Subject: [PATCH 2/4] scsi: ufs: add quirk not to allow reset of interrupt aggregation
Date: Sun, 06 May 2018 15:44:16 +0530 [thread overview]
Message-ID: <1525601658-31989-3-git-send-email-alim.akhtar@samsung.com> (raw)
In-Reply-To: <1525601658-31989-1-git-send-email-alim.akhtar@samsung.com>
Some host controller supports interrupt aggregation, but doesn't
allow to reset counter and timer by s/w.
Signed-off-by: Seungwon Jeon <essuuj@gmail.com>
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
drivers/scsi/ufs/ufshcd.c | 3 ++-
drivers/scsi/ufs/ufshcd.h | 6 ++++++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 9898ce5..253257c 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4695,7 +4695,8 @@ static void ufshcd_transfer_req_compl(struct ufs_hba *hba)
* false interrupt if device completes another request after resetting
* aggregation and before reading the DB.
*/
- if (ufshcd_is_intr_aggr_allowed(hba))
+ if (ufshcd_is_intr_aggr_allowed(hba) &&
+ !(hba->quirks & UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR))
ufshcd_reset_intr_aggr(hba);
tr_doorbell = ufshcd_readl(hba, REG_UTP_TRANSFER_REQ_DOOR_BELL);
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 43035f8..5c91ff1 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -600,6 +600,12 @@ struct ufs_hba {
*/
#define UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR 0x100
+ /*
+ * This quirk needs to be enabled if host controller doesn't allow
+ * that the interrupt aggregation timer and counter are reset by s/w.
+ */
+ #define UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR 0x200
+
unsigned int quirks; /* Deviations from standard UFSHCI spec. */
/* Device deviations from standard UFS device spec. */
--
2.7.4
next prev parent reply other threads:[~2018-05-06 10:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180506102636epcas2p3432b71e5c867f6cfec16cf2a8c74b0e2@epcas2p3.samsung.com>
2018-05-06 10:14 ` [PATCH 0/4] Add required changes to ufshcd to support exynos ufs hci Alim Akhtar
[not found] ` <CGME20180506102638epcas1p17bea76e1a5dbac535d5d6a10181f7e29@epcas1p1.samsung.com>
2018-05-06 10:14 ` [PATCH 1/4] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar
2018-05-16 21:23 ` Subhash Jadavani
2018-05-17 4:06 ` Asutosh Das (asd)
[not found] ` <CGME20180506102639epcas2p13ac44966a64e539f611ccdc2479e1abb@epcas2p1.samsung.com>
2018-05-06 10:14 ` Alim Akhtar [this message]
2018-05-16 21:24 ` [PATCH 2/4] scsi: ufs: add quirk not to allow reset of interrupt aggregation Subhash Jadavani
[not found] ` <CGME20180506102641epcas1p40fb2055e82d32d7cfa594af132273d31@epcas1p4.samsung.com>
2018-05-06 10:14 ` [PATCH 3/4] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
2018-05-16 21:26 ` Subhash Jadavani
[not found] ` <CGME20180506102643epcas2p24ed80d7ede859db73c2595724d9c2414@epcas2p2.samsung.com>
2018-05-06 10:14 ` [PATCH 4/4] scsi: ufs: make ufshcd_config_pwr_mode of non-static func Alim Akhtar
2018-05-16 7:51 ` Avri Altman
2018-05-16 21:27 ` Subhash Jadavani
2018-05-16 4:30 ` [PATCH 0/4] Add required changes to ufshcd to support exynos ufs hci Alim Akhtar
2018-05-18 14:52 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525601658-31989-3-git-send-email-alim.akhtar@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=olof@lixom.net \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=vivek.gautam@codeaurora.org \
--subject='Re: [PATCH 2/4] scsi: ufs: add quirk not to allow reset of interrupt aggregation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).