LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] swiotlb: Update the comment of swiotlb
@ 2018-05-07 11:06 Yisheng Xie
  2018-05-09  7:38 ` Christoph Hellwig
  0 siblings, 1 reply; 5+ messages in thread
From: Yisheng Xie @ 2018-05-07 11:06 UTC (permalink / raw)
  To: konrad.wilk, mingo, hch; +Cc: iommu, linux-kernel, Yisheng Xie

swiotlb use physical address of bounce buffer when do map and unmap,
therefore, related comment should be updated.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
---
 lib/swiotlb.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index fece575..e3d9445 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -593,9 +593,8 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
 }
 
 /*
- * Allocates bounce buffer and returns its kernel virtual address.
+ * Allocates bounce buffer and returns its physical address.
  */
-
 static phys_addr_t
 map_single(struct device *hwdev, phys_addr_t phys, size_t size,
 	   enum dma_data_direction dir, unsigned long attrs)
@@ -614,7 +613,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
 }
 
 /*
- * dma_addr is the kernel virtual address of the bounce buffer to unmap.
+ * tlb_addr is the physical address of the bounce buffer to unmap.
  */
 void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr,
 			      size_t size, enum dma_data_direction dir,
-- 
1.7.12.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] swiotlb: Update the comment of swiotlb
  2018-05-07 11:06 [PATCH] swiotlb: Update the comment of swiotlb Yisheng Xie
@ 2018-05-09  7:38 ` Christoph Hellwig
  2018-05-09  9:08   ` Yisheng Xie
  0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2018-05-09  7:38 UTC (permalink / raw)
  To: Yisheng Xie; +Cc: konrad.wilk, mingo, hch, iommu, linux-kernel

Thanks,

applied to the dma-mapping tree.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] swiotlb: Update the comment of swiotlb
  2018-05-09  7:38 ` Christoph Hellwig
@ 2018-05-09  9:08   ` Yisheng Xie
  2018-05-09 11:39     ` Christoph Hellwig
  0 siblings, 1 reply; 5+ messages in thread
From: Yisheng Xie @ 2018-05-09  9:08 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: konrad.wilk, mingo, iommu, linux-kernel

Hi Christoph,

On 2018/5/9 15:38, Christoph Hellwig wrote:
> Thanks,
> 
> applied to the dma-mapping tree.

Thanks

BTW, should lib/swiotlb.c also add to DMA MAPPING HELPERS, or
add yourself as a maintainer of SWIOTLB SUBSYSTEM ? It will make
get_maintainer.pl get you :)

Thanks
Yisheng
> 
> .
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] swiotlb: Update the comment of swiotlb
  2018-05-09  9:08   ` Yisheng Xie
@ 2018-05-09 11:39     ` Christoph Hellwig
  2018-05-09 14:21       ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2018-05-09 11:39 UTC (permalink / raw)
  To: Yisheng Xie; +Cc: Christoph Hellwig, konrad.wilk, mingo, iommu, linux-kernel

On Wed, May 09, 2018 at 05:08:30PM +0800, Yisheng Xie wrote:
> Hi Christoph,
> 
> On 2018/5/9 15:38, Christoph Hellwig wrote:
> > Thanks,
> > 
> > applied to the dma-mapping tree.
> 
> Thanks
> 
> BTW, should lib/swiotlb.c also add to DMA MAPPING HELPERS, or
> add yourself as a maintainer of SWIOTLB SUBSYSTEM ? It will make
> get_maintainer.pl get you :)

Konrad is the maintainer, but due to me touching the file a lot
lately I keep merging the patches for now.  But anything non-trivial
absolutely requires an Ack from Konrad.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] swiotlb: Update the comment of swiotlb
  2018-05-09 11:39     ` Christoph Hellwig
@ 2018-05-09 14:21       ` Konrad Rzeszutek Wilk
  0 siblings, 0 replies; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2018-05-09 14:21 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Yisheng Xie, mingo, iommu, linux-kernel

On Wed, May 09, 2018 at 01:39:57PM +0200, Christoph Hellwig wrote:
> On Wed, May 09, 2018 at 05:08:30PM +0800, Yisheng Xie wrote:
> > Hi Christoph,
> > 
> > On 2018/5/9 15:38, Christoph Hellwig wrote:
> > > Thanks,
> > > 
> > > applied to the dma-mapping tree.
> > 
> > Thanks
> > 
> > BTW, should lib/swiotlb.c also add to DMA MAPPING HELPERS, or
> > add yourself as a maintainer of SWIOTLB SUBSYSTEM ? It will make
> > get_maintainer.pl get you :)
> 
> Konrad is the maintainer, but due to me touching the file a lot
> lately I keep merging the patches for now.  But anything non-trivial
> absolutely requires an Ack from Konrad.

<nods>

Thank you for pulling this in your tree.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-05-09 14:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 11:06 [PATCH] swiotlb: Update the comment of swiotlb Yisheng Xie
2018-05-09  7:38 ` Christoph Hellwig
2018-05-09  9:08   ` Yisheng Xie
2018-05-09 11:39     ` Christoph Hellwig
2018-05-09 14:21       ` Konrad Rzeszutek Wilk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).