LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pkshih <pkshih@realtek.com>
To: "jprvita@gmail.com" <jprvita@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
	"jprvita@endlessm.com" <jprvita@endlessm.com>,
	"Birming Chiu" <birming@realtek.com>,
	"drake@endlessm.com" <drake@endlessm.com>,
	Chaoming_Li <chaoming_li@realsil.com.cn>,
	"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	莊彥宣 <yhchuang@realtek.com>,
	"derosier@gmail.com" <derosier@gmail.com>,
	"Steven Ting" <steventing@realtek.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux@endlessm.com" <linux@endlessm.com>,
	Shaofu <shaofu@realtek.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: RTL8723BE performance regression
Date: Tue, 8 May 2018 08:37:16 +0000	[thread overview]
Message-ID: <1525768634.2885.11.camel@realtek.com> (raw)
In-Reply-To: <CA+A7VXWywjTVeb3DTjVMVTUw-vjAjD+3XTuVNk8S=8D7W=MkPQ@mail.gmail.com>

On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote:
> On Tue, May 1, 2018 at 10:58 PM, Pkshih <pkshih@realtek.com> wrote:
> > On Wed, 2018-05-02 at 05:44 +0000, Pkshih wrote:
> >>
> >> > -----Original Message-----
> >> > From: João Paulo Rechi Vita [mailto:jprvita@gmail.com]
> >> > Sent: Wednesday, May 02, 2018 6:41 AM
> >> > To: Larry Finger
> >> > Cc: Steve deRosier; 莊彥宣; Pkshih; Birming Chiu; Shaofu; Steven Ting; Chaoming_Li; Kalle Valo;
> >> > linux-wireless; Network Development; LKML; Daniel Drake; João Paulo Rechi Vita; linux@endless
> m.c
> >> om
> >> > Subject: Re: RTL8723BE performance regression
> >> >
> >> > On Tue, Apr 3, 2018 at 7:51 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> >> > > On 04/03/2018 09:37 PM, João Paulo Rechi Vita wrote:
> >> > >>
> >> > >> On Tue, Apr 3, 2018 at 7:28 PM, Larry Finger <Larry.Finger@lwfinger.net>
> >> > >> wrote:
> >> > >>
> >> > >> (...)
> >> > >>
> >> > >>> As the antenna selection code changes affected your first bisection, do
> >> > >>> you
> >> > >>> have one of those HP laptops with only one antenna and the incorrect
> >> > >>> coding
> >> > >>> in the FUSE?
> >> > >>
> >> > >>
> >> > >> Yes, that is why I've been passing ant_sel=1 during my tests -- this
> >> > >> was needed to achieve a good performance in the past, before this
> >> > >> regression. I've also opened the laptop chassis and confirmed the
> >> > >> antenna cable is plugged to the connector labeled with "1" on the
> >> > >> card.
> >> > >>
> >> > >>> If so, please make sure that you still have the same signal
> >> > >>> strength for good and bad cases. I have tried to keep the driver and the
> >> > >>> btcoex code in sync, but there may be some combinations of antenna
> >> > >>> configuration and FUSE contents that cause the code to fail.
> >> > >>>
> >> > >>
> >> > >> What is the recommended way to monitor the signal strength?
> >> > >
> >> > >
> >> > > The btcoex code is developed for multiple platforms by a different group
> >> > > than the Linux driver. I think they made a change that caused ant_sel to
> >> > > switch from 1 to 2. At least numerous comments at
> >> > > github.com/lwfinger/rtlwifi_new claimed they needed to make that change.
> >> > >
> >> > > Mhy recommended method is to verify the wifi device name with "iw dev". Then
> >> > > using that device
> >> > >
> >> > > sudo iw dev <dev_name> scan | egrep "SSID|signal"
> >> > >
> >> >
> >> > I have confirmed that the performance regression is indeed tied to
> >> > signal strength: on the good cases signal was between -16 and -8 dBm,
> >> > whereas in bad cases signal was always between -50 to - 40 dBm. I've
> >> > also switched to testing bandwidth in controlled LAN environment using
> >> > iperf3, as suggested by Steve deRosier, with the DUT being the only
> >> > machine connected to the 2.4 GHz radio and the machine running the
> >> > iperf3 server connected via ethernet.
> >> >
> >>
> >> We have new experimental results in commit af8a41cccf8f46 ("rtlwifi: cleanup
> >> 8723be ant_sel definition"). You can use the above commit and do the same
> >> experiments (with ant_sel=0, 1 and 2) in your side, and then share your results.
> >> Since performance is tied to signal strength, you can only share signal strength.
> >>
> >
> > Please pay attention to cold reboot once ant_sel is changed.
> >
> 
> I've tested the commit mentioned above and it fixes the problem on top
> of v4.16 (in addition to the latest wireless-drivers-next also been
> fixed as it already contains such commit). On v4.15, we also need the
> following commits before "af8a41cccf8f rtlwifi: cleanup 8723be ant_sel
> definition" to have a good performance again:
> 
>   874e837d67d0 rtlwifi: fill FW version and subversion
>   a44709bba70f rtlwifi: btcoex: Add power_on_setting routine
>   40d9dd4f1c5d rtlwifi: btcoex: Remove global variables from btcoex

v4.15 isn't longterm version and had been EOL.

> 
> Surprisingly, it seems forcing ant_sel=1 is not needed anymore on
> these machines, as the shown by the numbers bellow (ant_sel=0 means
> that actually no parameter was passed to the module). I have powered
> off the machine and done a cold boot for every test. It seems
> something have changed in the antenna auto-selection code since v4.11,
> the latest point where I could confirm we definitely need to force
> ant_sel=1. I've been trying to understand what causes this difference,
> but haven't made progress on that so far, so any suggestions are
> appreciated (we are trying to decide if we can confidently drop the
> downstream DMI quirks for these specific machines).
> 
I think your rtl8723be module programed correct efuse content, so it
works properly with ant_sel=0, and quirk isn't required for your
machine.

>   w-d-n ant_sel=0: -14.00 dBm,  69.5 Mbps -> good
>   w-d-n ant_sel=1: -10.00 dBm,  41.1 Mbps -> good
>   w-d-n ant_sel=2: -44.00 dBm,   607 kbps -> bad
> 
>   v4.16 ant_sel=0: -12.00 dBm,  63.0 Mbps -> good
>   v4.16 ant_sel=1: - 8.00 dBm,  69.0 Mbps -> good
>   v4.16 ant_sel=2: -50.00 dBm,   224 kbps -> bad
> 
>   v4.15 ant_sel=0: - 8.00 dBm,  33.0 Mbps -> good
>   v4.15 ant_sel=1: -10.00 dBm,  38.1 Mbps -> good
>   v4.15 ant_sel=2: -48.00 dBm,   206 kbps -> bad
> 

With your results, the efuse content is programmed as one or two antenna
on AUX path.

Regards,
PK

  reply	other threads:[~2018-05-08  8:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04  1:51 João Paulo Rechi Vita
2018-04-04  2:28 ` Larry Finger
2018-04-04  2:37   ` João Paulo Rechi Vita
2018-04-04  2:51     ` Larry Finger
2018-05-01 22:41       ` João Paulo Rechi Vita
2018-05-01 22:46         ` [RFC PATCH 1/3] rtlwifi: btcoex: Don't init antenna position to main port João Paulo Rechi Vita
2018-05-01 22:46           ` [RFC PATCH 2/3] Revert "rtlwifi: fill FW version and subversion" João Paulo Rechi Vita
2018-05-01 22:46           ` [RFC PATCH 3/3] rtlwifi: btcoex: Always use 2ant-functions for RTL8723BE João Paulo Rechi Vita
2018-05-02  5:44         ` RTL8723BE performance regression Pkshih
2018-05-02  5:58           ` Pkshih
2018-05-07 21:49             ` João Paulo Rechi Vita
2018-05-08  8:37               ` Pkshih [this message]
2018-05-09 20:33                 ` João Paulo Rechi Vita
2018-05-14  2:50                   ` Pkshih
2018-04-04 14:54 ` Steve deRosier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525768634.2885.11.camel@realtek.com \
    --to=pkshih@realtek.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=birming@realtek.com \
    --cc=chaoming_li@realsil.com.cn \
    --cc=derosier@gmail.com \
    --cc=drake@endlessm.com \
    --cc=jprvita@endlessm.com \
    --cc=jprvita@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=netdev@vger.kernel.org \
    --cc=shaofu@realtek.com \
    --cc=steventing@realtek.com \
    --cc=yhchuang@realtek.com \
    --subject='Re: RTL8723BE performance regression' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).