LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Documentation/admin-guide/pm/intel_pstate: fix Active Mode w/o HWP paragraph
@ 2018-05-08 15:12 Juri Lelli
  2018-05-08 18:36 ` Srinivas Pandruvada
  0 siblings, 1 reply; 3+ messages in thread
From: Juri Lelli @ 2018-05-08 15:12 UTC (permalink / raw)
  To: linux-kernel
  Cc: Juri Lelli, Jonathan Corbet, Rafael J. Wysocki,
	Srinivas Pandruvada, linux-doc, linux-pm

P-state selection algorithm (powersave or performance) is selected by
echoing the desired choice to scaling_governor sysfs attribute and not
to scaling_cur_freq (as currently stated).

Fix it.

Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-doc@vger.kernel.org
Cc: linux-pm@vger.kernel.org

---
 Documentation/admin-guide/pm/intel_pstate.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/pm/intel_pstate.rst b/Documentation/admin-guide/pm/intel_pstate.rst
index d2b6fda3d67b..ab2fe0eda1d7 100644
--- a/Documentation/admin-guide/pm/intel_pstate.rst
+++ b/Documentation/admin-guide/pm/intel_pstate.rst
@@ -145,7 +145,7 @@ feature enabled.]
 
 In this mode ``intel_pstate`` registers utilization update callbacks with the
 CPU scheduler in order to run a P-state selection algorithm, either
-``powersave`` or ``performance``, depending on the ``scaling_cur_freq`` policy
+``powersave`` or ``performance``, depending on the ``scaling_governor`` policy
 setting in ``sysfs``.  The current CPU frequency information to be made
 available from the ``scaling_cur_freq`` policy attribute in ``sysfs`` is
 periodically updated by those utilization update callbacks too.
-- 
2.14.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation/admin-guide/pm/intel_pstate: fix Active Mode w/o HWP paragraph
  2018-05-08 15:12 [PATCH] Documentation/admin-guide/pm/intel_pstate: fix Active Mode w/o HWP paragraph Juri Lelli
@ 2018-05-08 18:36 ` Srinivas Pandruvada
  2018-05-13  8:41   ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Pandruvada @ 2018-05-08 18:36 UTC (permalink / raw)
  To: Juri Lelli, linux-kernel
  Cc: Jonathan Corbet, Rafael J. Wysocki, linux-doc, linux-pm

On Tue, 2018-05-08 at 17:12 +0200, Juri Lelli wrote:
> P-state selection algorithm (powersave or performance) is selected by
> echoing the desired choice to scaling_governor sysfs attribute and
> not
> to scaling_cur_freq (as currently stated).
> 
> Fix it.
Thanks for the fix.

> 
> Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: linux-doc@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>


> 
> ---
>  Documentation/admin-guide/pm/intel_pstate.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/pm/intel_pstate.rst
> b/Documentation/admin-guide/pm/intel_pstate.rst
> index d2b6fda3d67b..ab2fe0eda1d7 100644
> --- a/Documentation/admin-guide/pm/intel_pstate.rst
> +++ b/Documentation/admin-guide/pm/intel_pstate.rst
> @@ -145,7 +145,7 @@ feature enabled.]
>  
>  In this mode ``intel_pstate`` registers utilization update callbacks
> with the
>  CPU scheduler in order to run a P-state selection algorithm, either
> -``powersave`` or ``performance``, depending on the
> ``scaling_cur_freq`` policy
> +``powersave`` or ``performance``, depending on the
> ``scaling_governor`` policy
>  setting in ``sysfs``.  The current CPU frequency information to be
> made
>  available from the ``scaling_cur_freq`` policy attribute in
> ``sysfs`` is
>  periodically updated by those utilization update callbacks too.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Documentation/admin-guide/pm/intel_pstate: fix Active Mode w/o HWP paragraph
  2018-05-08 18:36 ` Srinivas Pandruvada
@ 2018-05-13  8:41   ` Rafael J. Wysocki
  0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-05-13  8:41 UTC (permalink / raw)
  To: Srinivas Pandruvada, Juri Lelli
  Cc: linux-kernel, Jonathan Corbet, Rafael J. Wysocki, linux-doc, linux-pm

On Tuesday, May 8, 2018 8:36:44 PM CEST Srinivas Pandruvada wrote:
> On Tue, 2018-05-08 at 17:12 +0200, Juri Lelli wrote:
> > P-state selection algorithm (powersave or performance) is selected by
> > echoing the desired choice to scaling_governor sysfs attribute and
> > not
> > to scaling_cur_freq (as currently stated).
> > 
> > Fix it.
> Thanks for the fix.
> 
> > 
> > Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > Cc: linux-doc@vger.kernel.org
> > Cc: linux-pm@vger.kernel.org
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> 
> 
> > 
> > ---
> >  Documentation/admin-guide/pm/intel_pstate.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/admin-guide/pm/intel_pstate.rst
> > b/Documentation/admin-guide/pm/intel_pstate.rst
> > index d2b6fda3d67b..ab2fe0eda1d7 100644
> > --- a/Documentation/admin-guide/pm/intel_pstate.rst
> > +++ b/Documentation/admin-guide/pm/intel_pstate.rst
> > @@ -145,7 +145,7 @@ feature enabled.]
> >  
> >  In this mode ``intel_pstate`` registers utilization update callbacks
> > with the
> >  CPU scheduler in order to run a P-state selection algorithm, either
> > -``powersave`` or ``performance``, depending on the
> > ``scaling_cur_freq`` policy
> > +``powersave`` or ``performance``, depending on the
> > ``scaling_governor`` policy
> >  setting in ``sysfs``.  The current CPU frequency information to be
> > made
> >  available from the ``scaling_cur_freq`` policy attribute in
> > ``sysfs`` is
> >  periodically updated by those utilization update callbacks too.
> 

Applied and pushed for 4.17-rc5, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-13  8:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-08 15:12 [PATCH] Documentation/admin-guide/pm/intel_pstate: fix Active Mode w/o HWP paragraph Juri Lelli
2018-05-08 18:36 ` Srinivas Pandruvada
2018-05-13  8:41   ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).