LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jane Wan <Jane.Wan@nokia.com>
To: Boris.Brezillon@bootlin.com, miquel.raynal@bootlin.com,
dwmw2@infradead.org, computersforpeace@gmail.com, richard@nod.at,
marek.vasut@gmail.com, yamada.masahiro@socionext.com,
prabhakar.kushwaha@nxp.com, shawnguo@kernel.org,
jagdish.gediya@nxp.com, shreeya.patel23498@gmail.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
ties.bos@nokia.com, Jane Wan <Jane.Wan@nokia.com>
Subject: [PATCH v4 2/2] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter
Date: Tue, 8 May 2018 14:19:54 -0700 [thread overview]
Message-ID: <1525814394-30067-2-git-send-email-Jane.Wan@nokia.com> (raw)
In-Reply-To: <1525814394-30067-1-git-send-email-Jane.Wan@nokia.com>
Per ONFI specification (Rev. 4.0), if all parameter pages have invalid
CRC values, the bit-wise majority may be used to recover the contents of
the parameter pages from the parameter page copies present.
Signed-off-by: Jane Wan <Jane.Wan@nokia.com>
---
drivers/mtd/nand/raw/nand_base.c | 49 ++++++++++++++++++++++++++++++++++----
1 file changed, 44 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 72f3a89..dfc341c 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -5086,6 +5086,38 @@ static int nand_flash_detect_ext_param_page(struct nand_chip *chip,
return ret;
}
+#define GET_BIT(bit, val) (((val) >> (bit)) & 0x01)
+
+/*
+ * Recover NAND parameter page with bit-wise majority
+ */
+static int onfi_recover_param(struct nand_onfi_params *p, int pages)
+{
+ int i, j, k;
+ u8 v, m;
+ u8 *buf;
+
+ buf = (u8 *)p;
+ for (i = 0; i < sizeof(*p); i++) {
+ v = 0;
+ for (j = 0; j < 8; j++) {
+ m = 0;
+ for (k = 0; k < pages; k++)
+ m += GET_BIT(j, buf[k*sizeof(*p) + i]);
+ if (m > pages/2)
+ v |= BIT(j);
+ }
+ ((u8 *)p)[i] = v;
+ }
+
+ if (onfi_crc16(ONFI_CRC_BASE, (u8 *)p, 254) ==
+ le16_to_cpu(p->crc)) {
+ return 1;
+ }
+
+ return 0;
+}
+
/*
* Check if the NAND chip is ONFI compliant, returns 1 if it is, 0 otherwise.
*/
@@ -5102,7 +5134,7 @@ static int nand_flash_detect_onfi(struct nand_chip *chip)
return 0;
/* ONFI chip: allocate a buffer to hold its parameter page */
- p = kzalloc(sizeof(*p), GFP_KERNEL);
+ p = kzalloc((sizeof(*p) * 3), GFP_KERNEL);
if (!p)
return -ENOMEM;
@@ -5113,21 +5145,28 @@ static int nand_flash_detect_onfi(struct nand_chip *chip)
}
for (i = 0; i < 3; i++) {
- ret = nand_read_data_op(chip, p, sizeof(*p), true);
+ ret = nand_read_data_op(chip, &p[i], sizeof(*p), true);
if (ret) {
ret = 0;
goto free_onfi_param_page;
}
- if (onfi_crc16(ONFI_CRC_BASE, (uint8_t *)p, 254) ==
+ if (onfi_crc16(ONFI_CRC_BASE, (u8 *)&p[i], 254) ==
le16_to_cpu(p->crc)) {
+ if (i)
+ memcpy(p, &p[i], sizeof(*p));
break;
}
}
if (i == 3) {
- pr_err("Could not find valid ONFI parameter page; aborting\n");
- goto free_onfi_param_page;
+ pr_err("Could not find valid ONFI parameter page\n");
+ pr_info("Recover ONFI params with bit-wise majority\n");
+ ret = onfi_recover_param(p, 3);
+ if (ret == 0) {
+ pr_err("ONFI parameter recovery failed, aborting\n");
+ goto free_onfi_param_page;
+ }
}
/* Check version */
--
1.7.9.5
next prev parent reply other threads:[~2018-05-08 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 21:19 [PATCH v4 1/2] mtd: rawnand: fsl_ifc: fix FSL NAND driver to read all ONFI parameter pages Jane Wan
2018-05-08 21:19 ` Jane Wan [this message]
2018-05-09 14:19 ` [PATCH v4 2/2] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter Boris Brezillon
2018-05-10 2:52 ` Wan, Jane (Nokia - US/Sunnyvale)
2018-05-09 14:12 ` [PATCH v4 1/2] mtd: rawnand: fsl_ifc: fix FSL NAND driver to read all ONFI parameter pages Boris Brezillon
2018-05-09 15:55 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525814394-30067-2-git-send-email-Jane.Wan@nokia.com \
--to=jane.wan@nokia.com \
--cc=Boris.Brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jagdish.gediya@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=prabhakar.kushwaha@nxp.com \
--cc=richard@nod.at \
--cc=shawnguo@kernel.org \
--cc=shreeya.patel23498@gmail.com \
--cc=ties.bos@nokia.com \
--cc=yamada.masahiro@socionext.com \
--subject='Re: [PATCH v4 2/2] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).