LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Kirill Tkhai <ktkhai@virtuozzo.com> To: akpm@linux-foundation.org, vdavydov.dev@gmail.com, shakeelb@google.com, viro@zeniv.linux.org.uk, hannes@cmpxchg.org, mhocko@kernel.org, ktkhai@virtuozzo.com, tglx@linutronix.de, pombredanne@nexb.com, stummala@codeaurora.org, gregkh@linuxfoundation.org, sfr@canb.auug.org.au, guro@fb.com, mka@chromium.org, penguin-kernel@I-love.SAKURA.ne.jp, chris@chris-wilson.co.uk, longman@redhat.com, minchan@kernel.org, ying.huang@intel.com, mgorman@techsingularity.net, jbacik@fb.com, linux@roeck-us.net, linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, lirongqing@baidu.com, aryabinin@virtuozzo.com Subject: [PATCH v4 04/13] mm: Refactoring in workingset_init() Date: Wed, 09 May 2018 14:57:27 +0300 [thread overview] Message-ID: <152586704715.3048.16683522879894119893.stgit@localhost.localdomain> (raw) In-Reply-To: <152586686544.3048.15776787801312398314.stgit@localhost.localdomain> Use prealloc_shrinker()/register_shrinker_prepared() instead of register_shrinker(). This will be used in next patch. Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com> --- mm/workingset.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/workingset.c b/mm/workingset.c index 40ee02c83978..c3a4fe145bb7 100644 --- a/mm/workingset.c +++ b/mm/workingset.c @@ -528,15 +528,16 @@ static int __init workingset_init(void) pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n", timestamp_bits, max_order, bucket_order); - ret = __list_lru_init(&shadow_nodes, true, &shadow_nodes_key); + ret = prealloc_shrinker(&workingset_shadow_shrinker); if (ret) goto err; - ret = register_shrinker(&workingset_shadow_shrinker); + ret = __list_lru_init(&shadow_nodes, true, &shadow_nodes_key); if (ret) goto err_list_lru; + register_shrinker_prepared(&workingset_shadow_shrinker); return 0; err_list_lru: - list_lru_destroy(&shadow_nodes); + free_prealloced_shrinker(&workingset_shadow_shrinker); err: return ret; }
next prev parent reply other threads:[~2018-05-09 11:57 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-09 11:56 [PATCH v4 00/13] Improve shrink_slab() scalability (old complexity was O(n^2), new is O(n)) Kirill Tkhai 2018-05-09 11:56 ` [PATCH v4 01/13] mm: Assign id to every memcg-aware shrinker Kirill Tkhai 2018-05-09 22:55 ` Andrew Morton 2018-05-10 2:47 ` Shakeel Butt 2018-05-10 9:42 ` Kirill Tkhai 2018-05-09 11:57 ` [PATCH v4 02/13] memcg: Move up for_each_mem_cgroup{, _tree} defines Kirill Tkhai 2018-05-09 11:57 ` [PATCH v4 03/13] mm: Assign memcg-aware shrinkers bitmap to memcg Kirill Tkhai 2018-05-09 11:57 ` Kirill Tkhai [this message] 2018-05-09 11:57 ` [PATCH v4 05/13] fs: Refactoring in alloc_super() Kirill Tkhai 2018-05-09 11:57 ` [PATCH v4 06/13] fs: Propagate shrinker::id to list_lru Kirill Tkhai 2018-05-09 11:57 ` [PATCH v4 07/13] list_lru: Add memcg argument to list_lru_from_kmem() Kirill Tkhai 2018-05-09 11:58 ` [PATCH v4 08/13] list_lru: Pass dst_memcg argument to memcg_drain_list_lru_node() Kirill Tkhai 2018-05-09 11:58 ` [PATCH v4 09/13] list_lru: Pass lru " Kirill Tkhai 2018-05-09 11:58 ` [PATCH v4 10/13] mm: Set bit in memcg shrinker bitmap on first list_lru item apearance Kirill Tkhai 2018-05-09 11:58 ` [PATCH v4 11/13] mm: Iterate only over charged shrinkers during memcg shrink_slab() Kirill Tkhai 2018-05-09 11:58 ` [PATCH v4 12/13] mm: Add SHRINK_EMPTY shrinker methods return value Kirill Tkhai 2018-05-09 11:58 ` [PATCH v4 13/13] mm: Clear shrinker bit if there are no objects related to memcg Kirill Tkhai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=152586704715.3048.16683522879894119893.stgit@localhost.localdomain \ --to=ktkhai@virtuozzo.com \ --cc=akpm@linux-foundation.org \ --cc=aryabinin@virtuozzo.com \ --cc=chris@chris-wilson.co.uk \ --cc=gregkh@linuxfoundation.org \ --cc=guro@fb.com \ --cc=hannes@cmpxchg.org \ --cc=jbacik@fb.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux@roeck-us.net \ --cc=lirongqing@baidu.com \ --cc=longman@redhat.com \ --cc=mgorman@techsingularity.net \ --cc=mhocko@kernel.org \ --cc=minchan@kernel.org \ --cc=mka@chromium.org \ --cc=penguin-kernel@I-love.SAKURA.ne.jp \ --cc=pombredanne@nexb.com \ --cc=sfr@canb.auug.org.au \ --cc=shakeelb@google.com \ --cc=stummala@codeaurora.org \ --cc=tglx@linutronix.de \ --cc=vdavydov.dev@gmail.com \ --cc=viro@zeniv.linux.org.uk \ --cc=willy@infradead.org \ --cc=ying.huang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).