LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alexey Khoroshilov <khoroshilov@ispras.ru>
To: Joachim Eastwood <manabian@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
Richard Weinberger <richard@nod.at>,
linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org, Julia Lawall <julia.lawall@lip6.fr>,
sil2review@lists.osadl.org
Subject: [PATCH v2] mtd: nxp-spifi: release flash_np in nxp_spifi_probe()
Date: Wed, 9 May 2018 17:56:46 +0300 [thread overview]
Message-ID: <1525877806-21148-1-git-send-email-khoroshilov@ispras.ru> (raw)
In-Reply-To: <20180509163920.67a5f203@bbrezillon>
nxp_spifi_probe() increments refcnt of SPI flash device node by
of_get_next_available_child() and leaves it undecremented on both
successful and error paths.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
drivers/mtd/spi-nor/nxp-spifi.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/nxp-spifi.c b/drivers/mtd/spi-nor/nxp-spifi.c
index 15374216d4d9..7b047951d0a2 100644
--- a/drivers/mtd/spi-nor/nxp-spifi.c
+++ b/drivers/mtd/spi-nor/nxp-spifi.c
@@ -438,11 +438,15 @@ static int nxp_spifi_probe(struct platform_device *pdev)
ret = nxp_spifi_setup_flash(spifi, flash_np);
if (ret) {
dev_err(&pdev->dev, "unable to setup flash chip\n");
- goto dis_clks;
+ goto put_np;
}
+ of_node_put(flash_np);
+
return 0;
+put_np:
+ of_node_put(flash_np);
dis_clks:
clk_disable_unprepare(spifi->clk_spifi);
dis_clk_reg:
--
2.7.4
next prev parent reply other threads:[~2018-05-09 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 20:47 [PATCH] mtd: nxp-spifi: decrement flash_np refcnt on error paths Alexey Khoroshilov
2018-05-09 9:42 ` Boris Brezillon
2018-05-09 14:35 ` Alexey Khoroshilov
2018-05-09 14:39 ` Boris Brezillon
2018-05-09 14:56 ` Alexey Khoroshilov [this message]
2018-05-09 15:03 ` [PATCH v2] mtd: nxp-spifi: release flash_np in nxp_spifi_probe() Boris Brezillon
2018-05-09 15:11 ` [PATCH v3] " Alexey Khoroshilov
2018-07-07 6:58 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525877806-21148-1-git-send-email-khoroshilov@ispras.ru \
--to=khoroshilov@ispras.ru \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=ldv-project@linuxtesting.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=manabian@gmail.com \
--cc=richard@nod.at \
--cc=sil2review@lists.osadl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).