LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: bcm2835-camera: Add TODO for removing overlay support
@ 2018-05-10 23:12 Stefan Schake
  2018-05-11  9:21 ` Dave Stevenson
  2018-05-14 11:59 ` Greg KH
  0 siblings, 2 replies; 3+ messages in thread
From: Stefan Schake @ 2018-05-10 23:12 UTC (permalink / raw)
  To: eric, stefan.wahren, gregkh, linux-rpi-kernel, devel,
	linux-kernel, dave.stevenson
  Cc: Stefan Schake

The overlay code is non-functional since it relies on firmware control
of the HVS.

Signed-off-by: Stefan Schake <stschake@gmail.com>
---
Dave, does this match your understanding?

 drivers/staging/vc04_services/bcm2835-camera/TODO | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
index 0ab9e88..770fea6 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/TODO
+++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
@@ -32,3 +32,11 @@ We should have VCHI create a platform device once it's initialized,
 and have this driver bind to it, so that we automatically load the
 v4l2 module after VCHI loads.
 
+5) Remove overlay support.
+
+We advertise support for a V4L2 overlay implemented through the
+ril.video_render component. This component is non-functional with an
+upstream kernel since the VC4 DRM driver controls the HVS, not the
+firmware. Once we have dma-buf support, the same functionality with
+improved control can be achieved through the DRM interface. We should
+therefore remove all V4L2 overlay functionality from the driver.
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: bcm2835-camera: Add TODO for removing overlay support
  2018-05-10 23:12 [PATCH] staging: bcm2835-camera: Add TODO for removing overlay support Stefan Schake
@ 2018-05-11  9:21 ` Dave Stevenson
  2018-05-14 11:59 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Dave Stevenson @ 2018-05-11  9:21 UTC (permalink / raw)
  To: Stefan Schake
  Cc: Eric Anholt, Stefan Wahren, Greg KH,
	moderated list:BROADCOM BCM2835 ARM ARCHITECTURE, devel,
	linux-kernel

On 11 May 2018 at 00:12, Stefan Schake <stschake@gmail.com> wrote:
> The overlay code is non-functional since it relies on firmware control
> of the HVS.
>
> Signed-off-by: Stefan Schake <stschake@gmail.com>
> ---
> Dave, does this match your understanding?

Yes, the overlay only works if you are not running the vc4 driver,
therefore dropping it is sensible for the mainline kernel.

>  drivers/staging/vc04_services/bcm2835-camera/TODO | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
> index 0ab9e88..770fea6 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/TODO
> +++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
> @@ -32,3 +32,11 @@ We should have VCHI create a platform device once it's initialized,
>  and have this driver bind to it, so that we automatically load the
>  v4l2 module after VCHI loads.
>
> +5) Remove overlay support.
> +
> +We advertise support for a V4L2 overlay implemented through the
> +ril.video_render component. This component is non-functional with an
> +upstream kernel since the VC4 DRM driver controls the HVS, not the
> +firmware. Once we have dma-buf support, the same functionality with
> +improved control can be achieved through the DRM interface. We should
> +therefore remove all V4L2 overlay functionality from the driver.
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: bcm2835-camera: Add TODO for removing overlay support
  2018-05-10 23:12 [PATCH] staging: bcm2835-camera: Add TODO for removing overlay support Stefan Schake
  2018-05-11  9:21 ` Dave Stevenson
@ 2018-05-14 11:59 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2018-05-14 11:59 UTC (permalink / raw)
  To: Stefan Schake
  Cc: stefan.wahren, devel, linux-kernel, eric, linux-rpi-kernel,
	dave.stevenson

On Fri, May 11, 2018 at 01:12:44AM +0200, Stefan Schake wrote:
> The overlay code is non-functional since it relies on firmware control
> of the HVS.
> 
> Signed-off-by: Stefan Schake <stschake@gmail.com>
> ---
> Dave, does this match your understanding?

This doesn't apply to my tree, can you rebase and resend?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-14 11:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-10 23:12 [PATCH] staging: bcm2835-camera: Add TODO for removing overlay support Stefan Schake
2018-05-11  9:21 ` Dave Stevenson
2018-05-14 11:59 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).