LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: sakari.ailus@linux.intel.com, mchehab@kernel.org,
gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
chen.chenchacha@foxmail.com, keescook@chromium.org,
arvind.yadav.cs@gmail.com, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] media: staging: atomisp: Fix an error handling path in 'lm3554_probe()'
Date: Fri, 11 May 2018 16:31:11 +0100 [thread overview]
Message-ID: <1526052671.26291.58.camel@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1805111709390.20118@hadrien>
On Fri, 2018-05-11 at 17:09 +0200, Julia Lawall wrote:
>
> On Fri, 11 May 2018, Christophe JAILLET wrote:
>
> > The use of 'fail1' and 'fail2' is not correct. Reorder these calls
> > to
> > branch at the right place of the error handling path.
>
> Maybe it would be good to improve the names at the same time?
Its scheduled for deletion - please don't bother.
Alan
next prev parent reply other threads:[~2018-05-11 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 15:06 [PATCH 0/3] media: staging: atomisp: Christophe JAILLET
2018-05-11 15:06 ` [PATCH 1/3] media: staging: atomisp: Return an error code in case of error in 'lm3554_probe()' Christophe JAILLET
2018-05-11 15:06 ` [PATCH 2/3] media: staging: atomisp: Fix an error handling path " Christophe JAILLET
2018-05-11 15:09 ` Julia Lawall
2018-05-11 15:31 ` Alan Cox [this message]
2018-05-11 15:06 ` [PATCH 3/3] media: staging: atomisp: Fix usage of 'media_entity_cleanup()' Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526052671.26291.58.camel@linux.intel.com \
--to=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=chen.chenchacha@foxmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--subject='Re: [PATCH 2/3] media: staging: atomisp: Fix an error handling path in '\''lm3554_probe()'\''' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).