LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Fenghua Yu <fenghua.yu@intel.com> To: "Thomas Gleixner" <tglx@linutronix.de>, "Ingo Molnar" <mingo@elte.hu>, "H. Peter Anvin" <hpa@linux.intel.com>, "Ashok Raj" <ashok.raj@intel.com>, "Ravi V Shankar" <ravi.v.shankar@intel.com>, "Tony Luck" <tony.luck@intel.com>, "Dave Hansen" <dave.hansen@intel.com>, "Rafael Wysocki" <rafael.j.wysocki@intel.com>, "Arjan van de Ven" <arjan@infradead.org>, "Alan Cox" <alan@linux.intel.com> Cc: "x86" <x86@kernel.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com> Subject: [PATCH 12/15] x86/split_lock: Add sysfs interface to show and control BIOS split lock setting Date: Mon, 14 May 2018 11:52:22 -0700 [thread overview] Message-ID: <1526323945-211107-13-git-send-email-fenghua.yu@intel.com> (raw) In-Reply-To: <1526323945-211107-1-git-send-email-fenghua.yu@intel.com> By default, the split lock BIOS setting inherits from BIOS setting before kernel boots. The sysfs interface /sys/kernel/split_lock/bios shows the BIOS split lock setting: 0 for disabled and 1 for enabled. User can override the BIOS setting by writing 1 to enable split lock in BIOS and write 0 to disable split lock in BIOS. When control flow comes to BIOS (e.g. in S3, S4, S5, and EFI runtime), kernel sets the BIOS setting and restores to kernel setting after coming back to kernel. In cases (e.g. real time) user wants to identify split lock cases in BIOS even when there is no BIOS setting before kernel boot, the user may explicitly enable split lock for BIOS. Getting bang whenever there is a split lock in BIOS helps identify and fix the BIOS split lock issue. Please note: System Management Mode (SMM) is out of control of kernel. So this interface cannot control split lock in SMM. Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> --- arch/x86/kernel/cpu/split_lock.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/arch/x86/kernel/cpu/split_lock.c b/arch/x86/kernel/cpu/split_lock.c index 02b461c48b3c..020af331594d 100644 --- a/arch/x86/kernel/cpu/split_lock.c +++ b/arch/x86/kernel/cpu/split_lock.c @@ -411,9 +411,43 @@ user_mode_store(struct kobject *kobj, struct kobj_attribute *attr, static struct kobj_attribute split_lock_ac_user = __ATTR_RW(user_mode); +static ssize_t +bios_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) +{ + return sprintf(buf, "%u\n", split_lock_ac_bios); +} + +static ssize_t +bios_store(struct kobject *kobj, struct kobj_attribute *attr, + const char *buf, size_t count) +{ + u32 val; + int ret; + + ret = kstrtou32(buf, 10, &val); + if (ret) + return ret; + + if (val != DISABLE_SPLIT_LOCK_AC && val != ENABLE_SPLIT_LOCK_AC) + return -EINVAL; + + /* No need to update setting if new setting is the same as old one. */ + if (val == split_lock_ac_bios) + return count; + + mutex_lock(&split_lock_mutex); + split_lock_ac_bios = val; + mutex_unlock(&split_lock_mutex); + + return count; +} + +static struct kobj_attribute split_lock_ac_bios_enable = __ATTR_RW(bios); + static struct attribute *split_lock_attrs[] = { &split_lock_ac_enable.attr, &split_lock_ac_user.attr, + &split_lock_ac_bios_enable.attr, NULL, }; -- 2.5.0
next prev parent reply other threads:[~2018-05-14 18:53 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-14 18:52 [PATCH 0/15] x86/split_lock: Enable #AC exception for split locked accesses Fenghua Yu 2018-05-14 18:52 ` [PATCH 01/15] x86/split_lock: Add CONFIG and enumerate #AC exception for split locked access feature Fenghua Yu 2018-05-15 15:36 ` Dave Hansen 2018-05-15 15:41 ` Fenghua Yu 2018-05-15 15:54 ` Dave Hansen 2018-05-14 18:52 ` [PATCH 02/15] x86/split_lock: Set up #AC exception for split locked accesses Fenghua Yu 2018-05-14 18:52 ` [PATCH 03/15] x86/split_lock: Handle #AC exception for split lock in kernel mode Fenghua Yu 2018-05-15 15:51 ` Dave Hansen 2018-05-15 16:35 ` Luck, Tony 2018-05-15 17:21 ` Fenghua Yu 2018-05-16 16:44 ` Dave Hansen 2018-05-16 21:35 ` Fenghua Yu 2018-05-14 18:52 ` [PATCH 04/15] x86/split_lock: Use non locked bit set instruction in set_cpu_cap Fenghua Yu 2018-05-14 18:52 ` [PATCH 05/15] x86/split_lock: Use non atomic set and clear bit instructions to clear cpufeature Fenghua Yu 2018-05-14 18:52 ` [PATCH 06/15] x86/split_lock: Save #AC setting for split lock in BIOS in boot time and restore the setting in reboot Fenghua Yu 2018-05-14 18:52 ` [PATCH 07/15] x86/split_lock: Handle suspend/hibernate and resume Fenghua Yu 2018-05-14 21:42 ` Rafael J. Wysocki 2018-05-14 18:52 ` [PATCH 08/15] x86/split_lock: Set split lock during EFI runtime service Fenghua Yu 2018-05-14 18:52 ` [PATCH 09/15] x86/split_lock: Explicitly enable or disable #AC for split locked accesses Fenghua Yu 2018-05-15 16:15 ` Dave Hansen 2018-05-15 17:29 ` Fenghua Yu 2018-05-16 16:37 ` Dave Hansen 2018-05-14 18:52 ` [PATCH 10/15] x86/split_lock: Add a sysfs interface to allow user to enable or disable split lock during run time Fenghua Yu 2018-05-14 18:52 ` [PATCH 11/15] x86/split_lock: Add sysfs interface to control user mode behavior Fenghua Yu 2018-05-14 18:52 ` Fenghua Yu [this message] 2018-05-14 18:52 ` [PATCH 13/15] x86/split_lock: Trace #AC exception for split lock Fenghua Yu 2018-05-14 18:52 ` [PATCH 14/15] x86/split_lock: Add CONFIG and testing sysfs interface Fenghua Yu 2018-05-14 18:52 ` [PATCH 15/15] x86/split_lock: Add split lock user space test in selftest Fenghua Yu 2018-05-15 15:10 ` [PATCH 0/15] x86/split_lock: Enable #AC exception for split locked accesses Dave Hansen 2018-05-15 16:26 ` Alan Cox 2018-05-15 16:30 ` Dave Hansen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1526323945-211107-13-git-send-email-fenghua.yu@intel.com \ --to=fenghua.yu@intel.com \ --cc=alan@linux.intel.com \ --cc=arjan@infradead.org \ --cc=ashok.raj@intel.com \ --cc=dave.hansen@intel.com \ --cc=hpa@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=rafael.j.wysocki@intel.com \ --cc=ravi.v.shankar@intel.com \ --cc=tglx@linutronix.de \ --cc=tony.luck@intel.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).