LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Fenghua Yu <fenghua.yu@intel.com> To: "Thomas Gleixner" <tglx@linutronix.de>, "Ingo Molnar" <mingo@elte.hu>, "H. Peter Anvin" <hpa@linux.intel.com>, "Ashok Raj" <ashok.raj@intel.com>, "Ravi V Shankar" <ravi.v.shankar@intel.com>, "Tony Luck" <tony.luck@intel.com>, "Dave Hansen" <dave.hansen@intel.com>, "Rafael Wysocki" <rafael.j.wysocki@intel.com>, "Arjan van de Ven" <arjan@infradead.org>, "Alan Cox" <alan@linux.intel.com> Cc: "x86" <x86@kernel.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com> Subject: [PATCH 02/15] x86/split_lock: Set up #AC exception for split locked accesses Date: Mon, 14 May 2018 11:52:12 -0700 [thread overview] Message-ID: <1526323945-211107-3-git-send-email-fenghua.yu@intel.com> (raw) In-Reply-To: <1526323945-211107-1-git-send-email-fenghua.yu@intel.com> When bit 29 is set in Test Control MSR register 0x33, #AC exception is generated for split locked accesses at all CPL. By default, kernel inherits the bit setting from BIOS. Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> --- arch/x86/include/asm/cpu.h | 2 ++ arch/x86/kernel/cpu/common.c | 2 ++ arch/x86/kernel/cpu/split_lock.c | 54 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 58 insertions(+) diff --git a/arch/x86/include/asm/cpu.h b/arch/x86/include/asm/cpu.h index c73b6d369047..b4fe6496bb15 100644 --- a/arch/x86/include/asm/cpu.h +++ b/arch/x86/include/asm/cpu.h @@ -42,7 +42,9 @@ unsigned int x86_model(unsigned int sig); unsigned int x86_stepping(unsigned int sig); #ifdef CONFIG_SPLIT_LOCK_AC int __init enumerate_split_lock(void); +void setup_split_lock(void); #else /* CONFIG_SPLIT_LOCK_AC */ static inline int enumerate_split_lock(void) { return 0; } +static inline void setup_split_lock(void) {} #endif /* CONFIG_SPLIT_LOCK_AC */ #endif /* _ASM_X86_CPU_H */ diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 7684e82e254f..daff18ef4f8f 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1304,6 +1304,8 @@ static void identify_cpu(struct cpuinfo_x86 *c) /* Init Machine Check Exception if available. */ mcheck_cpu_init(c); + setup_split_lock(); + select_idle_routine(c); #ifdef CONFIG_NUMA diff --git a/arch/x86/kernel/cpu/split_lock.c b/arch/x86/kernel/cpu/split_lock.c index 2ab28419e080..98bbfb176cf4 100644 --- a/arch/x86/kernel/cpu/split_lock.c +++ b/arch/x86/kernel/cpu/split_lock.c @@ -15,6 +15,11 @@ static bool split_lock_ac_supported; +#define DISABLE_SPLIT_LOCK_AC 0 +#define ENABLE_SPLIT_LOCK_AC 1 + +static int split_lock_ac = DISABLE_SPLIT_LOCK_AC; + /* * On processors not supporting #AC exception for split lock feature, * MSR_TEST_CTL may not exist or MSR_TEST_CTL exists but the bit 29 is @@ -58,5 +63,54 @@ void __init enumerate_split_lock(void) */ wrmsr(MSR_TEST_CTL, l_orig, h); + /* Initialize split lock setting from previous BIOS setting. */ + if (l_orig & MSR_TEST_CTL_ENABLE_AC_SPLIT_LOCK) + split_lock_ac = ENABLE_SPLIT_LOCK_AC; + else + split_lock_ac = DISABLE_SPLIT_LOCK_AC; + pr_info("#AC exception for split locked accesses is supported\n"); } + +static bool _setup_split_lock(int split_lock_ac_val) +{ + u32 l, h; + + rdmsr(MSR_TEST_CTL, l, h); + + /* No need to update MSR if same value. */ + if ((l >> MSR_TEST_CTL_ENABLE_AC_SPLIT_LOCK_SHIFT & 0x1) == + split_lock_ac_val) + goto out; + + if (split_lock_ac_val == ENABLE_SPLIT_LOCK_AC) + /* Set the split lock bit to enable the feature. */ + l |= MSR_TEST_CTL_ENABLE_AC_SPLIT_LOCK; + else if (split_lock_ac_val == DISABLE_SPLIT_LOCK_AC) + /* Clear the split lock bit to disable the feature. */ + l &= ~MSR_TEST_CTL_ENABLE_AC_SPLIT_LOCK; + else + return false; + + wrmsr(MSR_TEST_CTL, l, h); +out: + return true; +} + +void setup_split_lock(void) +{ + if (!split_lock_ac_supported) + return; + + if (!_setup_split_lock(split_lock_ac)) + goto out_fail; + + pr_info_once("split lock #AC is %sd\n", + split_lock_ac == ENABLE_SPLIT_LOCK_AC ? "enable" + : "disable"); + + return; + +out_fail: + pr_warn("fail to set split lock #AC\n"); +} -- 2.5.0
next prev parent reply other threads:[~2018-05-14 18:55 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-14 18:52 [PATCH 0/15] x86/split_lock: Enable #AC exception for split locked accesses Fenghua Yu 2018-05-14 18:52 ` [PATCH 01/15] x86/split_lock: Add CONFIG and enumerate #AC exception for split locked access feature Fenghua Yu 2018-05-15 15:36 ` Dave Hansen 2018-05-15 15:41 ` Fenghua Yu 2018-05-15 15:54 ` Dave Hansen 2018-05-14 18:52 ` Fenghua Yu [this message] 2018-05-14 18:52 ` [PATCH 03/15] x86/split_lock: Handle #AC exception for split lock in kernel mode Fenghua Yu 2018-05-15 15:51 ` Dave Hansen 2018-05-15 16:35 ` Luck, Tony 2018-05-15 17:21 ` Fenghua Yu 2018-05-16 16:44 ` Dave Hansen 2018-05-16 21:35 ` Fenghua Yu 2018-05-14 18:52 ` [PATCH 04/15] x86/split_lock: Use non locked bit set instruction in set_cpu_cap Fenghua Yu 2018-05-14 18:52 ` [PATCH 05/15] x86/split_lock: Use non atomic set and clear bit instructions to clear cpufeature Fenghua Yu 2018-05-14 18:52 ` [PATCH 06/15] x86/split_lock: Save #AC setting for split lock in BIOS in boot time and restore the setting in reboot Fenghua Yu 2018-05-14 18:52 ` [PATCH 07/15] x86/split_lock: Handle suspend/hibernate and resume Fenghua Yu 2018-05-14 21:42 ` Rafael J. Wysocki 2018-05-14 18:52 ` [PATCH 08/15] x86/split_lock: Set split lock during EFI runtime service Fenghua Yu 2018-05-14 18:52 ` [PATCH 09/15] x86/split_lock: Explicitly enable or disable #AC for split locked accesses Fenghua Yu 2018-05-15 16:15 ` Dave Hansen 2018-05-15 17:29 ` Fenghua Yu 2018-05-16 16:37 ` Dave Hansen 2018-05-14 18:52 ` [PATCH 10/15] x86/split_lock: Add a sysfs interface to allow user to enable or disable split lock during run time Fenghua Yu 2018-05-14 18:52 ` [PATCH 11/15] x86/split_lock: Add sysfs interface to control user mode behavior Fenghua Yu 2018-05-14 18:52 ` [PATCH 12/15] x86/split_lock: Add sysfs interface to show and control BIOS split lock setting Fenghua Yu 2018-05-14 18:52 ` [PATCH 13/15] x86/split_lock: Trace #AC exception for split lock Fenghua Yu 2018-05-14 18:52 ` [PATCH 14/15] x86/split_lock: Add CONFIG and testing sysfs interface Fenghua Yu 2018-05-14 18:52 ` [PATCH 15/15] x86/split_lock: Add split lock user space test in selftest Fenghua Yu 2018-05-15 15:10 ` [PATCH 0/15] x86/split_lock: Enable #AC exception for split locked accesses Dave Hansen 2018-05-15 16:26 ` Alan Cox 2018-05-15 16:30 ` Dave Hansen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1526323945-211107-3-git-send-email-fenghua.yu@intel.com \ --to=fenghua.yu@intel.com \ --cc=alan@linux.intel.com \ --cc=arjan@infradead.org \ --cc=ashok.raj@intel.com \ --cc=dave.hansen@intel.com \ --cc=hpa@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=rafael.j.wysocki@intel.com \ --cc=ravi.v.shankar@intel.com \ --cc=tglx@linutronix.de \ --cc=tony.luck@intel.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).