LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: airlied@linux.ie, hans.verkuil@cisco.com, lee.jones@linaro.org,
olof@lixom.net, seanpaul@google.com
Cc: Neil Armstrong <narmstrong@baylibre.com>,
sadolfsson@google.com, felixe@google.com, bleung@google.com,
darekm@google.com, marcheu@chromium.org, fparent@baylibre.com,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 1/5] mfd: cros_ec_dev: Add CEC sub-device registration
Date: Tue, 15 May 2018 00:40:35 +0200 [thread overview]
Message-ID: <1526337639-3568-2-git-send-email-narmstrong@baylibre.com> (raw)
In-Reply-To: <1526337639-3568-1-git-send-email-narmstrong@baylibre.com>
The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device
when the CEC feature bit is present.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/mfd/cros_ec_dev.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index eafd06f..57064ec 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -383,6 +383,18 @@ static void cros_ec_sensors_register(struct cros_ec_dev *ec)
kfree(msg);
}
+static void cros_ec_cec_register(struct cros_ec_dev *ec)
+{
+ int ret;
+ struct mfd_cell cec_cell = {
+ .name = "cros-ec-cec",
+ };
+
+ ret = mfd_add_devices(ec->dev, 0, &cec_cell, 1, NULL, 0, NULL);
+ if (ret)
+ dev_err(ec->dev, "failed to add EC CEC\n");
+}
+
static int ec_device_probe(struct platform_device *pdev)
{
int retval = -ENOMEM;
@@ -422,6 +434,10 @@ static int ec_device_probe(struct platform_device *pdev)
if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE))
cros_ec_sensors_register(ec);
+ /* check whether this EC handles CEC. */
+ if (cros_ec_check_features(ec, EC_FEATURE_CEC))
+ cros_ec_cec_register(ec);
+
/* Take control of the lightbar from the EC. */
lb_manual_suspend_ctrl(ec, 1);
--
2.7.4
next prev parent reply other threads:[~2018-05-14 22:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 22:40 [RFC PATCH 0/5] Add ChromeOS EC CEC Support Neil Armstrong
2018-05-14 22:40 ` Neil Armstrong [this message]
2018-05-14 22:40 ` [RFC PATCH 2/5] media: cec-notifier: Get notifier by device and connector name Neil Armstrong
2018-05-15 6:27 ` Hans Verkuil
2018-05-15 7:28 ` Neil Armstrong
2018-05-14 22:40 ` [RFC PATCH 3/5] drm/i915: hdmi: add CEC notifier to intel_hdmi Neil Armstrong
2018-05-15 6:29 ` Hans Verkuil
2018-05-15 7:30 ` Neil Armstrong
2018-05-15 6:34 ` Hans Verkuil
2018-05-15 7:29 ` Neil Armstrong
2018-05-14 22:40 ` [RFC PATCH 4/5] mfd: cros-ec: Introduce CEC commands and events definitions Neil Armstrong
2018-05-14 22:40 ` [RFC PATCH 5/5] media: platform: Add Chrome OS EC CEC driver Neil Armstrong
2018-05-15 6:58 ` Hans Verkuil
2018-05-15 7:25 ` Neil Armstrong
2018-05-15 8:10 ` Hans Verkuil
2018-05-15 8:28 ` Neil Armstrong
2018-05-15 8:30 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526337639-3568-2-git-send-email-narmstrong@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=airlied@linux.ie \
--cc=bleung@google.com \
--cc=darekm@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=felixe@google.com \
--cc=fparent@baylibre.com \
--cc=hans.verkuil@cisco.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marcheu@chromium.org \
--cc=olof@lixom.net \
--cc=sadolfsson@google.com \
--cc=seanpaul@google.com \
--subject='Re: [RFC PATCH 1/5] mfd: cros_ec_dev: Add CEC sub-device registration' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).