LKML Archive on
help / color / mirror / Atom feed
From: "Tobin C. Harding" <>
To: "Theodore Ts'o" <>
Cc: "Tobin C. Harding" <>,
	Linus Torvalds <>,
	Randy Dunlap <>,
	Steven Rostedt <>,
	Kees Cook <>,
	Anna-Maria Gleixner <>,
	Andrew Morton <>,
	Greg Kroah-Hartman <>,
	Arnd Bergmann <>,
Subject: [PATCH v4 0/3] enable early printing of hashed pointers
Date: Tue, 15 May 2018 13:06:23 +1000	[thread overview]
Message-ID: <> (raw)

Currently if an attempt is made to print a pointer before there is
enough entropy then '(____ptrval____)' is printed.  This makes debugging
stack traces during early boot difficult.

One partial solution to this problem is to use the hw RNG if it is

This version drops the final patch from the series to facilitate 
merge via Ted's tree.

Ted are you able to take these patches please?

Patch 1 - Whitespace fixes.
Patch 2 - Fix get_random_bytes_arch()
Patch 3 - Use hw RNG for pointer hashing if available (by default).


v3 -> v4
 - remove last patch of series (command line option patch)

v2 -> v3
 - Add __ro_after_init (suggested by Kees).

v1 -> v2
 - Use min_t() instead of min() (thanks checkpatch).
 - Add __must_check to function declaration (thanks Steve).
 - Use hw RNG by default if available (as originally suggested by Kees).
 - Add command line option to use cryptographically insecure hashing.
   If debug_early_boot is enabled use hash_long() instead of siphash
   (as requested by Steve, and solves original problem for Anna-Maria).

Tobin C. Harding (3):
  random: Fix whitespace pre random-bytes work
  random: Return nbytes filled from hw RNG
  vsprintf: Use hw RNG for ptr_key

 drivers/char/random.c  | 19 ++++++++++---------
 include/linux/random.h |  2 +-
 lib/vsprintf.c         | 19 ++++++++++++++++---
 3 files changed, 27 insertions(+), 13 deletions(-)


             reply	other threads:[~2018-05-15  3:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15  3:06 Tobin C. Harding [this message]
2018-05-15  3:06 ` [PATCH v4 1/3] random: Fix whitespace pre random-bytes work Tobin C. Harding
2018-05-15  3:06 ` [PATCH v4 2/3] random: Return nbytes filled from hw RNG Tobin C. Harding
2018-05-15 13:37   ` Steven Rostedt
2018-05-15 21:17     ` Tobin C. Harding
2018-05-15 21:35       ` Steven Rostedt
2018-05-15 22:26         ` Tobin C. Harding
2018-05-15  3:06 ` [PATCH v4 3/3] vsprintf: Use hw RNG for ptr_key Tobin C. Harding
2018-05-15 13:47   ` Steven Rostedt
2018-05-15 21:09     ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v4 0/3] enable early printing of hashed pointers' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).