LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] crypto: reorder paes test lexicographically
@ 2018-05-11 8:04 Gilad Ben-Yossef
2018-05-15 13:53 ` Abdul Haleem
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gilad Ben-Yossef @ 2018-05-11 8:04 UTC (permalink / raw)
To: Abdul Haleem, Herbert Xu, David S. Miller
Cc: Ofir Drang, linux-next, Stephen Rothwell, sachinp, linuxppc-dev,
linux-crypto, linux-kernel
Due to a snafu "paes" testmgr tests were not ordered
lexicographically, which led to boot time warnings.
Reorder the tests as needed.
Fixes: a794d8d ("crypto: ccree - enable support for hardware keys")
Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
---
crypto/testmgr.c | 44 ++++++++++++++++++++++----------------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index c31da0f..b1b8ebb 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -3012,13 +3012,6 @@ static const struct alg_test_desc alg_test_descs[] = {
}
}
}, {
- /* Same as ecb(aes) except the key is stored in
- * hardware secure memory which we reference by index
- */
- .alg = "ecb(paes)",
- .test = alg_test_null,
- .fips_allowed = 1,
- }, {
.alg = "ecb(khazad)",
.test = alg_test_skcipher,
.suite = {
@@ -3028,6 +3021,13 @@ static const struct alg_test_desc alg_test_descs[] = {
}
}
}, {
+ /* Same as ecb(aes) except the key is stored in
+ * hardware secure memory which we reference by index
+ */
+ .alg = "ecb(paes)",
+ .test = alg_test_null,
+ .fips_allowed = 1,
+ }, {
.alg = "ecb(seed)",
.test = alg_test_skcipher,
.suite = {
@@ -3610,21 +3610,6 @@ static const struct alg_test_desc alg_test_descs[] = {
}
}
}, {
- /* Same as xts(aes) except the key is stored in
- * hardware secure memory which we reference by index
- */
- .alg = "xts(paes)",
- .test = alg_test_null,
- .fips_allowed = 1,
- }, {
- .alg = "xts4096(paes)",
- .test = alg_test_null,
- .fips_allowed = 1,
- }, {
- .alg = "xts512(paes)",
- .test = alg_test_null,
- .fips_allowed = 1,
- }, {
.alg = "xts(camellia)",
.test = alg_test_skcipher,
.suite = {
@@ -3643,6 +3628,13 @@ static const struct alg_test_desc alg_test_descs[] = {
}
}
}, {
+ /* Same as xts(aes) except the key is stored in
+ * hardware secure memory which we reference by index
+ */
+ .alg = "xts(paes)",
+ .test = alg_test_null,
+ .fips_allowed = 1,
+ }, {
.alg = "xts(serpent)",
.test = alg_test_skcipher,
.suite = {
@@ -3679,6 +3671,14 @@ static const struct alg_test_desc alg_test_descs[] = {
}
}
}, {
+ .alg = "xts4096(paes)",
+ .test = alg_test_null,
+ .fips_allowed = 1,
+ }, {
+ .alg = "xts512(paes)",
+ .test = alg_test_null,
+ .fips_allowed = 1,
+ }, {
.alg = "zlib-deflate",
.test = alg_test_comp,
.fips_allowed = 1,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: reorder paes test lexicographically
2018-05-11 8:04 [PATCH] crypto: reorder paes test lexicographically Gilad Ben-Yossef
@ 2018-05-15 13:53 ` Abdul Haleem
2018-05-17 8:14 ` Corentin Labbe
2018-05-18 18:21 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Abdul Haleem @ 2018-05-15 13:53 UTC (permalink / raw)
To: Gilad Ben-Yossef
Cc: Herbert Xu, David S. Miller, sachinp, Stephen Rothwell,
linux-kernel, linux-next, linux-crypto, linuxppc-dev, Ofir Drang
On Fri, 2018-05-11 at 09:04 +0100, Gilad Ben-Yossef wrote:
> Due to a snafu "paes" testmgr tests were not ordered
> lexicographically, which led to boot time warnings.
> Reorder the tests as needed.
>
> Fixes: a794d8d ("crypto: ccree - enable support for hardware keys")
> Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> ---
> crypto/testmgr.c | 44 ++++++++++++++++++++++----------------------
> 1 file changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index c31da0f..b1b8ebb 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -3012,13 +3012,6 @@ static const struct alg_test_desc alg_test_descs[] = {
> }
> }
> }, {
> - /* Same as ecb(aes) except the key is stored in
> - * hardware secure memory which we reference by index
> - */
> - .alg = "ecb(paes)",
> - .test = alg_test_null,
> - .fips_allowed = 1,
> - }, {
> .alg = "ecb(khazad)",
> .test = alg_test_skcipher,
> .suite = {
> @@ -3028,6 +3021,13 @@ static const struct alg_test_desc alg_test_descs[] = {
> }
> }
> }, {
> + /* Same as ecb(aes) except the key is stored in
> + * hardware secure memory which we reference by index
> + */
> + .alg = "ecb(paes)",
> + .test = alg_test_null,
> + .fips_allowed = 1,
> + }, {
> .alg = "ecb(seed)",
> .test = alg_test_skcipher,
> .suite = {
> @@ -3610,21 +3610,6 @@ static const struct alg_test_desc alg_test_descs[] = {
> }
> }
> }, {
> - /* Same as xts(aes) except the key is stored in
> - * hardware secure memory which we reference by index
> - */
> - .alg = "xts(paes)",
> - .test = alg_test_null,
> - .fips_allowed = 1,
> - }, {
> - .alg = "xts4096(paes)",
> - .test = alg_test_null,
> - .fips_allowed = 1,
> - }, {
> - .alg = "xts512(paes)",
> - .test = alg_test_null,
> - .fips_allowed = 1,
> - }, {
> .alg = "xts(camellia)",
> .test = alg_test_skcipher,
> .suite = {
> @@ -3643,6 +3628,13 @@ static const struct alg_test_desc alg_test_descs[] = {
> }
> }
> }, {
> + /* Same as xts(aes) except the key is stored in
> + * hardware secure memory which we reference by index
> + */
> + .alg = "xts(paes)",
> + .test = alg_test_null,
> + .fips_allowed = 1,
> + }, {
> .alg = "xts(serpent)",
> .test = alg_test_skcipher,
> .suite = {
> @@ -3679,6 +3671,14 @@ static const struct alg_test_desc alg_test_descs[] = {
> }
> }
> }, {
> + .alg = "xts4096(paes)",
> + .test = alg_test_null,
> + .fips_allowed = 1,
> + }, {
> + .alg = "xts512(paes)",
> + .test = alg_test_null,
> + .fips_allowed = 1,
> + }, {
> .alg = "zlib-deflate",
> .test = alg_test_comp,
> .fips_allowed = 1,
Gilad,
The given patch fixes the boot warnings.
Tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Thanks for the fix.
--
Regard's
Abdul Haleem
IBM Linux Technology Centre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: reorder paes test lexicographically
2018-05-11 8:04 [PATCH] crypto: reorder paes test lexicographically Gilad Ben-Yossef
2018-05-15 13:53 ` Abdul Haleem
@ 2018-05-17 8:14 ` Corentin Labbe
2018-05-18 18:21 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Corentin Labbe @ 2018-05-17 8:14 UTC (permalink / raw)
To: Gilad Ben-Yossef
Cc: Abdul Haleem, Herbert Xu, David S. Miller, Ofir Drang,
linux-next, Stephen Rothwell, sachinp, linuxppc-dev,
linux-crypto, linux-kernel
On Fri, May 11, 2018 at 09:04:06AM +0100, Gilad Ben-Yossef wrote:
> Due to a snafu "paes" testmgr tests were not ordered
> lexicographically, which led to boot time warnings.
> Reorder the tests as needed.
>
> Fixes: a794d8d ("crypto: ccree - enable support for hardware keys")
> Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: reorder paes test lexicographically
2018-05-11 8:04 [PATCH] crypto: reorder paes test lexicographically Gilad Ben-Yossef
2018-05-15 13:53 ` Abdul Haleem
2018-05-17 8:14 ` Corentin Labbe
@ 2018-05-18 18:21 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2018-05-18 18:21 UTC (permalink / raw)
To: Gilad Ben-Yossef
Cc: Abdul Haleem, David S. Miller, Ofir Drang, linux-next,
Stephen Rothwell, sachinp, linuxppc-dev, linux-crypto,
linux-kernel
On Fri, May 11, 2018 at 09:04:06AM +0100, Gilad Ben-Yossef wrote:
> Due to a snafu "paes" testmgr tests were not ordered
> lexicographically, which led to boot time warnings.
> Reorder the tests as needed.
>
> Fixes: a794d8d ("crypto: ccree - enable support for hardware keys")
> Reported-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-18 18:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-11 8:04 [PATCH] crypto: reorder paes test lexicographically Gilad Ben-Yossef
2018-05-15 13:53 ` Abdul Haleem
2018-05-17 8:14 ` Corentin Labbe
2018-05-18 18:21 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).