LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Joel Fernandes <joel.opensrc@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Chris Zankel <chris@zankel.net>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will.deacon@arm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Rich Felker <dalias@libc.org>, Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Max Filippov <jcmvbkbc@gmail.com>
Subject: [PATCH 00/12] breakpoint: Rework arch validation v2
Date: Sat, 19 May 2018 04:45:37 +0200 [thread overview]
Message-ID: <1526697950-7091-1-git-send-email-frederic@kernel.org> (raw)
Changes since v1:
- Avoid arch code duplication between check and commit. Use a temporary
struct arch_hw_breakpoint to fill up arch data on the fly
(Mark Rutland)
- Start with a default weak version of hw_breakpoint_arch_parse() that
architectures override one by one (Peter Zijlstra, Andy Lutomirski)
git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
perf/breakpoint-v2
HEAD: a350174ed8f7240b91ae46933bfe2274d3d03806
--- Summary ---
When we modify a hardware breakpoint, the architecture code fills up
the architecture data as the validation of generic attributes progresses.
If something goes wrong in the middle, the architecture data changes
aren't rolled back and we are left with a halfway fiddled breakpoint.
This set fixes the various misdesigns that back this bad behaviour.
Thanks,
Frederic
---
Frederic Weisbecker (12):
perf/breakpoint: Split attribute parse and commit
perf/breakpoint: Pass arch breakpoint struct to arch_check_bp_in_kernelspace()
x86: Implement hw_breakpoint_arch_parse()
powerpc: Implement hw_breakpoint_arch_parse()
arm: Implement hw_breakpoint_arch_parse()
arm64: Implement hw_breakpoint_arch_parse()
sh: Remove "struct arch_hw_breakpoint::name" unused field
sh: Implement hw_breakpoint_arch_parse()
xtensa: Implement hw_breakpoint_arch_parse()
perf/breakpoint: Remove default hw_breakpoint_arch_parse()
perf/breakpoint: Pass new breakpoint type to modify_breakpoint_slot()
perf/breakpoint: Clean up and consolidate modify_user_hw_breakpoint_check()
arch/arm/include/asm/hw_breakpoint.h | 7 +-
arch/arm/kernel/hw_breakpoint.c | 78 +++++++++---------
arch/arm64/include/asm/hw_breakpoint.h | 7 +-
arch/arm64/kernel/hw_breakpoint.c | 86 ++++++++++----------
arch/powerpc/include/asm/hw_breakpoint.h | 7 +-
arch/powerpc/kernel/hw_breakpoint.c | 47 ++++++-----
arch/sh/include/asm/hw_breakpoint.h | 8 +-
arch/sh/kernel/hw_breakpoint.c | 53 ++++++-------
arch/x86/include/asm/hw_breakpoint.h | 7 +-
arch/x86/kernel/hw_breakpoint.c | 131 ++++++++++++++++---------------
arch/xtensa/include/asm/hw_breakpoint.h | 7 +-
arch/xtensa/kernel/hw_breakpoint.c | 40 ++++------
kernel/events/hw_breakpoint.c | 92 +++++++++++++---------
13 files changed, 294 insertions(+), 276 deletions(-)
next reply other threads:[~2018-05-19 2:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-19 2:45 Frederic Weisbecker [this message]
2018-05-19 2:45 ` [PATCH 01/12] perf/breakpoint: Split attribute parse and commit Frederic Weisbecker
2018-05-24 1:56 ` Michael Ellerman
2018-05-25 13:58 ` Frederic Weisbecker
2018-05-28 11:29 ` Michael Ellerman
2018-05-19 2:45 ` [PATCH 02/12] perf/breakpoint: Pass arch breakpoint struct to arch_check_bp_in_kernelspace() Frederic Weisbecker
2018-05-19 2:45 ` [PATCH 03/12] x86: Implement hw_breakpoint_arch_parse() Frederic Weisbecker
2018-05-19 2:45 ` [PATCH 04/12] powerpc: " Frederic Weisbecker
2018-05-24 2:01 ` Michael Ellerman
2018-05-25 14:05 ` Frederic Weisbecker
2018-05-28 11:31 ` Michael Ellerman
2018-06-01 14:46 ` Frederic Weisbecker
2018-06-05 11:06 ` Michael Ellerman
2018-05-19 2:45 ` [PATCH 05/12] arm: " Frederic Weisbecker
2018-05-25 12:18 ` Mark Rutland
2018-05-19 2:45 ` [PATCH 06/12] arm64: " Frederic Weisbecker
2018-05-23 15:23 ` Will Deacon
2018-05-25 12:18 ` Mark Rutland
2018-05-19 2:45 ` [PATCH 07/12] sh: Remove "struct arch_hw_breakpoint::name" unused field Frederic Weisbecker
2018-05-19 2:45 ` [PATCH 08/12] sh: Implement hw_breakpoint_arch_parse() Frederic Weisbecker
2018-05-19 2:45 ` [PATCH 09/12] xtensa: " Frederic Weisbecker
2018-05-19 2:45 ` [PATCH 10/12] perf/breakpoint: Remove default hw_breakpoint_arch_parse() Frederic Weisbecker
2018-05-19 2:45 ` [PATCH 11/12] perf/breakpoint: Pass new breakpoint type to modify_breakpoint_slot() Frederic Weisbecker
2018-05-19 2:45 ` [PATCH 12/12] perf/breakpoint: Clean up and consolidate modify_user_hw_breakpoint_check() Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526697950-7091-1-git-send-email-frederic@kernel.org \
--to=frederic@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=jcmvbkbc@gmail.com \
--cc=joel.opensrc@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).