LKML Archive on
help / color / mirror / Atom feed
* [PATCH] autofs: make autofs4 and autofs mutually exclusive
@ 2018-05-29  9:46 Arnd Bergmann
  2018-05-30  0:48 ` Ian Kent
  0 siblings, 1 reply; 8+ messages in thread
From: Arnd Bergmann @ 2018-05-29  9:46 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Arnd Bergmann, Ian Kent, Mark Brown, linux-kernel

The autofs4 implementation is just a redirect to autofs now, but that
also means we can't have both built into the same kernel:

fs/autofs/inode.o: In function `autofs_new_ino':
inode.c:(.text+0x1b8): multiple definition of `autofs_new_ino'
fs/autofs/inode.o:inode.c:(.text+0x1b8): first defined here
fs/autofs/inode.o: In function `autofs_clean_ino':
inode.c:(.text+0x288): multiple definition of `autofs_clean_ino'

There is also a problem with trying to build both in parallel, which
leads to two 'make' processes writing to the same fs/autofs/.*.o.cmd
file, causing corruption that manifests like

fs/autofs4/../autofs/.expire.o.cmd:679: *** missing separator.  Stop.

Making AUTOFS4_FS depend on AUTOFS_FS being disabled should avoid all
configurations that run into either issue.

Fixes: mmotm ("autofs: update fs/autofs4/Makefile")
Signed-off-by: Arnd Bergmann <>
 fs/autofs4/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig
index 53bc592a250d..eccf673c6c8c 100644
--- a/fs/autofs4/Kconfig
+++ b/fs/autofs4/Kconfig
@@ -1,5 +1,6 @@
 config AUTOFS4_FS
 	tristate "Kernel automounter version 4 support (also supports v3 and v5)"
+	depends on AUTOFS_FS=n
 	default n
 	  The automounter is a tool to automatically mount remote file systems

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-06-01 23:12 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-29  9:46 [PATCH] autofs: make autofs4 and autofs mutually exclusive Arnd Bergmann
2018-05-30  0:48 ` Ian Kent
2018-05-30  8:41   ` Arnd Bergmann
2018-05-30  9:18     ` Ian Kent
2018-06-01  0:13       ` Andrew Morton
2018-06-01  1:35         ` Ian Kent
2018-06-01  8:42           ` Ian Kent
2018-06-01 23:12             ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).