[PATCH] erofs: remove the mapping parameter from erofs_try_to_free_cached_page()

[PATCH] erofs: remove the mapping parameter from erofs_try_to_free_cached_page()

[Yue Hu]

From: Yue Hu <huyue2@yulong.com>

The mapping is not used at all, remove it and update related code.

Signed-off-by: Yue Hu <huyue2@yulong.com>
---
 fs/erofs/internal.h | 3 +--
 fs/erofs/super.c    | 2 +-
 fs/erofs/zdata.c    | 3 +--
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index f92e3e3..e21b147 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -442,8 +442,7 @@ struct erofs_workgroup *erofs_insert_workgroup(struct super_block *sb,
 void z_erofs_exit_zip_subsystem(void);
 int erofs_try_to_free_all_cached_pages(struct erofs_sb_info *sbi,
 				       struct erofs_workgroup *egrp);
-int erofs_try_to_free_cached_page(struct address_space *mapping,
-				  struct page *page);
+int erofs_try_to_free_cached_page(struct page *page);
 int z_erofs_load_lz4_config(struct super_block *sb,
 			    struct erofs_super_block *dsb,
 			    struct z_erofs_lz4_cfgs *lz4, int len);
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index bbf3bbd..72fff34 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -430,7 +430,7 @@ static int erofs_managed_cache_releasepage(struct page *page, gfp_t gfp_mask)
 	DBG_BUGON(mapping->a_ops != &managed_cache_aops);
 
 	if (PagePrivate(page))
-		ret = erofs_try_to_free_cached_page(mapping, page);
+		ret = erofs_try_to_free_cached_page(page);
 
 	return ret;
 }
diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index a809730..c8e1594 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -337,8 +337,7 @@ int erofs_try_to_free_all_cached_pages(struct erofs_sb_info *sbi,
 	return 0;
 }
 
-int erofs_try_to_free_cached_page(struct address_space *mapping,
-				  struct page *page)
+int erofs_try_to_free_cached_page(struct page *page)
 {
 	struct z_erofs_pcluster *const pcl = (void *)page_private(page);
 	int ret = 0;	/* 0 - busy */
-- 
1.9.1

Re: [PATCH] erofs: remove the mapping parameter from erofs_try_to_free_cached_page()

[Gao Xiang]

On Tue, Aug 10, 2021 at 03:24:16PM +0800, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
> 
> The mapping is not used at all, remove it and update related code.
> 
> Signed-off-by: Yue Hu <huyue2@yulong.com>

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Thanks,
Gao Xiang

Re: [PATCH] erofs: remove the mapping parameter from erofs_try_to_free_cached_page()

[Chao Yu]

On 2021/8/10 15:24, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
> 
> The mapping is not used at all, remove it and update related code.
> 
> Signed-off-by: Yue Hu <huyue2@yulong.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,