LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 0/2] spi: fix incorrect property items
@ 2018-10-26  5:58 Keiji Hayashibara
  2018-10-26  5:58 ` [PATCH v2 1/2] spi: uniphier: " Keiji Hayashibara
  2018-10-26  5:58 ` [PATCH v2 2/2] spi: uniphier: re-add addressing properties Keiji Hayashibara
  0 siblings, 2 replies; 5+ messages in thread
From: Keiji Hayashibara @ 2018-10-26  5:58 UTC (permalink / raw)
  To: broonie, robh+dt, mark.rutland, yamada.masahiro, linux-spi,
	linux-arm-kernel, devicetree
  Cc: stable, masami.hiramatsu, jaswinder.singh, linux-kernel,
	hayashibara.keiji

This series fixes incorrect property because it was different
from the actual.

The commit 71b8dfc691a3 ("spi: uniphier: re-add addressing properties")
is the updated patch, therefore, it must be applied after
the commit 7662d1dc17d4 ("spi: uniphier: fix incorrect property items").

Changes since v1:
- Add commit 71b8dfc691a3 ("spi: uniphier: re-add addressing properties")
  The addressing properties of #address-cells and #size-cells
  are back again.

Keiji Hayashibara (2):
  spi: uniphier: fix incorrect property items
  spi: uniphier: re-add addressing properties

 Documentation/devicetree/bindings/spi/spi-uniphier.txt | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] spi: uniphier: fix incorrect property items
  2018-10-26  5:58 [PATCH v2 0/2] spi: fix incorrect property items Keiji Hayashibara
@ 2018-10-26  5:58 ` Keiji Hayashibara
  2018-10-26  5:58 ` [PATCH v2 2/2] spi: uniphier: re-add addressing properties Keiji Hayashibara
  1 sibling, 0 replies; 5+ messages in thread
From: Keiji Hayashibara @ 2018-10-26  5:58 UTC (permalink / raw)
  To: broonie, robh+dt, mark.rutland, yamada.masahiro, linux-spi,
	linux-arm-kernel, devicetree
  Cc: stable, masami.hiramatsu, jaswinder.singh, linux-kernel,
	hayashibara.keiji

This commit fixes incorrect property because it was different
from the actual.
The parameters of '#address-cells' and '#size-cells' were removed,
and 'interrupts', 'pinctrl-names' and 'pinctrl-0' were added.

Fixes: 4dcd5c2781f3 ("spi: add DT bindings for UniPhier SPI controller")
Signed-off-by: Keiji Hayashibara <hayashibara.keiji@socionext.com>
---
 Documentation/devicetree/bindings/spi/spi-uniphier.txt | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-uniphier.txt b/Documentation/devicetree/bindings/spi/spi-uniphier.txt
index 504a4ec..b04e66a 100644
--- a/Documentation/devicetree/bindings/spi/spi-uniphier.txt
+++ b/Documentation/devicetree/bindings/spi/spi-uniphier.txt
@@ -5,18 +5,20 @@ UniPhier SoCs have SCSSI which supports SPI single channel.
 Required properties:
  - compatible: should be "socionext,uniphier-scssi"
  - reg: address and length of the spi master registers
- - #address-cells: must be <1>, see spi-bus.txt
- - #size-cells: must be <0>, see spi-bus.txt
- - clocks: A phandle to the clock for the device.
- - resets: A phandle to the reset control for the device.
+ - interrupts: a single interrupt specifier
+ - pinctrl-names: should be "default"
+ - pinctrl-0: pin control state for the default mode
+ - clocks: a phandle to the clock for the device
+ - resets: a phandle to the reset control for the device
 
 Example:
 
 spi0: spi@54006000 {
 	compatible = "socionext,uniphier-scssi";
 	reg = <0x54006000 0x100>;
-	#address-cells = <1>;
-	#size-cells = <0>;
+	interrupts = <0 39 4>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_spi0>;
 	clocks = <&peri_clk 11>;
 	resets = <&peri_rst 11>;
 };
-- 
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] spi: uniphier: re-add addressing properties
  2018-10-26  5:58 [PATCH v2 0/2] spi: fix incorrect property items Keiji Hayashibara
  2018-10-26  5:58 ` [PATCH v2 1/2] spi: uniphier: " Keiji Hayashibara
@ 2018-10-26  5:58 ` Keiji Hayashibara
  2018-10-30 21:46   ` Rob Herring
  2018-11-05 12:01   ` Applied "spi: uniphier: re-add addressing properties" to the spi tree Mark Brown
  1 sibling, 2 replies; 5+ messages in thread
From: Keiji Hayashibara @ 2018-10-26  5:58 UTC (permalink / raw)
  To: broonie, robh+dt, mark.rutland, yamada.masahiro, linux-spi,
	linux-arm-kernel, devicetree
  Cc: stable, masami.hiramatsu, jaswinder.singh, linux-kernel,
	hayashibara.keiji

In commit 7662d1dc17d4 ("spi: uniphier: fix incorrect property items")
addressing properties of #address-cells and #size-cells were removed.
Since it is not necessary to remove them, they are back again.

Signed-off-by: Keiji Hayashibara <hayashibara.keiji@socionext.com>
---
 Documentation/devicetree/bindings/spi/spi-uniphier.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-uniphier.txt b/Documentation/devicetree/bindings/spi/spi-uniphier.txt
index b04e66a..e120157 100644
--- a/Documentation/devicetree/bindings/spi/spi-uniphier.txt
+++ b/Documentation/devicetree/bindings/spi/spi-uniphier.txt
@@ -5,6 +5,8 @@ UniPhier SoCs have SCSSI which supports SPI single channel.
 Required properties:
  - compatible: should be "socionext,uniphier-scssi"
  - reg: address and length of the spi master registers
+ - #address-cells: must be <1>, see spi-bus.txt
+ - #size-cells: must be <0>, see spi-bus.txt
  - interrupts: a single interrupt specifier
  - pinctrl-names: should be "default"
  - pinctrl-0: pin control state for the default mode
@@ -16,6 +18,8 @@ Example:
 spi0: spi@54006000 {
 	compatible = "socionext,uniphier-scssi";
 	reg = <0x54006000 0x100>;
+	#address-cells = <1>;
+	#size-cells = <0>;
 	interrupts = <0 39 4>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_spi0>;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] spi: uniphier: re-add addressing properties
  2018-10-26  5:58 ` [PATCH v2 2/2] spi: uniphier: re-add addressing properties Keiji Hayashibara
@ 2018-10-30 21:46   ` Rob Herring
  2018-11-05 12:01   ` Applied "spi: uniphier: re-add addressing properties" to the spi tree Mark Brown
  1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2018-10-30 21:46 UTC (permalink / raw)
  To: Keiji Hayashibara
  Cc: broonie, robh+dt, mark.rutland, yamada.masahiro, linux-spi,
	linux-arm-kernel, devicetree, stable, masami.hiramatsu,
	jaswinder.singh, linux-kernel, hayashibara.keiji

On Fri, 26 Oct 2018 14:58:45 +0900, Keiji Hayashibara wrote:
> In commit 7662d1dc17d4 ("spi: uniphier: fix incorrect property items")
> addressing properties of #address-cells and #size-cells were removed.
> Since it is not necessary to remove them, they are back again.
> 
> Signed-off-by: Keiji Hayashibara <hayashibara.keiji@socionext.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-uniphier.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Applied "spi: uniphier: re-add addressing properties" to the spi tree
  2018-10-26  5:58 ` [PATCH v2 2/2] spi: uniphier: re-add addressing properties Keiji Hayashibara
  2018-10-30 21:46   ` Rob Herring
@ 2018-11-05 12:01   ` Mark Brown
  1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2018-11-05 12:01 UTC (permalink / raw)
  To: Keiji Hayashibara
  Cc: Mark Brown, broonie, robh+dt, mark.rutland, yamada.masahiro,
	linux-spi, linux-arm-kernel, devicetree, stable,
	masami.hiramatsu, jaswinder.singh, linux-kernel,
	hayashibara.keiji, linux-spi

The patch

   spi: uniphier: re-add addressing properties

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 2a35a643f138a97e3bfee0c599c72e5ca80ebe7c Mon Sep 17 00:00:00 2001
From: Keiji Hayashibara <hayashibara.keiji@socionext.com>
Date: Fri, 26 Oct 2018 14:58:45 +0900
Subject: [PATCH] spi: uniphier: re-add addressing properties

In commit 7662d1dc17d4 ("spi: uniphier: fix incorrect property items")
addressing properties of #address-cells and #size-cells were removed.
Since it is not necessary to remove them, they are back again.

Signed-off-by: Keiji Hayashibara <hayashibara.keiji@socionext.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 Documentation/devicetree/bindings/spi/spi-uniphier.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-uniphier.txt b/Documentation/devicetree/bindings/spi/spi-uniphier.txt
index b04e66a52de5..e1201573a29a 100644
--- a/Documentation/devicetree/bindings/spi/spi-uniphier.txt
+++ b/Documentation/devicetree/bindings/spi/spi-uniphier.txt
@@ -5,6 +5,8 @@ UniPhier SoCs have SCSSI which supports SPI single channel.
 Required properties:
  - compatible: should be "socionext,uniphier-scssi"
  - reg: address and length of the spi master registers
+ - #address-cells: must be <1>, see spi-bus.txt
+ - #size-cells: must be <0>, see spi-bus.txt
  - interrupts: a single interrupt specifier
  - pinctrl-names: should be "default"
  - pinctrl-0: pin control state for the default mode
@@ -16,6 +18,8 @@ Example:
 spi0: spi@54006000 {
 	compatible = "socionext,uniphier-scssi";
 	reg = <0x54006000 0x100>;
+	#address-cells = <1>;
+	#size-cells = <0>;
 	interrupts = <0 39 4>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_spi0>;
-- 
2.19.0.rc2


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-11-05 12:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26  5:58 [PATCH v2 0/2] spi: fix incorrect property items Keiji Hayashibara
2018-10-26  5:58 ` [PATCH v2 1/2] spi: uniphier: " Keiji Hayashibara
2018-10-26  5:58 ` [PATCH v2 2/2] spi: uniphier: re-add addressing properties Keiji Hayashibara
2018-10-30 21:46   ` Rob Herring
2018-11-05 12:01   ` Applied "spi: uniphier: re-add addressing properties" to the spi tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).