LKML Archive on
help / color / mirror / Atom feed
* [PATCH -next] sgi-xp: drop pointless static qualifier in xpc_setup_msg_structures_uv
@ 2018-10-27  2:39 YueHaibing
  0 siblings, 0 replies; only message in thread
From: YueHaibing @ 2018-10-27  2:39 UTC (permalink / raw)
  To: Cliff Whickman, Robin Holt, Arnd Bergmann, Greg Kroah-Hartman
  Cc: YueHaibing, linux-kernel, kernel-janitors

There is no need to have the 'enum xp_retval ret' variable static since
new value always be assigned before use it.

Signed-off-by: YueHaibing <>
 drivers/misc/sgi-xp/xpc_uv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c
index 0441abe..0323bfe 100644
--- a/drivers/misc/sgi-xp/xpc_uv.c
+++ b/drivers/misc/sgi-xp/xpc_uv.c
@@ -1151,7 +1151,7 @@ struct uv_IO_APIC_route_entry {
 static enum xp_retval
 xpc_setup_msg_structures_uv(struct xpc_channel *ch)
-	static enum xp_retval ret;
+	enum xp_retval ret;
 	struct xpc_channel_uv *ch_uv = &ch->sn.uv;
 	DBUG_ON(ch->flags & XPC_C_SETUP);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-10-27  2:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-27  2:39 [PATCH -next] sgi-xp: drop pointless static qualifier in xpc_setup_msg_structures_uv YueHaibing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).