LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: geert+renesas@glider.be, laurent.pinchart@ideasonboard.com,
horms@verge.net.au
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
linus.walleij@linaro.org, linux-renesas-soc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] pinctrl: sh-pfc: r8a77965: Add VIN4 and VIN5
Date: Mon, 29 Oct 2018 19:13:42 +0100 [thread overview]
Message-ID: <1540836824-4636-1-git-send-email-jacopo+renesas@jmondi.org> (raw)
Hello,
this two patches add supports for VIN4 and VIN5 interfaces to R-Car M3-N.
On this SoC (and in the forthcoming support for E3 R8A77990) the VIN groups
could appear on different sets of pins, usually the 'a' and 'b' one.
With the existing VIN_DATA_PIN_GROUP macro we have to specify group names as:
VIN_DATA_PIN_GROUP(vin4_data_a, 8)
which results in the group being named as "vin4_data_a_8" which is
un-consistent with the canonical group names (eg. "vin4_data8_a").
This series adds a macro that allows to specify the group 'version' along with
the pin and mux numbers in patch [1/1]. I haven't been able to find a better
term than 'version' as 'group' was already taken. Suggestions welcome.
As I cannot test VIN4 nor VIN5 on Salvator-XS as the parallel pins are not
wired, I made sure the macro creates correct names and fields not only by
compile testing it, but with a small C program [1] that replicates the VIN data
layout defined in the PFC module and access fields (and has helped me testing
more easily the preprocessor stringification/concatenation process).
Final note: Simon, you took the E3 patches in your tree, and I expect them to
land on v4.20-rc1. They use the old macros, are follow up patches ok?)
Thanks
j
[1] https://paste.debian.net/1049603/
Jacopo Mondi (2):
pinctrl: sh-pfc: Introduce VIN_DATA_PIN_GROUP_VER
pinctrl: sh-pfc: r8a77965: Add VIN[4|5] groups/functions
drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 254 ++++++++++++++++++++++++++++++++++
drivers/pinctrl/sh-pfc/sh_pfc.h | 20 ++-
2 files changed, 269 insertions(+), 5 deletions(-)
--
2.7.4
next reply other threads:[~2018-10-29 18:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 18:13 Jacopo Mondi [this message]
2018-10-29 18:13 ` [PATCH 1/2] pinctrl: sh-pfc: Introduce VIN_DATA_PIN_GROUP_VER Jacopo Mondi
2018-10-30 3:46 ` Ulrich Hecht
2018-10-30 7:34 ` jacopo mondi
2018-10-29 18:13 ` [PATCH 2/2] pinctrl: sh-pfc: r8a77965: Add VIN[4|5] groups/functions Jacopo Mondi
2018-10-30 3:46 ` Ulrich Hecht
2018-11-05 17:19 ` [PATCH 0/2] pinctrl: sh-pfc: r8a77965: Add VIN4 and VIN5 Geert Uytterhoeven
2018-11-06 9:07 ` jacopo mondi
2018-11-06 9:24 ` Geert Uytterhoeven
2018-11-06 9:31 ` jacopo mondi
2018-11-07 8:39 ` Geert Uytterhoeven
2018-11-07 9:35 ` jacopo mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1540836824-4636-1-git-send-email-jacopo+renesas@jmondi.org \
--to=jacopo+renesas@jmondi.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--subject='Re: [PATCH 0/2] pinctrl: sh-pfc: r8a77965: Add VIN4 and VIN5' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).