LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Fenghua Yu <fenghua.yu@intel.com>
To: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>, "H Peter Anvin" <hpa@zytor.com>,
"Tony Luck" <tony.luck@intel.com>,
"Reinette Chatre" <reinette.chatre@intel.com>,
"Ravi V Shankar" <ravi.v.shankar@intel.com>,
"Xiaochen Shen" <xiaochen.shen@intel.com>,
"Arshiya Hayatkhan Pathan" <arshiya.hayatkhan.pathan@intel.com>,
"Sai Praneeth Prakhya" <sai.praneeth.prakhya@intel.com>,
"Babu Moger" <babu.moger@amd.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
Fenghua Yu <fenghua.yu@intel.com>
Subject: [PATCH v7 12/13] selftests/resctrl: Disable MBA and MBM tests for AMD
Date: Sat, 9 Feb 2019 18:50:41 -0800 [thread overview]
Message-ID: <1549767042-95827-13-git-send-email-fenghua.yu@intel.com> (raw)
In-Reply-To: <1549767042-95827-1-git-send-email-fenghua.yu@intel.com>
From: Babu Moger <babu.moger@amd.com>
For now, disable MBA and MBM tests for AMD. Deciding test pass/fail
is not clear right now. We can enable when we have some clarity.
Signed-off-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
tools/testing/selftests/resctrl/cat_test.c | 2 +-
tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
index 1a0f77e4f7bf..264bf2325f9e 100644
--- a/tools/testing/selftests/resctrl/cat_test.c
+++ b/tools/testing/selftests/resctrl/cat_test.c
@@ -69,7 +69,7 @@ static void show_cache_info(unsigned long sum_llc_perf_miss, int no_of_bits,
printf("Allocated cache lines: %lu \t", allocated_cache_lines);
printf("Percent diff=%d \t", abs((int)diff_percent));
- if (abs((int)diff_percent) > MAX_DIFF_PERCENT)
+ if (genuine_intel && (abs((int)diff_percent) > MAX_DIFF_PERCENT))
printf("Failed\n");
else
printf("Passed\n");
diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
index 1d9adcfbdb4c..620be40b8c01 100644
--- a/tools/testing/selftests/resctrl/resctrl_tests.c
+++ b/tools/testing/selftests/resctrl/resctrl_tests.c
@@ -197,7 +197,7 @@ int main(int argc, char **argv)
sprintf(bw_report, "reads");
sprintf(bm_type, "fill_buf");
- if (mbm_test) {
+ if (genuine_intel && mbm_test) {
printf("\nMBM BW Change Starting..\n");
if (!has_ben)
sprintf(benchmark_cmd[5], "%s", "mbm");
@@ -207,7 +207,7 @@ int main(int argc, char **argv)
mbm_test_cleanup();
}
- if (mba_test) {
+ if (genuine_intel && mba_test) {
printf("\nMBA Schemata Change Starting..\n");
if (!has_ben)
sprintf(benchmark_cmd[5], "%s", "mba");
--
2.7.4
next prev parent reply other threads:[~2019-02-10 2:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 2:50 [PATCH v7 00/13] selftests/resctrl: Add resctrl selftest Fenghua Yu
2019-02-10 2:50 ` [PATCH v7 01/13] selftests/resctrl: Add README for resctrl tests Fenghua Yu
2019-02-10 2:50 ` [PATCH v7 02/13] selftests/resctrl: Add basic resctrl file system operations and data Fenghua Yu
2019-05-10 17:36 ` Andre Przywara
2019-05-10 19:00 ` Yu, Fenghua
2019-05-10 17:41 ` Borislav Petkov
2019-05-10 19:01 ` Yu, Fenghua
2019-02-10 2:50 ` [PATCH v7 03/13] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system Fenghua Yu
2019-02-10 2:50 ` [PATCH v7 04/13] selftests/resctrl: Add callback to start a benchmark Fenghua Yu
2019-05-10 17:37 ` Andre Przywara
2019-02-10 2:50 ` [PATCH v7 05/13] selftests/resctrl: Add built in benchmark Fenghua Yu
2019-05-10 17:37 ` Andre Przywara
2019-02-10 2:50 ` [PATCH v7 06/13] selftests/resctrl: Add MBM test Fenghua Yu
2019-05-10 17:37 ` Andre Przywara
2019-02-10 2:50 ` [PATCH v7 07/13] selftests/resctrl: Add MBA test Fenghua Yu
2019-05-10 17:37 ` Andre Przywara
2019-02-10 2:50 ` [PATCH v7 08/13] selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest Fenghua Yu
2019-05-10 17:38 ` Andre Przywara
2019-02-10 2:50 ` [PATCH v7 09/13] selftests/resctrl: Add Cache Allocation Technology (CAT) selftest Fenghua Yu
2019-05-10 17:38 ` Andre Przywara
2019-02-10 2:50 ` [PATCH v7 10/13] selftests/resctrl: Add vendor detection mechanism Fenghua Yu
2019-05-10 17:39 ` Andre Przywara
2019-05-10 17:40 ` Andre Przywara
2019-05-14 17:20 ` James Morse
2019-05-14 19:40 ` André Przywara
2019-05-15 9:08 ` James Morse
2019-02-10 2:50 ` [PATCH v7 11/13] selftests/resctrl: Use cache index3 id for AMD schemata masks Fenghua Yu
2019-02-10 2:50 ` Fenghua Yu [this message]
2019-05-10 17:40 ` [PATCH v7 12/13] selftests/resctrl: Disable MBA and MBM tests for AMD Andre Przywara
2019-05-10 19:29 ` Yu, Fenghua
2019-05-14 17:17 ` Moger, Babu
2019-02-10 2:50 ` [PATCH v7 13/13] selftests/resctrl: Add the test in MAINTAINERS Fenghua Yu
2019-02-14 14:56 ` [PATCH v7 00/13] selftests/resctrl: Add resctrl selftest Fenghua Yu
2019-03-06 20:55 ` Moger, Babu
2019-02-27 18:07 ` Moger, Babu
2019-05-10 17:35 ` Andre Przywara
2019-05-10 19:20 ` Yu, Fenghua
2019-05-14 17:20 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549767042-95827-13-git-send-email-fenghua.yu@intel.com \
--to=fenghua.yu@intel.com \
--cc=arshiya.hayatkhan.pathan@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=reinette.chatre@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=xiaochen.shen@intel.com \
--subject='Re: [PATCH v7 12/13] selftests/resctrl: Disable MBA and MBM tests for AMD' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).