From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2B7C072B5 for ; Fri, 24 May 2019 09:26:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EDDD217F9 for ; Fri, 24 May 2019 09:26:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390120AbfEXJ0O (ORCPT ); Fri, 24 May 2019 05:26:14 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:23165 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2389758AbfEXJ0O (ORCPT ); Fri, 24 May 2019 05:26:14 -0400 X-UUID: 6380ca07a1a848caadf8a110be0a92e8-20190524 X-UUID: 6380ca07a1a848caadf8a110be0a92e8-20190524 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1520838834; Fri, 24 May 2019 17:25:54 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 24 May 2019 17:25:52 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 24 May 2019 17:25:51 +0800 Message-ID: <1558689951.10179.422.camel@mhfsdcap03> Subject: Re: [RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root From: Chunfeng Yun To: Greg Kroah-Hartman CC: Matthias Brugger , Randy Dunlap , , , , Date: Fri, 24 May 2019 17:25:51 +0800 In-Reply-To: <20190524074552.GA1080@kroah.com> References: <20190524074552.GA1080@kroah.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-05-24 at 09:45 +0200, Greg Kroah-Hartman wrote: > On Fri, May 24, 2019 at 02:11:33PM +0800, Chunfeng Yun wrote: > > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set, > > there is an issue: > > > > ld: > > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root': > > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root' > > > > usb_debug_root is only built when CONFIG_USB is enabled, so here drop it > > and use NULL instead. > > > > Reported-by: Randy Dunlap > > Signed-off-by: Chunfeng Yun > > Acked-by: Randy Dunlap > > --- > > drivers/usb/mtu3/mtu3_debugfs.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Why resend? Sorry, I should send it out as v2 due to acked-by is added. > > > diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c > > index 62c57ddc554e..b7c86ccd50b4 100644 > > --- a/drivers/usb/mtu3/mtu3_debugfs.c > > +++ b/drivers/usb/mtu3/mtu3_debugfs.c > > @@ -528,8 +528,7 @@ void ssusb_dr_debugfs_init(struct ssusb_mtk *ssusb) > > > > void ssusb_debugfs_create_root(struct ssusb_mtk *ssusb) > > { > > - ssusb->dbgfs_root = > > - debugfs_create_dir(dev_name(ssusb->dev), usb_debug_root); > > + ssusb->dbgfs_root = debugfs_create_dir(dev_name(ssusb->dev), NULL); > > This moves the directory to a new location no matter what the > configuration is. What's wrong with where it is today? it seems usb_debug_root is only for host, but not for gadget only, it's defined and created in usb/core/usb.c > And shoudn't we > create the usb root directory if only gadget is enabled? Yes, need modify udc/core.c, it's better if support it, do you want me to send a patch for it? Thanks > > thanks, > > greg k-h