LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Randy Dunlap <rdunlap@infradead.org>, <linux-usb@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root
Date: Mon, 27 May 2019 10:56:22 +0800	[thread overview]
Message-ID: <1558925782.10179.429.camel@mhfsdcap03> (raw)
In-Reply-To: <20190524113322.GA32094@kroah.com>

On Fri, 2019-05-24 at 13:33 +0200, Greg Kroah-Hartman wrote:
> On Fri, May 24, 2019 at 05:25:51PM +0800, Chunfeng Yun wrote:
> > On Fri, 2019-05-24 at 09:45 +0200, Greg Kroah-Hartman wrote:
> > > On Fri, May 24, 2019 at 02:11:33PM +0800, Chunfeng Yun wrote:
> > > > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set,
> > > > there is an issue:
> > > > 
> > > > ld:
> > > > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root':
> > > > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root'
> > > > 
> > > > usb_debug_root is only built when CONFIG_USB is enabled, so here drop it
> > > > and use NULL instead.
> > > > 
> > > > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > > > ---
> > > >  drivers/usb/mtu3/mtu3_debugfs.c | 3 +--
> > > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > Why resend?
> > Sorry, I should send it out as v2 due to acked-by is added.
> 
> Then please document that below the --- line, otherwise I have no idea :(
Ok
> 
> > > > diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c
> > > > index 62c57ddc554e..b7c86ccd50b4 100644
> > > > --- a/drivers/usb/mtu3/mtu3_debugfs.c
> > > > +++ b/drivers/usb/mtu3/mtu3_debugfs.c
> > > > @@ -528,8 +528,7 @@ void ssusb_dr_debugfs_init(struct ssusb_mtk *ssusb)
> > > >  
> > > >  void ssusb_debugfs_create_root(struct ssusb_mtk *ssusb)
> > > >  {
> > > > -	ssusb->dbgfs_root =
> > > > -		debugfs_create_dir(dev_name(ssusb->dev), usb_debug_root);
> > > > +	ssusb->dbgfs_root = debugfs_create_dir(dev_name(ssusb->dev), NULL);
> > > 
> > > This moves the directory to a new location no matter what the
> > > configuration is. What's wrong with where it is today?  
> > it seems usb_debug_root is only for host, but not for gadget only, it's
> > defined and created in usb/core/usb.c
> 
> True, but you just moved the root if usb core is present too.
It's an easy way, and other dual-role driver also uses NULL

> 
> > > And shoudn't we
> > > create the usb root directory if only gadget is enabled?
> > Yes, need modify udc/core.c, it's better if support it, do you want me
> > to send a patch for it?
> 
> Yes please, let's see what that looks like.
I'll do it.

Thanks
> 
> thanks,
> 
> greg k-h



      reply	other threads:[~2019-05-27  2:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24  6:11 Chunfeng Yun
2019-05-24  7:45 ` Greg Kroah-Hartman
2019-05-24  9:25   ` Chunfeng Yun
2019-05-24 11:33     ` Greg Kroah-Hartman
2019-05-27  2:56       ` Chunfeng Yun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1558925782.10179.429.camel@mhfsdcap03 \
    --to=chunfeng.yun@mediatek.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=rdunlap@infradead.org \
    --subject='Re: [RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).