LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Martin J. Bligh" <Martin.Bligh@us.ibm.com>
To: Andreas Dilger <adilger@turbolabs.com>,
	Alessandro Suardi <alessandro.suardi@oracle.com>
Cc: Dan Merillat <harik@chaos.ao.net>, linux-kernel@vger.kernel.org
Subject: Re: Wierd /proc/cpuinfo with 2.4.11-pre4
Date: Fri, 05 Oct 2001 16:20:56 -0700	[thread overview]
Message-ID: <1571476398.1002298856@mbligh.des.sequent.com> (raw)
In-Reply-To: <20011005171815.O315@turbolinux.com>

> This will also fail if, for some reason "clustered_apic_mode" is set and
> you have less than 8 CPUs.  What you really want is to have "max(8:NR_CPUS)"
> in the loop (or make the loop actually work with > 8 CPUs, which is probably
> the correct solution in the long run).

Nope, the cpu_online map should catch this. NR_CPUS is always 32
in SMP mode.

in get_cpuinfo ....

                if (!(cpu_online_map & (1<<n)))
                        continue;

I didn't notice that this would only work in SMP mode. 

It's a horrible hack, but it's less horrible than corrupting memory randomly ;-)

M.


  reply	other threads:[~2001-10-05 23:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-05 18:16 Dan Merillat
2001-10-05 21:45 ` Alessandro Suardi
2001-10-05 21:58   ` Martin J. Bligh
2001-10-05 23:10     ` Alessandro Suardi
2001-10-05 23:07       ` Martin J. Bligh
2001-10-06  0:37         ` Alessandro Suardi
2001-10-05 23:18       ` Andreas Dilger
2001-10-05 23:20         ` Martin J. Bligh [this message]
2001-10-05 23:17     ` Brian Gerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1571476398.1002298856@mbligh.des.sequent.com \
    --to=martin.bligh@us.ibm.com \
    --cc=adilger@turbolabs.com \
    --cc=alessandro.suardi@oracle.com \
    --cc=harik@chaos.ao.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: Wierd /proc/cpuinfo with 2.4.11-pre4' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).