LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Jiashuo Liang <liangjs@pku.edu.cn>
Cc: bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
	linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com,
	peterz@infradead.org, tglx@linutronix.de, x86@kernel.org
Subject: Re: [PATCH] x86/fault: Fix wrong signal when vsyscall fails with pkey
Date: Thu, 29 Jul 2021 07:02:44 -0700	[thread overview]
Message-ID: <15721c9c-3030-2e4e-8e34-9f18afe8d171@intel.com> (raw)
In-Reply-To: <600fdad9d3955671b1a5af12d40a4e409bc7ba5f.camel@pku.edu.cn>

On 7/28/21 11:24 PM, Jiashuo Liang wrote:
> I agree that using ARCH_DEFAULT_PKEY is better. I think I am supposed to
> send a patch v2 for the update?

Yes, please.

> By the way, the magic pkey number 0 also appears when bad_area_nosemaphore
> calls __bad_area_nosemaphore and bad_area calls __bad_area. Do they need to
> be changed to ARCH_DEFAULT_PKEY as well?

Yes, it would be best to change those as well.  Ideally in a separate patch.

  reply	other threads:[~2021-07-29 14:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 11:44 Jiashuo Liang
2021-07-28 17:57 ` Dave Hansen
2021-07-29  6:24   ` Jiashuo Liang
2021-07-29 14:02     ` Dave Hansen [this message]
2021-08-11  0:58       ` Jiashuo Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15721c9c-3030-2e4e-8e34-9f18afe8d171@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=liangjs@pku.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH] x86/fault: Fix wrong signal when vsyscall fails with pkey' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).