LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Taniya Das <tdas@codeaurora.org>
Cc: David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Gross <agross@kernel.org>,
	devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org,
	Taniya Das <tdas@codeaurora.org>
Subject: Re: [PATCH v5 5/5] clk: qcom: Add modem clock controller driver for SC7180
Date: Tue, 25 Feb 2020 16:20:33 -0800	[thread overview]
Message-ID: <158267643373.177367.14343331439641557635@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1582540703-6328-6-git-send-email-tdas@codeaurora.org>

Quoting Taniya Das (2020-02-24 02:38:23)
> diff --git a/drivers/clk/qcom/mss-sc7180.c b/drivers/clk/qcom/mss-sc7180.c
> new file mode 100644
> index 0000000..993749e
> --- /dev/null
> +++ b/drivers/clk/qcom/mss-sc7180.c
> @@ -0,0 +1,143 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2019, The Linux Foundation. All rights reserved.
> + */
> +
> +#include <linux/clk-provider.h>
> +#include <linux/platform_device.h>
> +#include <linux/module.h>
> +#include <linux/of_address.h>

Is this used?

> +#include <linux/pm_clock.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/regmap.h>
> +
> +#include <dt-bindings/clock/qcom,mss-sc7180.h>
> +
> +#include "clk-regmap.h"
> +#include "clk-branch.h"
> +#include "common.h"
> +
> +static struct clk_branch mss_axi_nav_clk = {
> +       .halt_reg = 0x20bc,
> +       .halt_check = BRANCH_HALT,
> +       .clkr = {
> +               .enable_reg = 0x20bc,
> +               .enable_mask = BIT(0),
> +               .hw.init = &(struct clk_init_data){
> +                       .name = "mss_axi_nav_clk",
> +                       .parent_data = &(const struct clk_parent_data){
> +                               .fw_name = "gcc_mss_nav_axi_clk",
> +                       },
> +                       .num_parents = 1,
> +                       .ops = &clk_branch2_ops,
> +               },
> +       },
> +};
> +
> +static struct clk_branch mss_axi_crypto_clk = {
> +       .halt_reg = 0x20cc,
> +       .halt_check = BRANCH_HALT,
> +       .clkr = {
> +               .enable_reg = 0x20cc,
> +               .enable_mask = BIT(0),
> +               .hw.init = &(struct clk_init_data){
> +                       .name = "mss_axi_crypto_clk",
> +                       .parent_data = &(const struct clk_parent_data){
> +                               .fw_name = "gcc_mss_mfab_axis_clk",
> +                       },
> +                       .num_parents = 1,
> +                       .ops = &clk_branch2_ops,
> +               },
> +       },
> +};
> +
> +static const struct regmap_config mss_regmap_config = {
> +       .reg_bits       = 32,
> +       .reg_stride     = 4,
> +       .val_bits       = 32,
> +       .fast_io        = true,

What is the max register?

> +};
> +
> +static struct clk_regmap *mss_sc7180_clocks[] = {
> +       [MSS_AXI_CRYPTO_CLK] = &mss_axi_crypto_clk.clkr,
> +       [MSS_AXI_NAV_CLK] = &mss_axi_nav_clk.clkr,
> +};

  reply	other threads:[~2020-02-26  0:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 10:38 [PATCH v5 0/5] Add modem Clock controller (MSS CC) " Taniya Das
2020-02-24 10:38 ` [PATCH v5 1/5] dt-bindings: clock: Add support for Modem clocks in GCC Taniya Das
2020-02-24 10:38 ` [PATCH v5 2/5] clk: qcom: gcc: Add support for modem " Taniya Das
2020-02-24 10:38 ` [PATCH v5 3/5] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings Taniya Das
2020-02-24 18:42   ` Rob Herring
2020-02-25  5:49     ` Taniya Das
2020-02-25 13:58       ` Rob Herring
     [not found]         ` <158267707817.177367.4165827948994155128@swboyd.mtv.corp.google.com>
     [not found]           ` <CAL_JsqJiB08vtDKP18Xzdzan-2TFVxJJ-rFgvXsqVHKB5-L18g@mail.gmail.com>
2020-03-14 18:46             ` Taniya Das
2020-02-24 10:38 ` [PATCH v5 4/5] dt-bindings: clock: Introduce QCOM Modem " Taniya Das
2020-02-26  0:32   ` Stephen Boyd
2020-02-24 10:38 ` [PATCH v5 5/5] clk: qcom: Add modem clock controller driver for SC7180 Taniya Das
2020-02-26  0:20   ` Stephen Boyd [this message]
2020-02-26  0:28   ` Stephen Boyd
2020-03-09 20:06 ` [PATCH v5 0/5] Add modem Clock controller (MSS CC) " Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158267643373.177367.14343331439641557635@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=agross@kernel.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=tdas@codeaurora.org \
    --subject='Re: [PATCH v5 5/5] clk: qcom: Add modem clock controller driver for SC7180' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).