LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>, Taniya Das <tdas@codeaurora.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
	robh@kernel.org, David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Gross <agross@kernel.org>,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH v1 2/2] clk: qcom: dispcc: Remove support of disp_cc_mdss_rscc_ahb_clk
Date: Mon, 16 Mar 2020 11:33:17 -0700	[thread overview]
Message-ID: <158438359728.88485.9249991203602274851@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <c6b19bac-b018-28a0-421f-f40f85245bee@codeaurora.org>

Quoting Taniya Das (2020-03-14 04:08:47)
> I would require you suggestion on the below.
> 
> On 3/13/2020 11:31 PM, Stephen Boyd wrote:
> > Quoting Matthias Kaehlcke (2020-03-04 09:09:39)
> >> Hi Taniya,
> >>
> >> On Wed, Mar 04, 2020 at 09:05:20AM +0530, Taniya Das wrote:
> >>>
> >>> Hi Matthias,
> >>>
> >>> The display device node is not present and we encounter this crash, would it
> >>> be possible to add ALWAYS_ON for the MDSS GDSC and give it a try.
> >>
> >> It still crashes when ALWAYS_ON is set for the MDSS GDSC.
> > 
> > Any updates here? I'm about to send this patch off to Linus and I'm
> > wondering if there will be a resolution besides reverting it.
> > 
> 
> Looks like the AHB clock needs to be left enabled till the last clocks 
> get disabled. I need to add a new dependency o n this clock.
> 
> Hi Stephen,
> 
> 
> Any way to keep this dependency using the framework  or I need to split 
> the probes to register them independently?
> 

Sorry, I don't understand the problem fully. This AHB clk is left on in
the bootloader? Why do we need to touch it if it's always left enabled?
Is it actually the case that the bootloader hasn't turned this clk on
and we're getting lucky having it marked here as CLK_IS_CRITICAL? Can we
force it on in driver probe and then ignore it after that?

  parent reply	other threads:[~2020-03-16 18:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 12:13 [PATCH v1 1/2] clk: qcom: videocc: Update the clock flag for video_cc_vcodec0_core_clk Taniya Das
2020-02-11 12:13 ` [PATCH v1 2/2] clk: qcom: dispcc: Remove support of disp_cc_mdss_rscc_ahb_clk Taniya Das
2020-02-12 23:03   ` Stephen Boyd
2020-03-03 20:16   ` Matthias Kaehlcke
2020-03-04  3:35     ` Taniya Das
2020-03-04 17:09       ` Matthias Kaehlcke
2020-03-13 18:01         ` Stephen Boyd
     [not found]           ` <c6b19bac-b018-28a0-421f-f40f85245bee@codeaurora.org>
2020-03-16 18:33             ` Stephen Boyd [this message]
2020-02-12  0:33 ` [PATCH v1 1/2] clk: qcom: videocc: Update the clock flag for video_cc_vcodec0_core_clk Stephen Boyd
2020-02-12 23:03 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158438359728.88485.9249991203602274851@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=agross@kernel.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=mturquette@baylibre.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=tdas@codeaurora.org \
    --subject='Re: [PATCH v1 2/2] clk: qcom: dispcc: Remove support of disp_cc_mdss_rscc_ahb_clk' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).