LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drivers/net: move the nvidia forcedeth driver from 100M group to 1000M group
@ 2007-04-25  5:30 Peer Chen
  2007-04-25  6:22 ` H. Peter Anvin
  2007-04-25 14:06 ` Lennart Sorensen
  0 siblings, 2 replies; 4+ messages in thread
From: Peer Chen @ 2007-04-25  5:30 UTC (permalink / raw)
  To: linux-kernel; +Cc: akpm, torvalds

nForce ehternet is a Gigabit NIC not 100M, move it to 1000M group to
avoid the confusion.

Signed-off-by: Peer Chen <pchen@nvidia.com>

====================

--- linux-2.6.21-rc7/drivers/net/Kconfig.orig
+++ linux-2.6.21-rc7/drivers/net/Kconfig
@@ -1399,35 +1399,6 @@ config B44
 	  <file:Documentation/networking/net-modules.txt>.  The module
will be
 	  called b44.
 
-config FORCEDETH
-	tristate "nForce Ethernet support"
-	depends on NET_PCI && PCI
-	help
-	  If you have a network (Ethernet) controller of this type, say
Y and
-	  read the Ethernet-HOWTO, available from
-	  <http://www.tldp.org/docs.html#howto>.
-
-	  To compile this driver as a module, choose M here and read
-	  <file:Documentation/networking/net-modules.txt>.  The module
will be
-	  called forcedeth.
-
-config FORCEDETH_NAPI
-	bool "Use Rx and Tx Polling (NAPI) (EXPERIMENTAL)"
-	depends on FORCEDETH && EXPERIMENTAL
-	help
-	  NAPI is a new driver API designed to reduce CPU and interrupt
load
-	  when the driver is receiving lots of packets from the card. It
is
-	  still somewhat experimental and thus not yet enabled by
default.
-
-	  If your estimated Rx load is 10kpps or more, or if the card
will be
-	  deployed on potentially unfriendly networks (e.g. in a
firewall),
-	  then say Y here.
-
-	  See <file:Documentation/networking/NAPI_HOWTO.txt> for more
-	  information.
-
-	  If in doubt, say N.
-
 config CS89x0
 	tristate "CS89x0 support"
 	depends on NET_PCI && (ISA || MACH_IXDP2351 || ARCH_IXDP2X01 ||
ARCH_PNX010X)
@@ -1999,6 +1970,35 @@ config MYRI_SBUS
 	  To compile this driver as a module, choose M here: the module
 	  will be called myri_sbus.  This is recommended.
 
+config FORCEDETH
+	tristate "nForce Ethernet support"
+	depends on NET_PCI && PCI
+	help
+	  If you have a network (Ethernet) controller of this type, say
Y and
+	  read the Ethernet-HOWTO, available from
+	  <http://www.tldp.org/docs.html#howto>.
+
+	  To compile this driver as a module, choose M here and read
+	  <file:Documentation/networking/net-modules.txt>.  The module
will be
+	  called forcedeth.
+
+config FORCEDETH_NAPI
+	bool "Use Rx and Tx Polling (NAPI) (EXPERIMENTAL)"
+	depends on FORCEDETH && EXPERIMENTAL
+	help
+	  NAPI is a new driver API designed to reduce CPU and interrupt
load
+	  when the driver is receiving lots of packets from the card. It
is
+	  still somewhat experimental and thus not yet enabled by
default.
+
+	  If your estimated Rx load is 10kpps or more, or if the card
will be
+	  deployed on potentially unfriendly networks (e.g. in a
firewall),
+	  then say Y here.
+
+	  See <file:Documentation/networking/NAPI_HOWTO.txt> for more
+	  information.
+
+	  If in doubt, say N.
+
 config NS83820
 	tristate "National Semiconductor DP83820 support"
 	depends on PCI
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drivers/net: move the nvidia forcedeth driver from 100M group to 1000M group
  2007-04-25  5:30 [PATCH] drivers/net: move the nvidia forcedeth driver from 100M group to 1000M group Peer Chen
@ 2007-04-25  6:22 ` H. Peter Anvin
  2007-04-25 14:06 ` Lennart Sorensen
  1 sibling, 0 replies; 4+ messages in thread
From: H. Peter Anvin @ 2007-04-25  6:22 UTC (permalink / raw)
  To: Peer Chen; +Cc: linux-kernel, akpm, torvalds

Peer Chen wrote:
> nForce ehternet is a Gigabit NIC not 100M, move it to 1000M group to
> avoid the confusion.

Overall, maybe the 100 Mbps vs 1000 Mbps distinction is getting less
useful and it would be better to have a single list.  There are a *lot*
of chipsets on the market now which have the same core and the only
difference is that one has a 100M PHY and the other has a 1000M PHY.
For example, there are 100M versions of sky2 and r8169.

	-hpa

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drivers/net: move the nvidia forcedeth driver from 100M group to 1000M group
  2007-04-25  5:30 [PATCH] drivers/net: move the nvidia forcedeth driver from 100M group to 1000M group Peer Chen
  2007-04-25  6:22 ` H. Peter Anvin
@ 2007-04-25 14:06 ` Lennart Sorensen
  2007-04-27  1:27   ` Peer Chen
  1 sibling, 1 reply; 4+ messages in thread
From: Lennart Sorensen @ 2007-04-25 14:06 UTC (permalink / raw)
  To: Peer Chen; +Cc: linux-kernel, akpm, torvalds

On Wed, Apr 25, 2007 at 01:30:04PM +0800, Peer Chen wrote:
> nForce ehternet is a Gigabit NIC not 100M, move it to 1000M group to
> avoid the confusion.

The forcedeth on my nforce2 board is 100Mbit.  I think the driver
handles both 100Mbit and GBit type devices.  Makes for an interesting
categorization problem.  Moving it would cause confusion.  Leaving it
where it is could cause confusion.  Moving it may confuse existing users
more though so I would recommend leaving it alone unless you can somehow
make it appear in both.

--
Len Sorensen

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] drivers/net: move the nvidia forcedeth driver from 100M group to 1000M group
  2007-04-25 14:06 ` Lennart Sorensen
@ 2007-04-27  1:27   ` Peer Chen
  0 siblings, 0 replies; 4+ messages in thread
From: Peer Chen @ 2007-04-27  1:27 UTC (permalink / raw)
  To: Lennart Sorensen; +Cc: linux-kernel, akpm, torvalds

You are right,both ways would cause confusion,but sooner or later we need to move it because our NICs onward are all Gigabit and 100M NICs will disappear gradually in the future. Probably H.Peter's suggestion that have a single list for 100M and 1000M is a better choice.

-----Original Message-----
From: Lennart Sorensen [mailto:lsorense@csclub.uwaterloo.ca] 
Sent: Wednesday, April 25, 2007 10:06 PM
To: Peer Chen
Cc: linux-kernel@vger.kernel.org; akpm@osdl.org; torvalds@osdl.org
Subject: Re: [PATCH] drivers/net: move the nvidia forcedeth driver from 100M group to 1000M group

On Wed, Apr 25, 2007 at 01:30:04PM +0800, Peer Chen wrote:
> nForce ehternet is a Gigabit NIC not 100M, move it to 1000M group to 
> avoid the confusion.

The forcedeth on my nforce2 board is 100Mbit.  I think the driver handles both 100Mbit and GBit type devices.  Makes for an interesting categorization problem.  Moving it would cause confusion.  Leaving it where it is could cause confusion.  Moving it may confuse existing users more though so I would recommend leaving it alone unless you can somehow make it appear in both.

--
Len Sorensen
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-04-27  1:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-25  5:30 [PATCH] drivers/net: move the nvidia forcedeth driver from 100M group to 1000M group Peer Chen
2007-04-25  6:22 ` H. Peter Anvin
2007-04-25 14:06 ` Lennart Sorensen
2007-04-27  1:27   ` Peer Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).