LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Williams, Dan J" <dan.j.williams@intel.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"david@redhat.com" <david@redhat.com>
Subject: Re: [PATCH v3 1/3] kernel/resource: clean up and optimize iomem_is_exclusive()
Date: Wed, 1 Sep 2021 19:43:18 +0000	[thread overview]
Message-ID: <16141669368a89f8304b1777094e982942d51bba.camel@intel.com> (raw)
In-Reply-To: <20210831202141.13846-2-david@redhat.com>

On Tue, 2021-08-31 at 22:21 +0200, David Hildenbrand wrote:
> We end up traversing subtrees of ranges we are not interested in; let's
> optimize this case, skipping such subtrees, cleaning up the function a bit.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  kernel/resource.c | 25 ++++++++++++++++++++-----
>  1 file changed, 20 insertions(+), 5 deletions(-)

That diffstat does not come across as "cleanup", and the skip_children
flag changing values mid-iteration feels tricky. Is there a win here,
the same number of entries still need to be accessed, right?

BTW, I had to pull this from lore to reply to it, looks like the
intended Cc's were missing?

  reply	other threads:[~2021-09-01 19:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 20:21 [PATCH v3 0/3] virtio-mem: disallow mapping virtio-mem memory via /dev/mem David Hildenbrand
2021-08-31 20:21 ` [PATCH v3 1/3] kernel/resource: clean up and optimize iomem_is_exclusive() David Hildenbrand
2021-09-01 19:43   ` Williams, Dan J [this message]
2021-09-02  7:52     ` David Hildenbrand
2021-09-02 15:54       ` Dan Williams
2021-08-31 20:21 ` [PATCH v3 2/3] kernel/resource: disallow access to exclusive system RAM regions David Hildenbrand
2021-09-01 19:37   ` Williams, Dan J
2021-08-31 20:21 ` [PATCH v3 3/3] virtio-mem: disallow mapping virtio-mem memory via /dev/mem David Hildenbrand
2021-09-01 19:39   ` Williams, Dan J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16141669368a89f8304b1777094e982942d51bba.camel@intel.com \
    --to=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v3 1/3] kernel/resource: clean up and optimize iomem_is_exclusive()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).