LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vineet Gupta <vgupta@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: kernel test robot <lkp@intel.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Vineet Gupta <vgupta@kernel.org>,
	linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH] ARC: export clear_user_page() for modules
Date: Mon, 16 Aug 2021 15:00:42 -0700	[thread overview]
Message-ID: <16255d77-e9a5-4bac-6c6e-596af6f5b0c1@kernel.org> (raw)
In-Reply-To: <20210816210533.16929-1-rdunlap@infradead.org>

On 8/16/21 2:05 PM, Randy Dunlap wrote:
> 0day bot reports a build error:
>    ERROR: modpost: "clear_user_page" [drivers/media/v4l2-core/videobuf-dma-sg.ko] undefined!
> so export it in arch/arc/ to fix the build error.
>
> In most ARCHes, clear_user_page() is a macro. OTOH, in a few
> ARCHes it is a function and needs to be exported.
> PowerPC exported it in 2004. It looks like nds32 and nios2
> still need to have it exported.
>
> Fixes: 4102b53392d63 ("ARC: [mm] Aliasing VIPT dcache support 2/4")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Vineet Gupta <vgupta@kernel.org>
> Cc: linux-snps-arc@lists.infradead.org

Thx for the fix. Added for 5.16 !

-Vineet

> ---
>   arch/arc/mm/cache.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210816.orig/arch/arc/mm/cache.c
> +++ linux-next-20210816/arch/arc/mm/cache.c
> @@ -1041,7 +1041,7 @@ void clear_user_page(void *to, unsigned
>   	clear_page(to);
>   	clear_bit(PG_dc_clean, &page->flags);
>   }
> -
> +EXPORT_SYMBOL(clear_user_page);
>   
>   /**********************************************************************
>    * Explicit Cache flush request from user space via syscall
>
> _______________________________________________
> linux-snps-arc mailing list
> linux-snps-arc@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-snps-arc


      reply	other threads:[~2021-08-16 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 21:05 Randy Dunlap
2021-08-16 22:00 ` Vineet Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16255d77-e9a5-4bac-6c6e-596af6f5b0c1@kernel.org \
    --to=vgupta@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=lkp@intel.com \
    --cc=rdunlap@infradead.org \
    --subject='Re: [PATCH] ARC: export clear_user_page() for modules' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).