LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1
@ 2021-07-19 18:23 ericwouds
  2021-07-19 19:08 ` Florian Fainelli
  2021-07-20 14:10 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: ericwouds @ 2021-07-19 18:23 UTC (permalink / raw)
  To: Sean Wang, Landen Chao, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, Vladimir Oltean, David S. Miller,
	Jakub Kicinski, Matthias Brugger
  Cc: Eric Woudstra, netdev, linux-arm-kernel, linux-mediatek, linux-kernel

From: Eric Woudstra <ericwouds@gmail.com>

Fixes my earlier patch which broke vlan unaware bridges.

The IVL bit now only gets set for vid's larger than 1.

Fixes: 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit")
Signed-off-by: Eric Woudstra <ericwouds@gmail.com>
---
 drivers/net/dsa/mt7530.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index 9e4df35f9..69f21b716 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -366,7 +366,8 @@ mt7530_fdb_write(struct mt7530_priv *priv, u16 vid,
 	int i;
 
 	reg[1] |= vid & CVID_MASK;
-	reg[1] |= ATA2_IVL;
+	if (vid > 1)
+		reg[1] |= ATA2_IVL;
 	reg[2] |= (aging & AGE_TIMER_MASK) << AGE_TIMER;
 	reg[2] |= (port_mask & PORT_MAP_MASK) << PORT_MAP;
 	/* STATIC_ENT indicate that entry is static wouldn't
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1
  2021-07-19 18:23 [PATCH net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1 ericwouds
@ 2021-07-19 19:08 ` Florian Fainelli
  2021-07-20 14:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2021-07-19 19:08 UTC (permalink / raw)
  To: ericwouds, Sean Wang, Landen Chao, Andrew Lunn, Vivien Didelot,
	Vladimir Oltean, David S. Miller, Jakub Kicinski,
	Matthias Brugger
  Cc: netdev, linux-arm-kernel, linux-mediatek, linux-kernel

On 7/19/21 11:23 AM, ericwouds@gmail.com wrote:
> From: Eric Woudstra <ericwouds@gmail.com>
> 
> Fixes my earlier patch which broke vlan unaware bridges.
> 
> The IVL bit now only gets set for vid's larger than 1.
> 
> Fixes: 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit")
> Signed-off-by: Eric Woudstra <ericwouds@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1
  2021-07-19 18:23 [PATCH net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1 ericwouds
  2021-07-19 19:08 ` Florian Fainelli
@ 2021-07-20 14:10 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-20 14:10 UTC (permalink / raw)
  To: Eric Woudstra
  Cc: sean.wang, Landen.Chao, andrew, vivien.didelot, f.fainelli,
	olteanv, davem, kuba, matthias.bgg, netdev, linux-arm-kernel,
	linux-mediatek, linux-kernel

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 19 Jul 2021 20:23:57 +0200 you wrote:
> From: Eric Woudstra <ericwouds@gmail.com>
> 
> Fixes my earlier patch which broke vlan unaware bridges.
> 
> The IVL bit now only gets set for vid's larger than 1.
> 
> Fixes: 11d8d98cbeef ("mt7530 fix mt7530_fdb_write vid missing ivl bit")
> Signed-off-by: Eric Woudstra <ericwouds@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1
    https://git.kernel.org/netdev/net/c/7e777021780e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-20 14:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 18:23 [PATCH net] mt7530 mt7530_fdb_write only set ivl bit vid larger than 1 ericwouds
2021-07-19 19:08 ` Florian Fainelli
2021-07-20 14:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).