LKML Archive on
help / color / mirror / Atom feed
	Dillon Min <>
Subject: [PATCH v4 0/3] Add ilitek ili9341 panel driver
Date: Sat, 24 Jul 2021 11:44:00 +0800	[thread overview]
Message-ID: <> (raw)

From: Dillon Min <>

Since the st,sf-tc240t-9370-t dts binding already exist in stm32f429-disco.dts
but, the panel driver didn't get accepted from mainline. it's time to submit
patch fot it.

This driver can support two different interface by different dts bindings:
- spi+dpi, use spi to configure register, dpi for graphic data.
- only spi, just like tiny/ili9341.c (actually, this part is copy from tiny)

I was submited the first patch last year, you can find it at [1].
this patch has one major difference from that one, which is replace the low
level communication way, from spi_sync() to mipi_dbi_{command,
command_stackbuf}() interface, referred from Linus's patch [2].

both the two dpi/dbi interface was tested on stm32f429-disco board, if anyone
want to verify this patch, you need apply the clk patch for this board first,
you can get it from [3].

[1] "drm/panel: Add ilitek ili9341 panel driver"

[2] "drm/panel: s6e63m0: Switch to DBI abstraction for SPI"


- fix m68k-allmodconfig build error which reported by lkp, thanks.
- add Copyright 2018 David Lechner <>.
v3 link:

- add Fixes tags.
- collect reviewed-by tags from linus and jagan.
- replace DRM_ERROR() with dev_err() or drm_err().
- remove kernel-doc markers from struct ili9341_config{}.
- reorder include headers.
- remove the struct device *dev from struct ili9341{}.
- restructure the ili9341_probe() function, add two ili9341_{dbi,dpi)_probe()
  to make it more readable according to jagan's suggestion, thanks.

for the full drm driver exist in drm/panel need Sam and Laurent's feedback.
so, not cover this part at this time, will be update later.

v2 link:

- replace vcc regulator to bulk regulators in driver, from linus suggestion.
- fix dtbs_check warnings on ili9341 dts binding check.
- add bulk regulation node in ilitek,ili9341.yaml.
v1 link:

Dillon Min (3):
  dt-bindings: display: panel: Add ilitek ili9341 panel bindings
  ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding
  drm/panel: Add ilitek ili9341 panel driver

 .../bindings/display/panel/ilitek,ili9341.yaml     |  78 ++
 arch/arm/boot/dts/stm32f429-disco.dts              |   2 +-
 drivers/gpu/drm/panel/Kconfig                      |  12 +
 drivers/gpu/drm/panel/Makefile                     |   1 +
 drivers/gpu/drm/panel/panel-ilitek-ili9341.c       | 792 +++++++++++++++++++++
 5 files changed, 884 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c


             reply	other threads:[~2021-07-24  3:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24  3:44 dillon.minfei [this message]
2021-07-24  3:44 ` [PATCH v4 1/3] dt-bindings: display: panel: Add ilitek ili9341 panel bindings dillon.minfei
2021-08-05  9:08   ` Linus Walleij
2021-07-24  3:44 ` [PATCH v4 2/3] ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding dillon.minfei
2021-08-05  9:11   ` Linus Walleij
2021-08-05  9:19     ` Dillon Min
2021-08-05  9:37       ` Alexandre TORGUE
2021-11-25 14:52   ` Alexandre TORGUE
2021-07-24  3:44 ` [PATCH v4 3/3] drm/panel: Add ilitek ili9341 panel driver dillon.minfei
2021-08-05  9:10   ` Linus Walleij
2021-08-05  8:55 ` [PATCH v4 0/3] " Dillon Min
2021-08-05 10:16 ` Andy Shevchenko
2021-08-05 10:42   ` Dillon Min

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v4 0/3] Add ilitek ili9341 panel driver' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).