LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: cs42l42: Fix inversion of ADC Notch Switch control
@ 2021-08-03 16:08 Richard Fitzgerald
  2021-08-03 16:08 ` [PATCH 2/2] ASoC: cs42l42: Remove duplicate control for WNF filter frequency Richard Fitzgerald
  2021-08-03 22:35 ` [PATCH 1/2] ASoC: cs42l42: Fix inversion of ADC Notch Switch control Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Richard Fitzgerald @ 2021-08-03 16:08 UTC (permalink / raw)
  To: broonie; +Cc: patches, linux-kernel, alsa-devel, Richard Fitzgerald

The underlying register field has inverted sense (0 = enabled) so
the control definition must be marked as inverted.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 2c394ca79604 ("ASoC: Add support for CS42L42 codec")
---
 sound/soc/codecs/cs42l42.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c
index 08ca05bfbeb3..2db87e3a4dc3 100644
--- a/sound/soc/codecs/cs42l42.c
+++ b/sound/soc/codecs/cs42l42.c
@@ -437,7 +437,7 @@ static SOC_ENUM_SINGLE_DECL(cs42l42_wnf05_freq_enum, CS42L42_ADC_WNF_HPF_CTL,
 static const struct snd_kcontrol_new cs42l42_snd_controls[] = {
 	/* ADC Volume and Filter Controls */
 	SOC_SINGLE("ADC Notch Switch", CS42L42_ADC_CTL,
-				CS42L42_ADC_NOTCH_DIS_SHIFT, true, false),
+				CS42L42_ADC_NOTCH_DIS_SHIFT, true, true),
 	SOC_SINGLE("ADC Weak Force Switch", CS42L42_ADC_CTL,
 				CS42L42_ADC_FORCE_WEAK_VCM_SHIFT, true, false),
 	SOC_SINGLE("ADC Invert Switch", CS42L42_ADC_CTL,
-- 
2.11.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-03 22:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-03 16:08 [PATCH 1/2] ASoC: cs42l42: Fix inversion of ADC Notch Switch control Richard Fitzgerald
2021-08-03 16:08 ` [PATCH 2/2] ASoC: cs42l42: Remove duplicate control for WNF filter frequency Richard Fitzgerald
2021-08-03 22:35 ` [PATCH 1/2] ASoC: cs42l42: Fix inversion of ADC Notch Switch control Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).