LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hsin-hsiung Wang <hsin-hsiung.wang@mediatek.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	Henry Chen <henryc.chen@mediatek.com>
Subject: Re: [PATCH v10 4/5] spmi: mediatek: Add support for MT8195
Date: Sat, 7 Aug 2021 11:28:51 +0800	[thread overview]
Message-ID: <1628306931.11590.0.camel@mtksdaap41> (raw)
In-Reply-To: <162827215909.1975443.852277412377742323@swboyd.mtv.corp.google.com>

Hi,

On Fri, 2021-08-06 at 10:49 -0700, Stephen Boyd wrote:
> Quoting Hsin-Hsiung Wang (2021-08-02 23:34:20)
> > From: Henry Chen <henryc.chen@mediatek.com>
> > 
> > Add spmi support for MT8195.
> > 
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> 
> Missing Signed-off-by from hsin-hsiung.wang here
> 

Sorry for the missing. I will add it in the next patch.

Thanks.

> > ---
> > changes since v9:
> > - No change.
> > ---
> >  drivers/spmi/spmi-mtk-pmif.c | 90 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 90 insertions(+)
> > 
> > diff --git a/drivers/spmi/spmi-mtk-pmif.c b/drivers/spmi/spmi-mtk-pmif.c
> > index 94c45d46ab0c..0c320801c9d5 100644
> > --- a/drivers/spmi/spmi-mtk-pmif.c
> > +++ b/drivers/spmi/spmi-mtk-pmif.c
> > @@ -348,6 +427,14 @@ static const struct pmif_data mt6873_pmif_arb = {
> >         .soc_chan = 2,
> >  };
> >  
> > +static const struct pmif_data mt8195_pmif_arb[] = {
> 
> This is an array of type pmif_data.
> 
> > +       {
> > +               .regs = mt8195_regs,
> > +               .spmimst_regs = mt8195_spmi_regs,
> > +               .soc_chan = 2,
> > +       },
> > +};
> > +
> >  static int mtk_spmi_probe(struct platform_device *pdev)
> >  {
> >         struct pmif *arb;
> > @@ -444,6 +531,9 @@ static const struct of_device_id mtk_spmi_match_table[] = {
> >         {
> >                 .compatible = "mediatek,mt6873-spmi",
> >                 .data = &mt6873_pmif_arb,
> 
> mt6873_pmif_arb is not an array, see the context header above.
> 
> How does this work? Has this been tested?
> 
> > +       }, {
> > +               .compatible = "mediatek,mt8195-spmi",
> > +               .data = &mt8195_pmif_arb,
> >         }, {
> >                 /* sentinel */
> >         },
> > -- 
> > 2.18.0
> >


  reply	other threads:[~2021-08-07  3:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  6:34 [PATCH v10 0/5] Add SPMI support for Mediatek SoC IC Hsin-Hsiung Wang
2021-08-03  6:34 ` [PATCH v10 1/5] dt-bindings: spmi: modify the constraint 'maxItems' to 'minItems' Hsin-Hsiung Wang
2021-08-03  6:34 ` [PATCH v10 2/5] dt-bindings: spmi: document binding for the Mediatek SPMI controller Hsin-Hsiung Wang
2021-08-03  6:34 ` [PATCH v10 3/5] spmi: mediatek: Add support for MT6873/8192 Hsin-Hsiung Wang
2021-08-09 17:55   ` Stephen Boyd
2021-08-16 12:11     ` Hsin-hsiung Wang
2021-08-03  6:34 ` [PATCH v10 4/5] spmi: mediatek: Add support for MT8195 Hsin-Hsiung Wang
2021-08-06 17:49   ` Stephen Boyd
2021-08-07  3:28     ` Hsin-hsiung Wang [this message]
2021-08-07  3:51     ` Hsin-hsiung Wang
2021-08-03  6:34 ` [PATCH v10 5/5] arm64: dts: mt8192: add spmi node Hsin-Hsiung Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1628306931.11590.0.camel@mtksdaap41 \
    --to=hsin-hsiung.wang@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=henryc.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --subject='Re: [PATCH v10 4/5] spmi: mediatek: Add support for MT8195' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).