LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yunsheng Lin <linyunsheng@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>
Cc: <alexander.duyck@gmail.com>, <linux@armlinux.org.uk>,
<mw@semihalf.com>, <linuxarm@openeuler.org>,
<yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
<thomas.petazzoni@bootlin.com>, <hawk@kernel.org>,
<ilias.apalodimas@linaro.org>, <ast@kernel.org>,
<daniel@iogearbox.net>, <john.fastabend@gmail.com>,
<akpm@linux-foundation.org>, <peterz@infradead.org>,
<will@kernel.org>, <willy@infradead.org>, <vbabka@suse.cz>,
<fenghua.yu@intel.com>, <guro@fb.com>, <peterx@redhat.com>,
<feng.tang@intel.com>, <jgg@ziepe.ca>, <mcroce@microsoft.com>,
<hughd@google.com>, <jonathan.lemon@gmail.com>, <alobakin@pm.me>,
<willemb@google.com>, <wenxu@ucloud.cn>,
<cong.wang@bytedance.com>, <haokexin@gmail.com>,
<nogikh@google.com>, <elver@google.com>, <yhs@fb.com>,
<kpsingh@kernel.org>, <andrii@kernel.org>, <kafai@fb.com>,
<songliubraving@fb.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
<chenhao288@hisilicon.com>, <edumazet@google.com>,
<yoshfuji@linux-ipv6.org>, <dsahern@kernel.org>,
<memxor@gmail.com>, <linux@rempel-privat.de>,
<atenart@kernel.org>, <weiwan@google.com>, <ap420073@gmail.com>,
<arnd@arndb.de>, <mathew.j.martineau@linux.intel.com>,
<aahringo@redhat.com>, <ceggers@arri.de>, <yangbo.lu@nxp.com>,
<fw@strlen.de>, <xiangxia.m.yue@gmail.com>,
<linmiaohe@huawei.com>
Subject: [PATCH RFC 5/7] sock: support refilling pfrag from pfrag_pool
Date: Wed, 18 Aug 2021 11:32:21 +0800 [thread overview]
Message-ID: <1629257542-36145-6-git-send-email-linyunsheng@huawei.com> (raw)
In-Reply-To: <1629257542-36145-1-git-send-email-linyunsheng@huawei.com>
As previous patch has added pfrag pool based on the page
pool, so support refilling pfrag from the new pfrag pool
for tcpv4.
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
---
include/net/sock.h | 1 +
net/core/sock.c | 9 +++++++++
net/ipv4/tcp.c | 34 ++++++++++++++++++++++++++--------
3 files changed, 36 insertions(+), 8 deletions(-)
diff --git a/include/net/sock.h b/include/net/sock.h
index 6e76145..af40084 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -455,6 +455,7 @@ struct sock {
unsigned long sk_pacing_rate; /* bytes per second */
unsigned long sk_max_pacing_rate;
struct page_frag sk_frag;
+ struct pfrag_pool *sk_frag_pool;
netdev_features_t sk_route_caps;
netdev_features_t sk_route_nocaps;
netdev_features_t sk_route_forced_caps;
diff --git a/net/core/sock.c b/net/core/sock.c
index aada649..53152c9 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -140,6 +140,7 @@
#include <net/busy_poll.h>
#include <linux/ethtool.h>
+#include <net/pfrag_pool.h>
static DEFINE_MUTEX(proto_list_mutex);
static LIST_HEAD(proto_list);
@@ -1934,6 +1935,11 @@ static void __sk_destruct(struct rcu_head *head)
put_page(sk->sk_frag.page);
sk->sk_frag.page = NULL;
}
+ if (sk->sk_frag_pool) {
+ pfrag_pool_flush(sk->sk_frag_pool);
+ kfree(sk->sk_frag_pool);
+ sk->sk_frag_pool = NULL;
+ }
if (sk->sk_peer_cred)
put_cred(sk->sk_peer_cred);
@@ -3134,6 +3140,9 @@ void sock_init_data(struct socket *sock, struct sock *sk)
sk->sk_frag.page = NULL;
sk->sk_frag.offset = 0;
+
+ sk->sk_frag_pool = kzalloc(sizeof(*sk->sk_frag_pool), sk->sk_allocation);
+
sk->sk_peek_off = -1;
sk->sk_peer_pid = NULL;
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index f931def..992dcbc 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -280,6 +280,7 @@
#include <linux/uaccess.h>
#include <asm/ioctls.h>
#include <net/busy_poll.h>
+#include <net/pfrag_pool.h>
/* Track pending CMSGs. */
enum {
@@ -1337,12 +1338,20 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
if (err)
goto do_fault;
} else if (!zc) {
- bool merge = true;
+ bool merge = true, pfrag_pool = true;
int i = skb_shinfo(skb)->nr_frags;
- struct page_frag *pfrag = sk_page_frag(sk);
+ struct page_frag *pfrag;
- if (!sk_page_frag_refill(sk, pfrag))
- goto wait_for_space;
+ pfrag_pool_updata_napi(sk->sk_frag_pool,
+ READ_ONCE(sk->sk_napi_id));
+ pfrag = pfrag_pool_refill(sk->sk_frag_pool, sk->sk_allocation);
+ if (!pfrag) {
+ pfrag = sk_page_frag(sk);
+ if (!sk_page_frag_refill(sk, pfrag))
+ goto wait_for_space;
+
+ pfrag_pool = false;
+ }
if (!skb_can_coalesce(skb, i, pfrag->page,
pfrag->offset)) {
@@ -1369,11 +1378,20 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
if (merge) {
skb_frag_size_add(&skb_shinfo(skb)->frags[i - 1], copy);
} else {
- skb_fill_page_desc(skb, i, pfrag->page,
- pfrag->offset, copy);
- page_ref_inc(pfrag->page);
+ if (pfrag_pool) {
+ skb_fill_pp_page_desc(skb, i, pfrag->page,
+ pfrag->offset, copy);
+ } else {
+ page_ref_inc(pfrag->page);
+ skb_fill_page_desc(skb, i, pfrag->page,
+ pfrag->offset, copy);
+ }
}
- pfrag->offset += copy;
+
+ if (pfrag_pool)
+ pfrag_pool_commit(sk->sk_frag_pool, copy, merge);
+ else
+ pfrag->offset += copy;
} else {
if (!sk_wmem_schedule(sk, copy))
goto wait_for_space;
--
2.7.4
next prev parent reply other threads:[~2021-08-18 3:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 3:32 [PATCH RFC 0/7] add socket to netdev page frag recycling support Yunsheng Lin
2021-08-18 3:32 ` [PATCH RFC 1/7] page_pool: refactor the page pool to support multi alloc context Yunsheng Lin
2021-08-18 3:32 ` [PATCH RFC 2/7] skbuff: add interface to manipulate frag count for tx recycling Yunsheng Lin
2021-08-18 3:32 ` [PATCH RFC 3/7] net: add NAPI api to register and retrieve the page pool ptr Yunsheng Lin
2021-08-18 3:32 ` [PATCH RFC 4/7] net: pfrag_pool: add pfrag pool support based on page pool Yunsheng Lin
2021-08-18 3:32 ` Yunsheng Lin [this message]
2021-08-18 3:32 ` [PATCH RFC 6/7] net: hns3: support tx recycling in the hns3 driver Yunsheng Lin
2021-08-18 8:57 ` [PATCH RFC 0/7] add socket to netdev page frag recycling support Eric Dumazet
2021-08-18 9:36 ` Yunsheng Lin
2021-08-23 9:25 ` [Linuxarm] " Yunsheng Lin
2021-08-23 15:04 ` Eric Dumazet
2021-08-24 8:03 ` Yunsheng Lin
2021-08-25 16:29 ` David Ahern
2021-08-25 16:32 ` Eric Dumazet
2021-08-25 16:38 ` David Ahern
2021-08-25 17:24 ` Eric Dumazet
2021-08-26 4:05 ` David Ahern
2021-08-18 22:05 ` David Ahern
2021-08-19 8:18 ` Yunsheng Lin
2021-08-20 14:35 ` David Ahern
2021-08-23 3:32 ` Yunsheng Lin
2021-08-24 3:34 ` David Ahern
2021-08-24 8:41 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629257542-36145-6-git-send-email-linyunsheng@huawei.com \
--to=linyunsheng@huawei.com \
--cc=aahringo@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alobakin@pm.me \
--cc=andrii@kernel.org \
--cc=ap420073@gmail.com \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=atenart@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=ceggers@arri.de \
--cc=chenhao288@hisilicon.com \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=feng.tang@intel.com \
--cc=fenghua.yu@intel.com \
--cc=fw@strlen.de \
--cc=guro@fb.com \
--cc=haokexin@gmail.com \
--cc=hawk@kernel.org \
--cc=hughd@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jgg@ziepe.ca \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=linuxarm@openeuler.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mcroce@microsoft.com \
--cc=memxor@gmail.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=nogikh@google.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=salil.mehta@huawei.com \
--cc=songliubraving@fb.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vbabka@suse.cz \
--cc=weiwan@google.com \
--cc=wenxu@ucloud.cn \
--cc=will@kernel.org \
--cc=willemb@google.com \
--cc=willy@infradead.org \
--cc=xiangxia.m.yue@gmail.com \
--cc=yangbo.lu@nxp.com \
--cc=yhs@fb.com \
--cc=yisen.zhuang@huawei.com \
--cc=yoshfuji@linux-ipv6.org \
--subject='Re: [PATCH RFC 5/7] sock: support refilling pfrag from pfrag_pool' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).