LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -next] spi: tegra20-slink: remove spi_master_put() in tegra_slink_remove()
@ 2021-08-10 14:22 Yang Yingliang
  2021-08-18 16:26 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-08-10 14:22 UTC (permalink / raw)
  To: linux-kernel, linux-spi; +Cc: ldewangan, broonie

spi_master_put() is already called in spi_unregister_master(), or it
will lead a double decrement refcount.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/spi/spi-tegra20-slink.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index deff16ba6d58..ebd27f883033 100644
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -1154,8 +1154,6 @@ static int tegra_slink_remove(struct platform_device *pdev)
 	if (tspi->rx_dma_chan)
 		tegra_slink_deinit_dma_param(tspi, true);
 
-	spi_master_put(master);
-
 	return 0;
 }
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] spi: tegra20-slink: remove spi_master_put() in tegra_slink_remove()
  2021-08-10 14:22 [PATCH -next] spi: tegra20-slink: remove spi_master_put() in tegra_slink_remove() Yang Yingliang
@ 2021-08-18 16:26 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-08-18 16:26 UTC (permalink / raw)
  To: Yang Yingliang, linux-spi, linux-kernel; +Cc: Mark Brown, ldewangan

On Tue, 10 Aug 2021 22:22:30 +0800, Yang Yingliang wrote:
> spi_master_put() is already called in spi_unregister_master(), or it
> will lead a double decrement refcount.
> 
> 
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: tegra20-slink: remove spi_master_put() in tegra_slink_remove()
      commit: 02cea7039ad52593ee05824c19233366914df9b2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-18 16:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 14:22 [PATCH -next] spi: tegra20-slink: remove spi_master_put() in tegra_slink_remove() Yang Yingliang
2021-08-18 16:26 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).