LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] xgene-v2: Fix a resource leak in the error handling path of 'xge_probe()'
@ 2021-08-21  7:35 Christophe JAILLET
  2021-08-23 10:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2021-08-21  7:35 UTC (permalink / raw)
  To: iyappan, keyur, davem, kuba
  Cc: netdev, linux-kernel, kernel-janitors, Christophe JAILLET

A successful 'xge_mdio_config()' call should be balanced by a corresponding
'xge_mdio_remove()' call in the error handling path of the probe, as
already done in the remove function.

Update the error handling path accordingly.

Fixes: ea8ab16ab225 ("drivers: net: xgene-v2: Add MDIO support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/ethernet/apm/xgene-v2/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/apm/xgene-v2/main.c b/drivers/net/ethernet/apm/xgene-v2/main.c
index 860c18fb7aae..80399c8980bd 100644
--- a/drivers/net/ethernet/apm/xgene-v2/main.c
+++ b/drivers/net/ethernet/apm/xgene-v2/main.c
@@ -677,11 +677,13 @@ static int xge_probe(struct platform_device *pdev)
 	ret = register_netdev(ndev);
 	if (ret) {
 		netdev_err(ndev, "Failed to register netdev\n");
-		goto err;
+		goto err_mdio_remove;
 	}
 
 	return 0;
 
+err_mdio_remove:
+	xge_mdio_remove(ndev);
 err:
 	free_netdev(ndev);
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] xgene-v2: Fix a resource leak in the error handling path of 'xge_probe()'
  2021-08-21  7:35 [PATCH] xgene-v2: Fix a resource leak in the error handling path of 'xge_probe()' Christophe JAILLET
@ 2021-08-23 10:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-23 10:50 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: iyappan, keyur, davem, kuba, netdev, linux-kernel, kernel-janitors

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat, 21 Aug 2021 09:35:23 +0200 you wrote:
> A successful 'xge_mdio_config()' call should be balanced by a corresponding
> 'xge_mdio_remove()' call in the error handling path of the probe, as
> already done in the remove function.
> 
> Update the error handling path accordingly.
> 
> Fixes: ea8ab16ab225 ("drivers: net: xgene-v2: Add MDIO support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> [...]

Here is the summary with links:
  - xgene-v2: Fix a resource leak in the error handling path of 'xge_probe()'
    https://git.kernel.org/netdev/net/c/5ed74b03eb4d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-23 10:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21  7:35 [PATCH] xgene-v2: Fix a resource leak in the error handling path of 'xge_probe()' Christophe JAILLET
2021-08-23 10:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).