LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: kan.liang@linux.intel.com To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org Cc: eranian@google.com, ak@linux.intel.com, Kan Liang <kan.liang@linux.intel.com>, stable@vger.kernel.org Subject: [PATCH 1/7] perf/x86/intel/uncore: Support extra IMC channel on Ice Lake server Date: Thu, 26 Aug 2021 08:32:37 -0700 [thread overview] Message-ID: <1629991963-102621-2-git-send-email-kan.liang@linux.intel.com> (raw) In-Reply-To: <1629991963-102621-1-git-send-email-kan.liang@linux.intel.com> From: Kan Liang <kan.liang@linux.intel.com> There are three channels on a Ice Lake server, but only two channels will ever be active. Current perf only enables two channels. Support the extra IMC channel, which may be activated on some Ice Lake machines. For a non-activated channel, the SW can still access it. The write will be ignored by the HW. 0 is always returned for the reading. Fixes: 2b3b76b5ec67 ("perf/x86/intel/uncore: Add Ice Lake server uncore support") Reviewed-by: Andi Kleen <ak@linux.intel.com> Signed-off-by: Kan Liang <kan.liang@linux.intel.com> Cc: stable@vger.kernel.org --- The patch is a RESEND patch. The original post can be found at https://lore.kernel.org/lkml/1625766302-18875-1-git-send-email-kan.liang@linux.intel.com arch/x86/events/intel/uncore_snbep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/antler/uncore_snbep.c index 9a178a9..72a4181 100644 --- a/arch/x86/events/intel/uncore_snbep.c +++ b/arch/x86/events/intel/uncore_snbep.c @@ -452,7 +452,7 @@ #define ICX_M3UPI_PCI_PMON_BOX_CTL 0xa0 /* ICX IMC */ -#define ICX_NUMBER_IMC_CHN 2 +#define ICX_NUMBER_IMC_CHN 3 #define ICX_IMC_MEM_STRIDE 0x4 /* SPR */ @@ -5458,7 +5458,7 @@ static struct intel_uncore_ops icx_uncore_mmio_ops = { static struct intel_uncore_type icx_uncore_imc = { .name = "imc", .num_counters = 4, - .num_boxes = 8, + .num_boxes = 12, .perf_ctr_bits = 48, .fixed_ctr_bits = 48, .fixed_ctr = SNR_IMC_MMIO_PMON_FIXED_CTR, -- 2.7.4
next prev parent reply other threads:[~2021-08-26 15:36 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-26 15:32 [PATCH 0/7] perf/x86/intel/uncore: Various fix for ICX and SPR kan.liang 2021-08-26 15:32 ` kan.liang [this message] 2021-08-31 12:07 ` [tip: perf/core] perf/x86/intel/uncore: Support extra IMC channel on Ice Lake server tip-bot2 for Kan Liang 2021-08-26 15:32 ` [PATCH 2/7] perf/x86/intel/uncore: Fix invalid unit check kan.liang 2021-08-31 12:07 ` [tip: perf/core] " tip-bot2 for Kan Liang 2021-08-26 15:32 ` [PATCH 3/7] perf/x86/intel/uncore: Fix Intel ICX IIO event constraints kan.liang 2021-08-31 12:07 ` [tip: perf/core] " tip-bot2 for Kan Liang 2021-08-26 15:32 ` [PATCH 4/7] perf/x86/intel/uncore: Fix Intel SPR CHA " kan.liang 2021-08-31 12:07 ` [tip: perf/core] " tip-bot2 for Kan Liang 2021-08-26 15:32 ` [PATCH 5/7] perf/x86/intel/uncore: Fix Intel SPR IIO " kan.liang 2021-08-31 12:07 ` [tip: perf/core] " tip-bot2 for Kan Liang 2021-08-26 15:32 ` [PATCH 6/7] perf/x86/intel/uncore: Fix Intel SPR M2PCIE " kan.liang 2021-08-31 12:07 ` [tip: perf/core] " tip-bot2 for Kan Liang 2021-08-26 15:32 ` [PATCH 7/7] perf/x86/intel/uncore: Fix Intel SPR M3UPI " kan.liang 2021-08-31 12:07 ` [tip: perf/core] " tip-bot2 for Kan Liang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1629991963-102621-2-git-send-email-kan.liang@linux.intel.com \ --to=kan.liang@linux.intel.com \ --cc=ak@linux.intel.com \ --cc=eranian@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).