LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: bgoswami@codeaurora.org, perex@perex.cz,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	srinivas.kandagatla@linaro.org, tiwai@suse.com, vkoul@kernel.org,
	lgirdwood@gmail.com
Cc: Mark@sirena.org.uk, Brown@sirena.org.uk, broonie@kernel.org,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] ASoC: wcd9335: Firx some resources leak in the probe and remove function
Date: Thu, 26 Aug 2021 19:30:25 +0100	[thread overview]
Message-ID: <163000225499.699341.15649110189101404680.b4-ty@kernel.org> (raw)
In-Reply-To: <cover.1629091028.git.christophe.jaillet@wanadoo.fr>

From: Mark Brown,,, <broonie@kernel.org>

On Mon, 16 Aug 2021 07:25:01 +0200, Christophe JAILLET wrote:
> The first 2 patches are sraightforward and look logical to me.
> 
> However, the 3rd one in purely speculative. It is based on the fact that a
> comment states that we enable some irqs on some slave ports. That said, it writes
> 0xFF in some registers.
> 
> So, I guess that we should disable these irqs when the driver is removed. That
> said, writing 0x00 at the same place looks logical to me.
> 
> [...]

Applied, thanks!

[1/3] ASoC: wcd9335: Fix a double irq free in the remove function
      commit: 7a6a723e98aa45f393e6add18f7309dfffa1b0e2
[2/3] ASoC: wcd9335: Fix a memory leak in the error handling path of the probe function
      commit: fc6fc81caa63900cef9ebb8b2e365c3ed5a9effb
[3/3] ASoC: wcd9335: Disable irq on slave ports in the remove function
      commit: d3efd26af2e044ff2b48d38bb871630282d77e60

Best regards,
-- 
Mark Brown,,, <broonie@kernel.org>

      parent reply	other threads:[~2021-08-26 18:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16  5:25 Christophe JAILLET
2021-08-16  5:25 ` [PATCH 1/3] ASoC: wcd9335: Fix a double irq free in the " Christophe JAILLET
2021-08-16  5:25 ` [PATCH 2/3] ASoC: wcd9335: Fix a memory leak in the error handling path of the probe function Christophe JAILLET
2021-08-16  5:25 ` [PATCH 3/3] ASoC: wcd9335: Disable irq on slave ports in the remove function Christophe JAILLET
2021-08-26 18:30 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163000225499.699341.15649110189101404680.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=Brown@sirena.org.uk \
    --cc=Mark@sirena.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    --subject='Re: [PATCH 0/3] ASoC: wcd9335: Firx some resources leak in the probe and remove function' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).